Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve validation for aliases #1549

Merged
merged 4 commits into from
Mar 11, 2023
Merged

improve validation for aliases #1549

merged 4 commits into from
Mar 11, 2023

Conversation

generall
Copy link
Member

  • Check if alias exists on collection creation
  • Force delete alias on collection deletion
  • Tests

ffuugoo
ffuugoo reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@ffuugoo ffuugoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should we also add test_cant_create_alias_if_alias_exists? (Or does such test already exist?)
  • Should we also test, that if we remove an aliased collection, the alias is also removed, and we can successfully create another collection with the same name then?

generall and others added 2 commits March 10, 2023 20:46
@generall @ffuugoo
Update openapi/tests/openapi_integration/test_alias.py
762e372 
Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
@generall @ffuugoo
Update openapi/tests/openapi_integration/test_alias.py
6f2250a 
Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
@generall
Copy link
Member Author

Should we also add test_cant_create_alias_if_alias_exists? (Or does such test already exist?)

This should result in success, idempotency

@generall generall merged commit b34983e into dev Mar 11, 2023
generall added a commit that referenced this pull request Mar 15, 2023
@generall @ffuugoo
improve validation for aliases (#1549)
8775fdc 
* improve validation for aliases

* fmt

* Update openapi/tests/openapi_integration/test_alias.py

Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>

* Update openapi/tests/openapi_integration/test_alias.py

Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>

---------

Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
@generall generall mentioned this pull request Apr 19, 2023
Closed
8 tasks
@agourlay agourlay deleted the fix-alias-operations branch July 12, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffuugoo ffuugoo ffuugoo left review comments

@IvanPleshkov IvanPleshkov IvanPleshkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@generall @ffuugoo @IvanPleshkov