Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested payload filters #1487

Merged
merged 6 commits into from
Feb 23, 2023
Merged

Nested payload filters #1487

merged 6 commits into from
Feb 23, 2023

Conversation

agourlay
Copy link
Member

@agourlay agourlay commented Feb 21, 2023

Follow up on #1465

This PR:

  • propagates the multi-values extracted from the payload by path to indexing
  • unit test nested indexing
  • integration test nested indexing

Some of the testing infra. was duplicated to accommodate the specifics of nested fields. It might be able to merge it later.

@agourlay agourlay requested a review from generall February 21, 2023 20:01
@agourlay agourlay force-pushed the nested-payload-filters branch from 569e217 to f0f60a1 Compare February 21, 2023 20:04
@agourlay agourlay marked this pull request as ready for review February 22, 2023 10:03
@agourlay
Copy link
Member Author

@generall build has been fixed. Good for merge?

@agourlay agourlay merged commit 2770a24 into dev Feb 23, 2023
@agourlay agourlay deleted the nested-payload-filters branch February 23, 2023 14:57
generall added a commit that referenced this pull request Mar 15, 2023
* Nested payload filters

* close ToDo + add parsing of multuiple array values

* fmt

* improve testing nested arrays

* fix NumericIndex to accumulate points_to_values mapping

* revert numberic index + strict array field access

---------

Co-authored-by: Andrey Vasnetsov <andrey@vasnetsov.com>
@generall generall mentioned this pull request Apr 19, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants