$strFormId is useless #1291
Merged
$strFormId is useless #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$strFormId is useless. I think @spekary already tried to refactor some of it. With this commit I try to remove strFormId and pass the object itself. A possible use case is requesting a control by strControlId in a static method call. This is currently impossible, but after this commit you have the objFormId and can actually do this. I have also added a __toString() method in an attempt to save backwards compatibility. If someone does use the strFormId, it gets string cast automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$strFormId is useless. I think @spekary already tried to refactor some of it.
With this commit I try to remove strFormId and pass the object itself.
A possible use case is requesting a control by strControlId in a static method call. This is currently impossible, but after this commit you have the objFormId and can actually do this.
I have also added a __toString() method in an attempt to save backwards compatibility. If someone does use the strFormId, it gets string cast automatically.