Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in CONTRIBUTING.md #6704

Merged
merged 2 commits into from
Apr 27, 2017
Merged

Conversation

zeule
Copy link
Contributor

@zeule zeule commented Apr 27, 2017

No description provided.

@zeule zeule requested review from glassez and Chocobo1 April 27, 2017 16:08
@zeule
Copy link
Contributor Author

zeule commented Apr 27, 2017

Basically just removed whitespace before verbatim block command to make it work.

CONTRIBUTING.md Outdated

### Must read
* If you aren't sure, you can ask on the [**forum**](http://forum.qbittorrent.org) or read our [**wiki**](http://wiki.qbittorrent.org) first.
* Do a quick **search**. Others might already reported the issue.
* Write in **English**!
* Provide **version** information: (You can find version numbers at menu `Help -> About -> Libraries`)
```
```
qBittorrent:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to ensure correct indents,
add 2 spaces in the head of each line in this code block:
(2 spaces) 3x ticks
(2 spaces) qBittorrent:
(2 spaces) ...
(2 spaces) 3x ticks

@zeule
Copy link
Contributor Author

zeule commented Apr 27, 2017

Done

Copy link
Member

@Chocobo1 Chocobo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,18 +1,17 @@
# Filing an issue
# Filing an issue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how is difference with previous version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably was a utf byte order mark (BOM).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there was something, must have been that, but I did all edits online, so can not be sure.

@zeule zeule merged commit 818dcce into master Apr 27, 2017
@zeule zeule deleted the fix-formatting-contributing.md branch April 27, 2017 16:20
@zeule
Copy link
Contributor Author

zeule commented Apr 27, 2017

Thanks!

sledgehammer999 pushed a commit that referenced this pull request May 30, 2017
Fix formatting in CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants