Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite error with optional dependency not installed #613

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Feb 12, 2023

Fix test suite error when pyebsdindex is not installed, add build to test without optional dependencies.

Progress of the PR

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • New contributors are added to release.py, .zenodo.json and
    .all-contributorsrc with the table regenerated.

@ericpre ericpre force-pushed the fix_test_optional_dependency branch from 1c20d59 to 8226b9c Compare February 12, 2023 14:04
Copy link
Member

@hakonanes hakonanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for realizing we needed a run without optional dependencies! Forgot about that.

@hakonanes hakonanes merged commit c60d443 into pyxem:develop Feb 12, 2023
@hakonanes hakonanes added the maintenance This relates to package maintenance label Feb 12, 2023
@hakonanes hakonanes added this to the v0.9.0 milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants