Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language_version in pre-commit config file #195

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

hakonanes
Copy link
Member

@hakonanes hakonanes commented Aug 7, 2020

Signed-off-by: Håkon Wiik Ånes hwaanes@gmail.com

Description

Trying to commit changes with Python 3.8 when language_version: python3.7 in pre-commit config file failed. Since we support both 3.7 and 3.8, this is removed.

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    the unreleased section in doc/changelog.rst.

Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@hakonanes hakonanes added the maintenance This relates to package maintenance label Aug 7, 2020
@hakonanes hakonanes added this to the v0.3.0 milestone Aug 7, 2020
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
@coveralls
Copy link

coveralls commented Aug 7, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling b3be2ff on hakonanes:remove-precommit-language-version into 3568831 on kikuchipy:master.

@hakonanes hakonanes merged commit 778da53 into pyxem:master Aug 7, 2020
@hakonanes hakonanes deleted the remove-precommit-language-version branch August 7, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance This relates to package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants