Fixed sigma input type for v2.GaussianBlur #7887

vfdev-5 · 2023-08-25T12:09:50Z

Fixes #7885

Description:

Fixed int type support in v2.GaussianBlur sigma arg
Added tests

pytorch-bot · 2023-08-25T12:09:56Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7887

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Pending, 1 Unrelated Failure

As of commit 2086d2e with merge base a2f8f8e ():

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

windows (windows.4xlarge, cpu) / windows-job (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

test/test_transforms_v2_refactored.py

test/test_transforms_v2.py

torchvision/transforms/v2/_utils.py

test/test_transforms_v2_refactored.py

torchvision/transforms/v2/_utils.py

NicolasHug

A few tests are failing, this should hopefully fix a few

torchvision/transforms/v2/_utils.py

torchvision/transforms/v2/_misc.py

torchvision/transforms/v2/_geometry.py

torchvision/transforms/v2/_utils.py

Co-authored-by: Philip Meier <github.pmeier@posteo.de>

NicolasHug

LGTM when green, thanks

…an-blur

github-actions · 2023-08-30T16:13:24Z

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

huydhn · 2023-08-30T21:21:26Z

@NicolasHug @vfdev-5 I'm creating a release branch for vision and notice these 2 failures coming from this change:

https://github.com/pytorch/vision/actions/runs/6028057291/job/16360484798 with a build failure

error: more than one operator "=" matches these operands:
             function "__half::operator=(float)"

and https://github.com/pytorch/vision/actions/runs/6028057287/job/16357033703 with a test failure

ERROR test/test_transforms_v2_refactored.py::TestGaussianBlur::test_transform[sigma1-cuda-make_video] - RuntimeError: CUDA error: device-side assert triggered

Could you help take a look to address them as soon as you could? The other option would probably be to revert this change to unblock the release

cc @atalman @osalpekar

vfdev-5 · 2023-08-30T21:38:11Z

@huydhn first failure is unrelated to this PR as happens during the compilation of roi_pool_kernel.cu:
https://github.com/pytorch/vision/actions/runs/6028057291/job/16360484798#step:11:1405

Same for the second failure as according to logs: https://pipelines.actions.githubusercontent.com/serviceHosts/e1cea170-7cad-4fd4-b94c-3e3f4452f685/_apis/pipelines/1/runs/79880/signedlogcontent/12?urlExpires=2023-08-30T21%3A39%3A38.2279569Z&urlSigningMethod=HMACV1&urlSignature=tOpOBPfJVdDJ1jlYYVPow%2FHRlZRU5YmKqd9hMbUySEE%3D

It starts failing with

2023-08-30T19:22:26.6144348Z ==================================== ERRORS ====================================
2023-08-30T19:22:26.6144773Z �[31m�[1m____ ERROR at teardown of test_detection_model[cuda-retinanet_resnet50_fpn] ____�[0m
2023-08-30T19:22:26.6145147Z �[1m�[31mtest/conftest.py�[0m:120: in prevent_leaking_rng
2023-08-30T19:22:26.6145438Z     torch.cuda.set_rng_state(cuda_rng_state)
2023-08-30T19:22:26.6145882Z �[1m�[31m/opt/conda/envs/ci/lib/python3.8/site-packages/torch/cuda/random.py�[0m:64: in set_rng_state
2023-08-30T19:22:26.6146234Z     _lazy_call(cb)
2023-08-30T19:22:26.6146734Z �[1m�[31m/opt/conda/envs/ci/lib/python3.8/site-packages/torch/cuda/__init__.py�[0m:183: in _lazy_call
2023-08-30T19:22:26.6147103Z     callable()
2023-08-30T19:22:26.6147543Z �[1m�[31m/opt/conda/envs/ci/lib/python3.8/site-packages/torch/cuda/random.py�[0m:62: in cb
2023-08-30T19:22:26.6147942Z     default_generator.set_state(new_state_copy)
2023-08-30T19:22:26.6148326Z �[1m�[31mE   RuntimeError: CUDA error: device-side assert triggered�[0m
2023-08-30T19:22:26.6148817Z �[1m�[31mE   CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.�[0m
2023-08-30T19:22:26.6149313Z �[1m�[31mE   For debugging consider passing CUDA_LAUNCH_BLOCKING=1.�[0m
2023-08-30T19:22:26.6149854Z �[1m�[31mE   Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.�[0m
2023-08-30T19:22:26.6150332Z ----------------------------- Captured stderr call -----------------------------

none of further CUDA tests is passing.

huydhn · 2023-08-30T21:59:32Z

Let me retry these job one more time. Something else is probably causing these failures then and they are indeed pasing again in the latest vision commit https://hud.pytorch.org/hud/pytorch/vision/main

Reviewed By: matteobettini Differential Revision: D48900377 fbshipit-source-id: 72b40e1fd390214714d1a964ca3d4373db9bde34 Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

facebook-github-bot added the cla signed label Aug 25, 2023

vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive

vfdev-5 had a problem deploying to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Failure

vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive

vfdev-5 requested a review from pmeier August 25, 2023 12:24

pmeier reviewed Aug 25, 2023

View reviewed changes

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

test/test_transforms_v2.py Outdated Show resolved Hide resolved

torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved

torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved

vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 13:48 — with GitHub Actions Inactive

vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 15:12 — with GitHub Actions Inactive

pmeier reviewed Aug 28, 2023

View reviewed changes

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

NicolasHug reviewed Aug 29, 2023

View reviewed changes

torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved

torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved

NicolasHug reviewed Aug 30, 2023

View reviewed changes

torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved

torchvision/transforms/v2/_misc.py Outdated Show resolved Hide resolved

torchvision/transforms/v2/_geometry.py Outdated Show resolved Hide resolved

torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved

vfdev-5 and others added 6 commits August 30, 2023 14:31

fix sigma input type for v2.GaussianBlur

76b7c92

Updated code and tests

0077a7c

fixed code formatting issue

83fbd3a

Update test/test_transforms_v2_refactored.py

6ac3f5f

Co-authored-by: Philip Meier <github.pmeier@posteo.de>

addressed review comments

6e54234

Fixed failing tests

ae31288

vfdev-5 force-pushed the fix-7885-gaussian-blur branch from ca8be8a to ae31288 Compare August 30, 2023 14:43

NicolasHug approved these changes Aug 30, 2023

View reviewed changes

NicolasHug added 2 commits August 30, 2023 16:42

Merge branch 'main' of github.com:pytorch/vision into fix-7885-gaussi…

bcee141

…an-blur

Fix tests

2086d2e

NicolasHug merged commit f1b4c7a into main Aug 30, 2023

NicolasHug added bug module: transforms labels Aug 30, 2023

pmeier mentioned this pull request Sep 6, 2023

port tests for F.gaussian_blur GaussianBlur #7935

Merged

vfdev-5 deleted the fix-7885-gaussian-blur branch September 7, 2023 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed sigma input type for v2.GaussianBlur #7887

Fixed sigma input type for v2.GaussianBlur #7887

vfdev-5 commented Aug 25, 2023

pytorch-bot bot commented Aug 25, 2023 •

edited

Loading

NicolasHug left a comment

NicolasHug left a comment

github-actions bot commented Aug 30, 2023

huydhn commented Aug 30, 2023 •

edited

Loading

vfdev-5 commented Aug 30, 2023 •

edited

Loading

huydhn commented Aug 30, 2023

Fixed sigma input type for v2.GaussianBlur #7887

Fixed sigma input type for v2.GaussianBlur #7887

Conversation

vfdev-5 commented Aug 25, 2023

pytorch-bot bot commented Aug 25, 2023 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7887

❌ 3 New Failures, 1 Pending, 1 Unrelated Failure

NicolasHug left a comment

Choose a reason for hiding this comment

NicolasHug left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 30, 2023

huydhn commented Aug 30, 2023 • edited Loading

vfdev-5 commented Aug 30, 2023 • edited Loading

huydhn commented Aug 30, 2023

pytorch-bot bot commented Aug 25, 2023 •

edited

Loading

huydhn commented Aug 30, 2023 •

edited

Loading

vfdev-5 commented Aug 30, 2023 •

edited

Loading