Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable the autocast test for fasterrcnn_resnet50_fpn #6660

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Sep 28, 2022

Related to #6655
Done to unblock #6649
Alternative approaches at #6658 #6608

This PR:

  • Reverts a previous mitigation introduced by @malfet for Windows as now we also need it on Linux
  • Adds the tests on the list that skips autocast tests

It's very strange that fasterrcnn_resnet50_fpn is impacted but fasterrcnn_resnet50_fpn_v2 is not. There are differences between the models but only in terms of the number of CNNs each model has. So it's very likely the issue is on a kernel which is affected by a CUDA 11.6 change.

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datumbox
Copy link
Contributor Author

The failing tests on prototype are unrelated and already patched on a previous PR. Merging.

@datumbox datumbox merged commit c2ca691 into pytorch:main Sep 28, 2022
@datumbox datumbox deleted the tests/tmp_remove_autocast_fasterrcnn branch September 28, 2022 13:18
facebook-github-bot pushed a commit that referenced this pull request Sep 29, 2022
…50_fpn` (#6660)

Summary:
* Revert "Bump tol for autocasted `fasterrcnn_resnet50_fpn` (#6601)"

This reverts commit a4f5330.

* Temporarily remove FasterRCNN autocast test

Reviewed By: YosuaMichael

Differential Revision: D39886046

fbshipit-source-id: 6d04da5a1db91cebe9dd9f71c4c3a506bcbe1911
facebook-github-bot pushed a commit that referenced this pull request Oct 7, 2022
…50_fpn` (#6660)

Summary:
* Revert "Bump tol for autocasted `fasterrcnn_resnet50_fpn` (#6601)"

This reverts commit a4f5330.

* Temporarily remove FasterRCNN autocast test

Reviewed By: datumbox

Differential Revision: D40138733

fbshipit-source-id: 1a5754c74fe08fc16b5de0cdb6c959b535e4ea4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants