Modify formatter version in contributing guide #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit b9a7842 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
oke-aditya
reviewed
Mar 2, 2022
| @@ -83,7 +83,7 @@ Instead of relying directly on `black` however, we rely on | |||
| [ufmt](https://github.com/omnilib/ufmt), for compatibility reasons with Facebook | |||
| internal infrastructure. | |||
|
|
|||
| To format your code, install `ufmt` with `pip install ufmt` and use e.g.: | |||
| To format your code, install `ufmt` with `pip install ufmt==1.3.2 black==21.9b0 usort==0.6.4` and use e.g.: | |||
There was a problem hiding this comment.
I think ufmt automatically installs black and usort? Or is it that it does not pin these versions?
There was a problem hiding this comment.
ufmt only has very lose pins: https://github.com/omnilib/ufmt/blob/a5c73d35bcc00a99f2cfbb7f12eb15ef340db9b6/pyproject.toml#L11-L17
Since we check against these versions in CI, we need a strict pin.
pmeier
approved these changes
Mar 2, 2022
datumbox
added
the
other
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
Summary: Co-authored-by: Dbhasin1 <drishti_b@me.iitr.c.in> Reviewed By: datumbox Differential Revision: D34579509 fbshipit-source-id: c32ed808e31d57c0d9c511a8d2b85c2aa1a4ac63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #5452 (comment)
cc @pmeier