Graduate ConvNeXt to main TorchVision area #5330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit d40ba15 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 cmake_macos_cpu |
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh | |
| sh conda.sh -b | ||
| source $HOME/miniconda3/bin/activate | ||
| conda install -yq conda-build cmake | ||
| packaging/build_cmake.sh | ||
| 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
datumbox
commented
Feb 1, 2022
| } | ||
|
|
||
|
|
||
| class LayerNorm2d(nn.LayerNorm): |
There was a problem hiding this comment.
Start of copy-pasted code.
| return x | ||
|
|
||
| def forward(self, x: Tensor) -> Tensor: | ||
| return self._forward_impl(x) |
There was a problem hiding this comment.
End of copy-pasted code.
NicolasHug
approved these changes
Feb 1, 2022
| `"A ConvNet for the 2020s" <https://arxiv.org/abs/2201.03545>`_ paper. | ||
| Args: | ||
| pretrained (bool): If True, returns a model pre-trained on ImageNet | ||
| progress (bool): If True, displays a progress bar of the download to stderr |
There was a problem hiding this comment.
should we document the kwargs here? For the RAFT models I wrote
kwargs (dict): Parameters that will be passed to the :class:`~torchvision.models.optical_flow.RAFT` class
to override any default.
which I would agree is still awkward, considering the RAFT class isn't even exposed in the docs for now
There was a problem hiding this comment.
Hmm... Nowhere else on the models module we use document kwargs. Perhaps that's something worth considering on the new documentation? I think it might be worth chatting about how we will use it going forwards (previously we pushed parameters that are specific to the model and that kept the model builder signatures uniform, though I'm not sure why this is good).
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
Summary: * Graduate ConvNeXt to main TorchVision area. * Linter and all var. * Renaming var and making named params mandatory. Reviewed By: kazhang Differential Revision: D33927493 fbshipit-source-id: 12dcbd2463f6dfce7e6b53a347f0c5bfa42b3a48
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving ConvNeXt's key classes from prototype to main area. The prototype area remains only for the Multi-weights support API.