Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*FileLoader -> *FileOpener #5128

Merged
merged 5 commits into from
Jan 6, 2022
Merged

*FileLoader -> *FileOpener #5128

merged 5 commits into from
Jan 6, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Dec 27, 2021 •
edited by pytorch-probot bot
Loading

Addresses pytorch/pytorch#70367 and pytorch/data#148. CI failures are expected until the other two PRs are landed.

cc @pmeier @bjuncek

@pmeier pmeier requested a review from NivekT December 27, 2021 07:27
@facebook-github-bot
Copy link

facebook-github-bot commented Dec 27, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6c11358 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 3 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

NivekT
NivekT approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making these changes. Please wait until the other 2 PRs land to land this one. I will let you know.

@NivekT NivekT marked this pull request as ready for review January 4, 2022 17:04
NivekT
NivekT reviewed Jan 4, 2022
View reviewed changes
torchvision/prototype/datasets/_folder.py Outdated Show resolved Hide resolved
torchvision/prototype/datasets/utils/_resource.py Outdated Show resolved Hide resolved
torchvision/prototype/datasets/utils/_resource.py Outdated Show resolved Hide resolved
@NivekT
Copy link
Contributor

NivekT commented Jan 5, 2022

@pmeier I have merged the TorchData PR. The CI tests here mostly look good, but there are a few failures (seem unrelated to me).

@pmeier pmeier merged commit 578c154 into pytorch:main Jan 6, 2022
@pmeier pmeier deleted the file-loader-opener branch January 6, 2022 07:01
facebook-github-bot pushed a commit that referenced this pull request Jan 8, 2022
@prabhat00155 @NivekT @facebook-github-bot
[fbsync] *FileLoader -> *FileOpener (#5128)
3d4c915 
Summary:
* *FileLoader -> *FileOpener

* fix opening mode

Reviewed By: sallysyw

Differential Revision: D33479276

fbshipit-source-id: db4a66b21416afc73c04f50da83b3ca6de073494

Co-authored-by: Kevin Tse <NivekT@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NivekT NivekT NivekT approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed module: datasets prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @facebook-github-bot @NivekT