Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FER2013 dataset #5120

Merged
merged 5 commits into from
Jan 5, 2022
Merged

FER2013 dataset #5120

merged 5 commits into from
Jan 5, 2022

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Dec 21, 2021 •
edited by pytorch-probot bot
Loading

Addresses #5108.

cc @pmeier @bjuncek

@pmeier pmeier requested a review from NicolasHug December 21, 2021 17:44
@facebook-github-bot
Copy link

facebook-github-bot commented Dec 21, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 7d70aab (more details on the Dr. CI page):

1 failure not recognized by patterns:

Job Step Action
CircleCI unittest_macos_cpu_py3.7 Run tests 🔁 rerun

🚧 4 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet.

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pmeier pmeier mentioned this pull request Dec 21, 2021
Closed
14 tasks
NicolasHug
NicolasHug approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pmeier . I made some minor comments, but LGTM anyway.

torchvision/datasets/fer2013.py Outdated Show resolved Hide resolved
torchvision/datasets/fer2013.py Outdated Show resolved Hide resolved
torchvision/datasets/fer2013.py Outdated Show resolved Hide resolved
@pmeier pmeier merged commit 80b0e35 into pytorch:main Jan 5, 2022
@pmeier pmeier deleted the datasets/fer2013 branch January 5, 2022 15:28
facebook-github-bot pushed a commit that referenced this pull request Jan 8, 2022
@prabhat00155 @NicolasHug @facebook-github-bot
[fbsync] FER2013 dataset (#5120)
2373376 
Summary:
* add prototype dataset

* add old style dataset

* Apply suggestions from code review

* refactor integrity check

Reviewed By: sallysyw

Differential Revision: D33479268

fbshipit-source-id: 239a0efb550b21ce0c39ed94caf7436d89813f65

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed module: datasets new feature prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @facebook-github-bot @NicolasHug