Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "(temporary) add pyyaml to unittest requirements" #5112

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Revert "(temporary) add pyyaml to unittest requirements" #5112

merged 1 commit into from
Dec 19, 2021

Conversation

datumbox
Copy link
Contributor

Reverts #5099

Fix no longer needed as per #5099 (comment)

@datumbox datumbox added dependency issue revert(ed) For reverted PRs, and PRs that revert other PRs labels Dec 18, 2021
@datumbox datumbox requested review from malfet and fmassa December 18, 2021 11:20
@facebook-github-bot
Copy link

facebook-github-bot commented Dec 18, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3bdb002 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build unittest_prototype (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

�[31m=============================== �[31m�[1m1...0.49s�[0m�[31m ===============================�[0m 
    for config in datasets.info(name)._configs
  File "/home/circleci/project/test/builtin_dataset_mocks.py", line 125, in load
    decoder=DEFAULT_DECODER_MAP.get(dataset.info.type) if decoder is DEFAULT_DECODER else decoder,
  File "/home/circleci/project/torchvision/prototype/datasets/_builtin/mnist.py", line 139, in _make_datapipe
    return Mapper(dp, self._collate_and_decode, fn_kwargs=dict(config=config, decoder=decoder))
TypeError: __init__() got an unexpected keyword argument 'fn_kwargs'
------ generated xml file: /home/circleci/project/test-results/junit.xml -------
=========================== short test summary info ============================
ERROR test/test_prototype_builtin_datasets.py - TypeError: __init__() got an ...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
�[31m=============================== �[31m�[1m1 error�[0m�[31m in 0.49s�[0m�[31m ===============================�[0m


Exited with code exit status 2
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@datumbox datumbox requested a review from pmeier December 18, 2021 11:20
pmeier
pmeier approved these changes Dec 18, 2021
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@datumbox
Copy link
Contributor Author

@pmeier The breakages (1, 2) seem unrelated and due to changes on the DataPipes. Just a heads up in case you haven't seen.

@pmeier
Copy link
Collaborator

pmeier commented Dec 18, 2021

Breakages come from pytorch/pytorch#69560. Will send a fix soon.

@pmeier pmeier mentioned this pull request Dec 19, 2021
Merged
@datumbox datumbox merged commit 40be657 into main Dec 19, 2021
@datumbox datumbox deleted the revert-5099-fix-ci branch December 19, 2021 13:44
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox datumbox added the other if you have no clue or if you will manually handle the PR in the release notes label Dec 19, 2021
facebook-github-bot pushed a commit that referenced this pull request Dec 21, 2021
@datumbox @facebook-github-bot
[fbsync] Revert "(temporary) add pyyaml to unittest requirements (#…
d2b6168 
…5099)" (#5112)

Summary: This reverts commit 743fe1a.

Reviewed By: prabhat00155

Differential Revision: D33253467

fbshipit-source-id: 70dd77709f274478f4a36ff3f04eccf16cbbf21e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@malfet malfet Awaiting requested review from malfet

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
ciflow/default cla signed dependency issue other if you have no clue or if you will manually handle the PR in the release notes revert(ed) For reverted PRs, and PRs that revert other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datumbox @facebook-github-bot @pmeier