Zero-init the residual branch in resnet #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fmassa Could you take a look? |
|
Hey, I think the only way I'd accept such modifications would be if we pass extra arguments into the constructor to modify the way we initialize the weights. I don't want to break backwards-compatibility as lots of people are using this model already. |
|
This only makes the model better without any user-side changes. But sure I can make it optional. |
|
I have. On ResNet50 I'm able to get 23.6~23.7 error with pytorch. Without this change it's about 24.1 |
|
@fmassa I added it as an argument |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.