Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RandomClipSampler to references #1186

Merged
merged 2 commits into from
Jul 31, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Jul 31, 2019

As discussed in #1180 (comment) , let's keep this in references for now, while we figure out where in torchvision to put this.
We might want to have a subpackage in torchvision for all the samplers.

@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #1186 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1186     +/-   ##
=========================================
- Coverage   65.87%   65.67%   -0.2%     
=========================================
  Files          79       79             
  Lines        5849     5827     -22     
  Branches      890      887      -3     
=========================================
- Hits         3853     3827     -26     
- Misses       1726     1730      +4     
  Partials      270      270
Impacted Files Coverage Δ
torchvision/datasets/video_utils.py 84.07% <ø> (-1.12%) ⬇️
torchvision/transforms/functional.py 70.23% <0%> (-0.87%) ⬇️
torchvision/transforms/transforms.py 80.94% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4d17f...0c0e252. Read the comment docs.

@fmassa fmassa merged commit 94c9417 into pytorch:master Jul 31, 2019
@fmassa fmassa deleted the move-randomclipsampler branch July 31, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants