Make dim divisible by 4 requirement more explicit #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37496262 |
xush6528
added a commit
to xush6528/torchrec
that referenced
this pull request
Jun 29, 2022
Summary: Pull Request resolved: pytorch#490 # Problem User report here https://fb.prod.workplace.com/groups/1069285536500339/permalink/5254923157936535/ Error stack, P512815141 PyTorch batched embedding table op requires dim to be divisible by 4. The particular error is asserting one table is having dim=1. Code pointer to the assertion, https://fburl.com/code/rucb3gzn # Improvement Make the assertion more actionable to users. Include table names to users know which model config to look at. # Solution Verify and assert here instead, because here we still have context about table_names. https://fburl.com/code/5ukomhpt Differential Revision: D37496262 fbshipit-source-id: 1fc5c3c0d19782932e17ac4fdb9ec40d962591b0
xush6528
force-pushed
the
export-D37496262
branch
from
8849c7a to
84c7270
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37496262 |
Summary: Pull Request resolved: pytorch#490 # Problem User report here https://fb.prod.workplace.com/groups/1069285536500339/permalink/5254923157936535/ Error stack, P512815141 PyTorch batched embedding table op requires dim to be divisible by 4. The particular error is asserting one table is having dim=1. Code pointer to the assertion, https://fburl.com/code/rucb3gzn # Improvement Make the assertion more actionable to users. Include table names to users know which model config to look at. Verify and assert ahead when we still have context about table_names. https://fburl.com/code/5ukomhpt Reviewed By: divchenko Differential Revision: D37496262 fbshipit-source-id: 761c666b2e1d173edfa8cfef4aea77cabcfaf022
xush6528
force-pushed
the
export-D37496262
branch
from
84c7270 to
c9daf25
Compare
|
This pull request was exported from Phabricator. Differential Revision: D37496262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Problem
User report here
https://fb.prod.workplace.com/groups/1069285536500339/permalink/5254923157936535/
Error stack, P512815141
PyTorch batched embedding table op requires dim to be divisible by 4.
The particular error is asserting one table is having dim=1.
Code pointer to the assertion, https://fburl.com/code/rucb3gzn
Improvement
Make the assertion more actionable to users.
Include table names to users know which model config to look at.
Solution
Verify and assert here instead, because here we still have context about table_names.
https://fburl.com/code/5ukomhpt
Differential Revision: D37496262