Validate sparse features of input request #482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37385890 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D37385890 |
s4ayub
added a commit
to s4ayub/torchrec-3
that referenced
this pull request
Jun 28, 2022
Summary: Pull Request resolved: pytorch#482 Why is validation in `populateTrecRequestFromTensorMap` in `TrecGpuUtils.cpp`? - because I didn't want to iterate through all the features twice. we already have to iterate through all the features once to convert the request to a torchrec request, to be efficient, the validation should happen during this conversion as well - if `populateTrecRequestFromTensorMap` throws an exception, it is handled by `TrecGpuMon.cpp` already Differential Revision: D37385890 fbshipit-source-id: c3eb616d985bbee55a42e9ce74b5f61e0eb7955a
s4ayub
added a commit
to s4ayub/torchrec-3
that referenced
this pull request
Jun 29, 2022
Summary: Pull Request resolved: pytorch#482 Why is validation in `populateTrecRequestFromTensorMap` in `TrecGpuUtils.cpp`? - because I didn't want to iterate through all the features twice. we already have to iterate through all the features once to convert the request to a torchrec request, to be efficient, the validation should happen during this conversion as well - if `populateTrecRequestFromTensorMap` throws an exception, it is handled by `TrecGpuMon.cpp` already Reviewed By: zyan0 Differential Revision: D37385890 fbshipit-source-id: 119fb13fbe8e37fb28c08c3e726ab914162b97be
|
This pull request was exported from Phabricator. Differential Revision: D37385890 |
Summary: Pull Request resolved: pytorch#482 Why is validation in `populateTrecRequestFromTensorMap` in `TrecGpuUtils.cpp`? - because I didn't want to iterate through all the features twice. we already have to iterate through all the features once to convert the request to a torchrec request, to be efficient, the validation should happen during this conversion as well - if `populateTrecRequestFromTensorMap` throws an exception, it is handled by `TrecGpuMon.cpp` already Reviewed By: zyan0 Differential Revision: D37385890 fbshipit-source-id: 7f6d2271ba261788cddd1a4d88b89dda757e6a5f
|
This pull request was exported from Phabricator. Differential Revision: D37385890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
the validation i have right now checks whether the sum of the lengths tensor matches the size of the values tensor
this has to hold true (based on this example: https://www.internalfb.com/code/fbsource/[0d1af3ec6b12bbccd59a22f3e6f2e0f9bd01aa6b]/fbcode/torchrec/sparse/jagged_tensor.py?lines=643-659)
next:
Why is validation in
populateTrecRequestFromTensorMapinTrecGpuUtils.cpp?populateTrecRequestFromTensorMapthrows an exception, it is handled byTrecGpuMon.cppalreadyDifferential Revision: D37385890