Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Defaults split_trajs to False #947

Merged
merged 11 commits into from
Mar 10, 2023
Merged

[Refactor] Defaults split_trajs to False #947

merged 11 commits into from
Mar 10, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Mar 2, 2023 •
edited
Loading

Description

Turns off split_trajs in default collectors args.

Also solves #952

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2023
@vmoens vmoens added the Refactoring Refactoring of an existing feature label Mar 9, 2023
@vmoens vmoens linked an issue Mar 10, 2023 that may be closed by this pull request
[BUG] MultiStep breaks with split_trajs=False #952
Closed
@vmoens vmoens merged commit 2de55cb into main Mar 10, 2023
@vmoens vmoens deleted the turn_off_split branch March 10, 2023 09:15
@vmoens vmoens mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] MultiStep breaks with split_trajs=False
2 participants
@vmoens @facebook-github-bot