Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Major, BugFix, Test] Refactor Transforms tests #878

Merged
merged 78 commits into from
Feb 3, 2023
Merged

[Major, BugFix, Test] Refactor Transforms tests #878

merged 78 commits into from
Feb 3, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 29, 2023 •
edited
Loading

Description

Adds an abstract class for transforms tests:

  • BinarizeReward
  • CatFrames
  • CatTensors
  • CenterCrop
  • DiscreteActionProjection
  • DoubleToFloat
  • ExcludeTransform
  • FiniteTensorDictCheck -> existing tests are sufficient
  • FlattenObservation
  • FrameSkipTransform
  • GrayScale
  • gSDENoise
  • NoopResetEnv
  • ObservationNorm
  • PinMemoryTransform -> existing tests are sufficient
  • R3MTransform
  • Resize
  • RewardClipping
  • RewardScaling
  • RewardSum
  • SelectTransform
  • SqueezeTransform
  • StepCounter
  • TensorDictPrimer
  • TimeMaxPool
  • ToTensorImage
  • UnsqueezeTransform
  • VIPTransform

Additional fixes:

  • Fixes Serial and Parallel env for congruency of read/write methods
  • Fixes populating CatFrames buffer + setting an unwanted "_reset" key
  • Fixes StepCounter for batched envs, where the batch env lost track of the steps during rollout
  • Adds "step_count" to the input specs of StepCounter

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2023
@vmoens vmoens changed the title [BugFix] Multiprocess step count [Major, BugFix, Test] Refactor Transforms tests Jan 30, 2023
@vmoens vmoens added the bug Something isn't working label Jan 30, 2023
@vmoens vmoens merged commit ee7a498 into main Feb 3, 2023
@vmoens vmoens deleted the fix_mp_stepcount branch March 31, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot