Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Move loggers to torchrl.record #854

Merged
merged 2 commits into from
Jan 22, 2023
Merged

[Refactor] Move loggers to torchrl.record #854

merged 2 commits into from
Jan 22, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 22, 2023

Description

Moves the loggers to torchrl.record instead of trainer

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2023
@vmoens vmoens added bc breaking backward compatibility breaking change and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 22, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2023
@vmoens vmoens merged commit 8ab85c6 into main Jan 22, 2023
@vmoens vmoens deleted the move_loggers branch January 22, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bc breaking backward compatibility breaking change CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot