Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary definition from CMakeLists.txt #80

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Remove unnecessary definition from CMakeLists.txt #80

merged 1 commit into from
Apr 19, 2022

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Apr 19, 2022

Removing it because the global variable is not used and not a good practice.

(a bit of history: I added the original line in torchaudio, and later learned that it's not necessary.)

@mthrok
Remove unnecessary definition from CMakeLists.txt
e6bd76e 
Removing it because the global variable is not used and not a good practice.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2022
@vmoens vmoens merged commit 8042232 into pytorch:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mthrok @facebook-github-bot @vmoens