Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow undounded boxes creation from gym spaces #778

Merged
merged 2 commits into from
Dec 31, 2022
Merged

Allow undounded boxes creation from gym spaces #778

merged 2 commits into from
Dec 31, 2022

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Dec 31, 2022 •
edited
Loading

Previously only bounded tensors are created from gym specs.

In this PR we create unbounded tensor specs if all the high and low values of the gym Box are inf

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2022
vmoens
vmoens approved these changes Dec 31, 2022
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens merged commit 5c4ec83 into pytorch:main Dec 31, 2022
@matteobettini matteobettini deleted the unbounded_gym branch January 1, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot