Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test optional dependencies #77

Merged
merged 13 commits into from
Apr 19, 2022
Merged

Test optional dependencies #77

merged 13 commits into from
Apr 19, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 16, 2022 •
edited
Loading

Implements and corrects tests to make sure that all the listed optional deps are truly optional

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2022
@vmoens vmoens marked this pull request as ready for review April 19, 2022 16:50
@vmoens vmoens merged commit 2e390a1 into main Apr 19, 2022
@vmoens vmoens mentioned this pull request Apr 20, 2022
Closed
@vmoens vmoens added the quality code quality label Apr 20, 2022
@vmoens vmoens deleted the issue76_optdeps branch April 20, 2022 09:49
@vmoens vmoens linked an issue Apr 20, 2022 that may be closed by this pull request
Test optional dependencies #76
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test optional dependencies
2 participants
@vmoens @facebook-github-bot