Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] docstrings and setup fixes #726

Merged
merged 2 commits into from
Dec 6, 2022
Merged

[Minor] docstrings and setup fixes #726

merged 2 commits into from
Dec 6, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Dec 6, 2022 •
edited
Loading

Description

Fixes some minor issues in setup.py and docstrings

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022 •
edited
Loading

Codecov Report

Merging #726 (000c8a8) into main (79eeb3c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #726   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         120      120           
  Lines       20234    20234           
=======================================
  Hits        17949    17949           
  Misses       2285     2285
Flag Coverage Δ
habitat-gpu 25.05% <100.00%> (ø)
linux-cpu 85.65% <100.00%> (ø)
linux-gpu 86.60% <100.00%> (ø)
linux-jumanji 30.27% <100.00%> (ø)
linux-outdeps-gpu 72.10% <100.00%> (ø)
linux-stable-cpu 85.51% <100.00%> (ø)
linux-stable-gpu 86.23% <100.00%> (ø)
linux_examples-gpu 43.09% <100.00%> (ø)
macos-cpu 85.32% <100.00%> (ø)
olddeps-gpu 76.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchrl/modules/models/models.py 95.83% <ø> (ø)
torchrl/trainers/__init__.py 100.00% <ø> (ø)
torchrl/trainers/trainers.py 77.66% <ø> (ø)
torchrl/collectors/collectors.py 71.40% <100.00%> (ø)
torchrl/data/utils.py 89.28% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vmoens vmoens merged commit 44fb1b7 into main Dec 6, 2022
@vmoens vmoens deleted the minor branch December 6, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot