[Refactoring] Replace direct gym version checks with decorated functions (#) #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit. Only tests.
# Conflicts: # test/_utils_internal.py # test/test_libs.py
facebook-github-bot
added
the
CLA Signed
vmoens
added a commit
that referenced
this pull request
Nov 23, 2022
* amend * [BugFix] ConvNet forward method with tensors of more than 4 dimensions (#686) * cnn forward fix * more general code * cnn testing * precommit run check * convnet tests * [Feature] add `standard_normal` for RewardScaling (#682) * Add standard_normal * give attribute access * Update standard_normal * Update tests * Fix tests * Address in-place scaling of reward * Improvise tests * [Feature] Jumanji envs (#674) * amend * [Feature] Default collate_fn (#688) * init * amend * amend * [BugFix] Fix Examples (#687) * amend * [Refactoring] Replace direct gym version checks with decorated functions (#691) * [Refactoring] Replace gym version checking with decorated functions (#) Initial commit. Only tests. * Refactoring in gym.py * More refactoring in gym.py * Completed refactoring * amend * amend * Version 0.0.3 (#696) * [Docs] Host TensorDict docs inside TorchRL docs (#693) * Pull tensordict docs into TorchRL docs * Add banner for tensordict docs * [BugFix] Fix docs build (#698) * [BugFix] Proper error messages for orphan transform creation (#697) * amend * [Feature] Append, init and insert transforms in ReplayBuffer (#695) * lint Co-authored-by: albertbou92 <albertbou92@users.noreply.github.com> Co-authored-by: Aditya Gandhamal <61016383+adityagandhamal@users.noreply.github.com> Co-authored-by: yingchenlin <yc.jon.lin@gmail.com> Co-authored-by: Sergey Ordinskiy <113687736+ordinskiy@users.noreply.github.com> Co-authored-by: Tom Begley <tomcbegley@gmail.com> Co-authored-by: Alan Schelten <alan@schelten.net>
vmoens
added a commit
that referenced
this pull request
Jan 5, 2023
* init * tests1 * run examples in tests * [Feature] MPPI Planner (#694) * amend * [BugFix] ConvNet forward method with tensors of more than 4 dimensions (#686) * cnn forward fix * more general code * cnn testing * precommit run check * convnet tests * [Feature] add `standard_normal` for RewardScaling (#682) * Add standard_normal * give attribute access * Update standard_normal * Update tests * Fix tests * Address in-place scaling of reward * Improvise tests * [Feature] Jumanji envs (#674) * amend * [Feature] Default collate_fn (#688) * init * amend * amend * [BugFix] Fix Examples (#687) * amend * [Refactoring] Replace direct gym version checks with decorated functions (#691) * [Refactoring] Replace gym version checking with decorated functions (#) Initial commit. Only tests. * Refactoring in gym.py * More refactoring in gym.py * Completed refactoring * amend * amend * Version 0.0.3 (#696) * [Docs] Host TensorDict docs inside TorchRL docs (#693) * Pull tensordict docs into TorchRL docs * Add banner for tensordict docs * [BugFix] Fix docs build (#698) * [BugFix] Proper error messages for orphan transform creation (#697) * amend * [Feature] Append, init and insert transforms in ReplayBuffer (#695) * lint Co-authored-by: albertbou92 <albertbou92@users.noreply.github.com> Co-authored-by: Aditya Gandhamal <61016383+adityagandhamal@users.noreply.github.com> Co-authored-by: yingchenlin <yc.jon.lin@gmail.com> Co-authored-by: Sergey Ordinskiy <113687736+ordinskiy@users.noreply.github.com> Co-authored-by: Tom Begley <tomcbegley@gmail.com> Co-authored-by: Alan Schelten <alan@schelten.net> * lint Co-authored-by: albertbou92 <albertbou92@users.noreply.github.com> Co-authored-by: Aditya Gandhamal <61016383+adityagandhamal@users.noreply.github.com> Co-authored-by: yingchenlin <yc.jon.lin@gmail.com> Co-authored-by: Sergey Ordinskiy <113687736+ordinskiy@users.noreply.github.com> Co-authored-by: Tom Begley <tomcbegley@gmail.com> Co-authored-by: Alan Schelten <alan@schelten.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces direct gym version checks with
@implement_fordecorated functions (primarilygym.pyand tests), except some places in tests where direct check still looks better (less complicated). Extracted gym environments version definition logic in tests.Motivation and Context
This simplifies the logic of functions that check for gym versions, improves readability and makes it easier to adapt for bc-braking changes in gym. Proposed by @vmoens.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!