[BugFix] Use GitHub for flake8 pre-commit hook #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vmoens
added
bug
vmoens
added a commit
that referenced
this pull request
Nov 16, 2022
* amend * amend * bugfix * init * strict=False * strict=False * minor * amend * [BugFix] Use GitHub for flake8 pre-commit hook (#679) * amend * [BugFix] Update to strict select (#675) * init * strict=False * amend * amend * [Feature] Auto-compute stats for ObservationNorm (#669) * Add auto-compute stats feature for ObservationNorm * Fix issue in ObservNorm init function * Quick refactor of ObservationNorm init method * Minor refactoring and adding more tests for ObservationNorm * lint * docstring * docstring Co-authored-by: vmoens <vincentmoens@gmail.com> * amend * amend * lint * bf * bf * amend Co-authored-by: Romain Julien <romainjulien@fb.com>
vmoens
added a commit
that referenced
this pull request
Nov 16, 2022
* init * [Feature] Nested composite spec (#654) * [Feature] Move `transform.forward` to `transform.step` (#660) * transform step function * amend * amend * amend * amend * amend * fixing key names * fixing key names * [Refactor] Transform next remove (#661) * Refactor "next_" into ("next", ) (#673) * amend * amend * bugfix * init * strict=False * strict=False * minor * amend * [BugFix] Use GitHub for flake8 pre-commit hook (#679) * amend * [BugFix] Update to strict select (#675) * init * strict=False * amend * amend * [Feature] Auto-compute stats for ObservationNorm (#669) * Add auto-compute stats feature for ObservationNorm * Fix issue in ObservNorm init function * Quick refactor of ObservationNorm init method * Minor refactoring and adding more tests for ObservationNorm * lint * docstring * docstring Co-authored-by: vmoens <vincentmoens@gmail.com> * amend * amend * lint * bf * bf * amend Co-authored-by: Romain Julien <romainjulien@fb.com> Co-authored-by: Romain Julien <romainjulien@fb.com>
albertbou92
pushed a commit
to PyTorchRL/rl
that referenced
this pull request
Nov 16, 2022
albertbou92
pushed a commit
to PyTorchRL/rl
that referenced
this pull request
Nov 16, 2022
* init * [Feature] Nested composite spec (pytorch#654) * [Feature] Move `transform.forward` to `transform.step` (pytorch#660) * transform step function * amend * amend * amend * amend * amend * fixing key names * fixing key names * [Refactor] Transform next remove (pytorch#661) * Refactor "next_" into ("next", ) (pytorch#673) * amend * amend * bugfix * init * strict=False * strict=False * minor * amend * [BugFix] Use GitHub for flake8 pre-commit hook (pytorch#679) * amend * [BugFix] Update to strict select (pytorch#675) * init * strict=False * amend * amend * [Feature] Auto-compute stats for ObservationNorm (pytorch#669) * Add auto-compute stats feature for ObservationNorm * Fix issue in ObservNorm init function * Quick refactor of ObservationNorm init method * Minor refactoring and adding more tests for ObservationNorm * lint * docstring * docstring Co-authored-by: vmoens <vincentmoens@gmail.com> * amend * amend * lint * bf * bf * amend Co-authored-by: Romain Julien <romainjulien@fb.com> Co-authored-by: Romain Julien <romainjulien@fb.com>
albertbou92
pushed a commit
to PyTorchRL/rl
that referenced
this pull request
Nov 18, 2022
* init * [Feature] Nested composite spec (pytorch#654) * [Feature] Move `transform.forward` to `transform.step` (pytorch#660) * transform step function * amend * amend * amend * amend * amend * fixing key names * fixing key names * [Refactor] Transform next remove (pytorch#661) * Refactor "next_" into ("next", ) (pytorch#673) * amend * amend * bugfix * init * strict=False * strict=False * minor * amend * [BugFix] Use GitHub for flake8 pre-commit hook (pytorch#679) * amend * [BugFix] Update to strict select (pytorch#675) * init * strict=False * amend * amend * [Feature] Auto-compute stats for ObservationNorm (pytorch#669) * Add auto-compute stats feature for ObservationNorm * Fix issue in ObservNorm init function * Quick refactor of ObservationNorm init method * Minor refactoring and adding more tests for ObservationNorm * lint * docstring * docstring Co-authored-by: vmoens <vincentmoens@gmail.com> * amend * amend * lint * bf * bf * amend Co-authored-by: Romain Julien <romainjulien@fb.com> Co-authored-by: Romain Julien <romainjulien@fb.com>
vmoens
added a commit
that referenced
this pull request
Nov 23, 2022
* a2c * a2c * a2c config * a2c config * fix imports * latest * simplified config * simplified config * Update config.yaml * [BugFix] Use GitHub for flake8 pre-commit hook (#679) * [BugFix] Update to strict select (#675) * init * strict=False * amend * amend * [Feature] Auto-compute stats for ObservationNorm (#669) * Add auto-compute stats feature for ObservationNorm * Fix issue in ObservNorm init function * Quick refactor of ObservationNorm init method * Minor refactoring and adding more tests for ObservationNorm * lint * docstring * docstring Co-authored-by: vmoens <vincentmoens@gmail.com> * [Doc] _make_collector helper function (#678) * [Doc] BatchSubSampler class docstrings example (#677) * [BugFix] PPO objective crashes if advantage_module is None (#676) * Minor: lint * [Refactor] Refactor 'next_' into nested tensordicts (#649) * init * [Feature] Nested composite spec (#654) * [Feature] Move `transform.forward` to `transform.step` (#660) * transform step function * amend * amend * amend * amend * amend * fixing key names * fixing key names * [Refactor] Transform next remove (#661) * Refactor "next_" into ("next", ) (#673) * amend * amend * bugfix * init * strict=False * strict=False * minor * amend * [BugFix] Use GitHub for flake8 pre-commit hook (#679) * amend * [BugFix] Update to strict select (#675) * init * strict=False * amend * amend * [Feature] Auto-compute stats for ObservationNorm (#669) * Add auto-compute stats feature for ObservationNorm * Fix issue in ObservNorm init function * Quick refactor of ObservationNorm init method * Minor refactoring and adding more tests for ObservationNorm * lint * docstring * docstring Co-authored-by: vmoens <vincentmoens@gmail.com> * amend * amend * lint * bf * bf * amend Co-authored-by: Romain Julien <romainjulien@fb.com> Co-authored-by: Romain Julien <romainjulien@fb.com> * adapted to nested next td * [Refactor] Refactor 'next_' into nested tensordicts (#649) * init * [Feature] Nested composite spec (#654) * [Feature] Move `transform.forward` to `transform.step` (#660) * transform step function * amend * amend * amend * amend * amend * fixing key names * fixing key names * [Refactor] Transform next remove (#661) * Refactor "next_" into ("next", ) (#673) * amend * amend * bugfix * init * strict=False * strict=False * minor * amend * [BugFix] Use GitHub for flake8 pre-commit hook (#679) * amend * [BugFix] Update to strict select (#675) * init * strict=False * amend * amend * [Feature] Auto-compute stats for ObservationNorm (#669) * Add auto-compute stats feature for ObservationNorm * Fix issue in ObservNorm init function * Quick refactor of ObservationNorm init method * Minor refactoring and adding more tests for ObservationNorm * lint * docstring * docstring Co-authored-by: vmoens <vincentmoens@gmail.com> * amend * amend * lint * bf * bf * amend Co-authored-by: Romain Julien <romainjulien@fb.com> Co-authored-by: Romain Julien <romainjulien@fb.com> * [Doc] More doc about environments (#683) * amend * amend * amend * amend * amend * amend * [Doc] Fix missing tensordict install for doc (#685) * model config fix * formatting * formatting * a2c runtime error comment change * a2c test * a2c test * a2c test * make a2c model test * increase a2c tests coverage * formatting * fix bug a2c testing * minor fixes Co-authored-by: Vincent Moens <vincentmoens@gmail.com> Co-authored-by: Romain Julien <romainjulien@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The lint pipeline on CircleCI appears to be failing for all commits at the moment.
This PR changes the repo to GitHub per the flake8 docs.