Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Relying on the standalone tensordict -- phase 1 #650

Merged
merged 15 commits into from
Nov 11, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 7, 2022

Description

Phase 1 of TensorDict deprecation in favour of standalone TensorDict

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2022
# Conflicts:
#	torchrl/collectors/collectors.py
#	torchrl/data/tensor_specs.py
#	torchrl/data/tensordict/__init__.py
#	torchrl/data/tensordict/memmap.py
#	torchrl/data/tensordict/tensordict.py
#	torchrl/envs/transforms/r3m.py
#	torchrl/modules/tensordict_module/exploration.py
tcbegley and others added 4 commits November 11, 2022 16:03
)

* Install tensordict in GitHub Actions

* Clean up remaining references to torchrl.data.tensordict

* Use in td.keys() for membership checks

* Rerun CI

* Rerun CI
# Conflicts:
#	torchrl/envs/transforms/vip.py
…ensordict

# Conflicts:
#	torchrl/data/__init__.py
#	torchrl/modules/tensordict_module/exploration.py
@vmoens vmoens added the enhancement New feature or request label Nov 11, 2022
@vmoens vmoens merged commit d28a8c3 into main Nov 11, 2022
@vmoens vmoens deleted the import_tensordict branch November 11, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants