[Feature] Exclude "_" out_keys in tensordictmodel
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vmoens
changed the title
"_" out_keys in tensordictmodel
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 86.96% 86.98% +0.01%
==========================================
Files 120 120
Lines 21812 21844 +32
==========================================
+ Hits 18968 19000 +32
Misses 2844 2844
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vmoens
reviewed
Oct 19, 2022
| @@ -104,7 +104,7 @@ def _inverse(self, y: torch.Tensor) -> torch.Tensor: | |||
|
|
|||
|
|
|||
| class NormalParamWrapper(nn.Module): | |||
| """A wrapper for normal distirbution parameters. | |||
| """A wrapper for normal distribution parameters. | |||
|
@vmoens I added the two tests as suggested 👍 |
vmoens
reviewed
Oct 19, 2022
test/test_tensordictmodules.py
Outdated
| } | ||
|
|
||
| # warning due to "_" in spec keys | ||
| with pytest.warns(): |
There was a problem hiding this comment.
can we check the warning message too (just to make sure we capture the right warning)
test/test_tensordictmodules.py
Outdated
| @@ -773,6 +836,16 @@ def test_vmap_probabilistic_laterconstruct(self, safe, spec_type): | |||
|
|
|||
|
|
|||
| class TestTDSequence: | |||
| def test_in_key_warning(self): | |||
| with pytest.warns(): | |||
test/test_tensordictmodules.py
Outdated
| tensordict_module = TensorDictModule( | ||
| nn.Linear(3, 4), in_keys=["_"], out_keys=["out1"] | ||
| ) | ||
| with pytest.warns(): |
added 2 commits
October 20, 2022 09:05
…suffleur/rl into exclude_keys_tensordictmodel
vmoens
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the possibility to avoid writing some tensors in the output tensordict in
TensorDictModuleby setting the output key to"_".Motivation and Context
New feature, closes #564
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!