Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Checkpointing #549

Merged
merged 78 commits into from
Oct 28, 2022
Merged

[Feature] Checkpointing #549

merged 78 commits into from
Oct 28, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Oct 11, 2022 •
edited
Loading

Description

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022 •
edited
Loading

Codecov Report

Merging #549 (7d7fa76) into main (6f9faaa) will increase coverage by 0.13%.
The diff coverage is 98.90%.

❗ Current head 7d7fa76 differs from pull request most recent head 9ba0873. Consider uploading reports for the commit 9ba0873 to get more accurate results

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   87.45%   87.59%   +0.13%     
==========================================
  Files         124      124              
  Lines       22850    23046     +196     
==========================================
+ Hits        19984    20186     +202     
+ Misses       2866     2860       -6
Flag Coverage Δ
linux-cpu 86.01% <98.90%> (+0.14%) ⬆️
linux-gpu 87.38% <98.90%> (+0.13%) ⬆️
linux-outdeps-gpu 76.52% <98.90%> (+0.23%) ⬆️
linux-stable-cpu 85.99% <98.90%> (+0.14%) ⬆️
linux-stable-gpu 87.38% <98.90%> (+0.13%) ⬆️
macos-cpu 85.78% <98.90%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchrl/data/replay_buffers/storages.py 90.29% <87.50%> (-0.46%) ⬇️
test/test_trainer.py 98.25% <99.39%> (+0.36%) ⬆️
torchrl/data/replay_buffers/replay_buffers.py 74.01% <100.00%> (+2.04%) ⬆️
torchrl/data/tensordict/memmap.py 86.12% <100.00%> (+0.35%) ⬆️
torchrl/trainers/trainers.py 72.60% <100.00%> (+5.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vmoens vmoens added the enhancement New feature or request label Oct 11, 2022
vmoens added 28 commits October 24, 2022 14:20
@vmoens
amend
b2812ff
@vmoens
amend
0b0d6d7
@vmoens
amend
9acefdc
@vmoens
amend
8bee40a
@vmoens
amend
ffd8d41
@vmoens
amend
ee066b7
@vmoens
amend
e4b0e3e
@vmoens
amend
a65c78a
@vmoens
amend
205e035
@vmoens
amend
3fd44b3
@vmoens
amend
3c916be
@vmoens
amend
9127f1c
@vmoens
amend
bd23d2c
@vmoens
amend
1e82714
@vmoens
--force-reinstall
49ec01b
@vmoens
amend
2930abc
@vmoens
amend
ccd41a0
@vmoens
removing habitat baselines
3fa1440
@vmoens
Merge branch 'main' into checkpointing
238403f
@vmoens
amend
b5d295d
@vmoens
VP suggestions
fbdf18f
@vmoens
Merge remote-tracking branch 'origin/main' into checkpointing
7d7fa76
@vmoens
Checkpointing -- TorchSnapshot (#577)
9ba0873 
* init

* amend

* temp

* amend

* amend

* bf

* fix tests

* lock bugfix

* install snapshot branch

* amend

* amend

* amend

* amend

* amend

* amend

* bf

* coverage xml -i
@vmoens
Merge branch 'main' into habitat
b906b89 
# Conflicts:
#	test/_utils_internal.py
#	torchrl/envs/libs/gym.py
@vmoens
amend
704ad06
@vmoens
amend
92fed9a
@vmoens
Merge branch 'habitat' into checkpointing
1a5d6c3
@vmoens
Merge branch 'main' into checkpointing
0ef22d0
@vmoens vmoens merged commit 86380c8 into main Oct 28, 2022
@vmoens vmoens deleted the checkpointing branch October 28, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot