Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Minor bugfixes in TensorDictSequential #501

Merged
merged 1 commit into from
Sep 30, 2022
Merged

[BugFix] Minor bugfixes in TensorDictSequential #501

merged 1 commit into from
Sep 30, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 30, 2022

Description

Solves minor bugs in TensorDictSequential

  • Compatibility with modules that don't inherit from TenssorDictModule
  • Indexing with lists and slices

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2022
@vmoens vmoens added bug Something isn't working and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 30, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2022
@vmoens vmoens merged commit 6ce4a74 into main Sep 30, 2022
vmoens added a commit that referenced this pull request Oct 1, 2022
@vmoens
[BugFix] Minor bugfixes in TensorDictSequential (#501)
73028e4
@vmoens vmoens mentioned this pull request Oct 2, 2022
Merged
@vmoens vmoens deleted the minor_bugfix branch December 14, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot