Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Looser check for test_recorder assertion #415

Merged
merged 1 commit into from
Sep 11, 2022
Merged

[BugFix] Looser check for test_recorder assertion #415

merged 1 commit into from
Sep 11, 2022

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Sep 11, 2022 •
edited
Loading

Description

Fixes the CI flacky test in test_trainer.py:test_recorder by allowing few attempts for the video length check with a slight delay if needed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2022
@vmoens vmoens added bug Something isn't working Tests Incomplete or broken unit tests CI Has to do with CI setup (e.g. wheels & builds, tests...) labels Sep 11, 2022
@vmoens vmoens merged commit 71a9100 into main Sep 11, 2022
@vmoens vmoens deleted the loose_rec_check branch September 11, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CI Has to do with CI setup (e.g. wheels & builds, tests...) CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot