Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Refactored logging to be able to support other loggers easily #270

Merged
merged 12 commits into from
Jul 15, 2022

Conversation

nicolas-dufour
Copy link
Contributor

Description

In this PR we replace the tensorboards writers by a more generic Logger.

Motivation and Context

This change is required to be able to support other loggers such as WandB in the future.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Implemented Tasks

  • Refactors writters to be replace by loggers

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [x ] I have read the CONTRIBUTION guide (required)
  • [ x] My change requires a change to the documentation.
  • [ x] I have updated the tests accordingly (required for a bug fix or a new feature).
  • [ x] I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2022
@vmoens vmoens added the enhancement New feature or request label Jul 13, 2022
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're on the right track, thanks for this!

have a look at my comments

torchrl/trainers/loggers.py Show resolved Hide resolved
torchrl/trainers/loggers.py Show resolved Hide resolved
torchrl/trainers/loggers.py Outdated Show resolved Hide resolved
torchrl/trainers/loggers.py Show resolved Hide resolved
torchrl/trainers/loggers.py Outdated Show resolved Hide resolved
torchrl/trainers/loggers.py Outdated Show resolved Hide resolved
torchrl/trainers/loggers.py Outdated Show resolved Hide resolved
torchrl/trainers/loggers.py Outdated Show resolved Hide resolved
torchrl/trainers/loggers.py Outdated Show resolved Hide resolved
torchrl/trainers/loggers.py Outdated Show resolved Hide resolved
@nicolas-dufour nicolas-dufour changed the title [Feature]: Refactored loggin to be able to support other loggers easily [Feature]: Refactored logging to be able to support other loggers easily Jul 13, 2022
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens merged commit 806733f into pytorch:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants