Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] EnvBase.auto_specs_ #2601

Merged
merged 6 commits into from
Nov 25, 2024
Merged

[Feature] EnvBase.auto_specs_ #2601

merged 6 commits into from
Nov 25, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 23, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Proposes a method to automatically set the specs of an env given the following heuristic:

  • Run two steps in the env
  • If the shape of a tensor differs in these two steps, then consider it to be dynamic (-1) (we could parametrize this and ask for any number of steps above 1, with default being 2, to increase the chances of capturing dynamic specs)
  • split action / obs / rewards / done / states given some predefined names (can be customized)

cc @matteobettini

@vmoens
Update
655115d 
[ghstack-poisoned]
This was referenced Nov 23, 2024
Merged
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 23, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2601

Note: Links to docs will display an error until the docs builds have been completed.

❌ 30 New Failures

As of commit a89eff9 with merge base c8676f4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Nov 23, 2024
Merged
Merged
Merged
vmoens added a commit that referenced this pull request Nov 23, 2024
@vmoens
[Feature] EnvBase.auto_specs_
f535f25 
ghstack-source-id: 946ea5ad621a49283a801bc51887c76e666844a3
Pull Request resolved: #2601
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2024
@vmoens
Update
5c66da0 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 24, 2024
@vmoens
[Feature] EnvBase.auto_specs_
5661cea 
ghstack-source-id: b3934e5ed7399c286cfd93e5deeaff240aaecccb
Pull Request resolved: #2601
@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Nov 24, 2024
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}14$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.7207s 0.7200s 1.3890 Ops/s 1.4016 Ops/s $\color{#d91a1a}-0.90\%$
test_transformed 0.9641s 0.9605s 1.0412 Ops/s 1.0497 Ops/s $\color{#d91a1a}-0.81\%$
test_serial 2.0805s 2.0652s 0.4842 Ops/s 0.4915 Ops/s $\color{#d91a1a}-1.49\%$
test_parallel 2.0633s 1.9626s 0.5095 Ops/s 0.5164 Ops/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[True-True-True-True-True] 0.1734ms 34.9739μs 28.5927 KOps/s 28.4735 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[True-True-True-True-False] 46.0810μs 20.0023μs 49.9944 KOps/s 49.6715 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[True-True-True-False-True] 63.0310μs 19.1919μs 52.1052 KOps/s 52.1583 KOps/s $\color{#d91a1a}-0.10\%$
test_step_mdp_speed[True-True-True-False-False] 41.9110μs 11.1505μs 89.6819 KOps/s 90.7179 KOps/s $\color{#d91a1a}-1.14\%$
test_step_mdp_speed[True-True-False-True-True] 65.0220μs 36.8691μs 27.1230 KOps/s 27.4450 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[True-True-False-True-False] 59.0110μs 21.8895μs 45.6840 KOps/s 46.2622 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[True-True-False-False-True] 55.4510μs 21.8108μs 45.8489 KOps/s 46.8160 KOps/s $\color{#d91a1a}-2.07\%$
test_step_mdp_speed[True-True-False-False-False] 45.4510μs 13.0649μs 76.5412 KOps/s 75.2637 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[True-False-True-True-True] 75.3810μs 39.0683μs 25.5962 KOps/s 25.7430 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-False-True-True-False] 49.2210μs 23.6070μs 42.3603 KOps/s 41.4166 KOps/s $\color{#35bf28}+2.28\%$
test_step_mdp_speed[True-False-True-False-True] 48.2110μs 20.8730μs 47.9088 KOps/s 46.5832 KOps/s $\color{#35bf28}+2.85\%$
test_step_mdp_speed[True-False-True-False-False] 39.1700μs 13.1363μs 76.1247 KOps/s 74.5662 KOps/s $\color{#35bf28}+2.09\%$
test_step_mdp_speed[True-False-False-True-True] 67.7110μs 40.9469μs 24.4219 KOps/s 24.3896 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[True-False-False-True-False] 49.8910μs 25.6270μs 39.0214 KOps/s 38.6255 KOps/s $\color{#35bf28}+1.02\%$
test_step_mdp_speed[True-False-False-False-True] 47.7610μs 23.2874μs 42.9416 KOps/s 42.9086 KOps/s $\color{#35bf28}+0.08\%$
test_step_mdp_speed[True-False-False-False-False] 40.5510μs 14.8052μs 67.5439 KOps/s 66.0193 KOps/s $\color{#35bf28}+2.31\%$
test_step_mdp_speed[False-True-True-True-True] 72.6510μs 38.8422μs 25.7452 KOps/s 25.5362 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[False-True-True-True-False] 48.3910μs 23.7400μs 42.1229 KOps/s 41.4340 KOps/s $\color{#35bf28}+1.66\%$
test_step_mdp_speed[False-True-True-False-True] 55.5810μs 24.9095μs 40.1453 KOps/s 40.0575 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[False-True-True-False-False] 39.3110μs 14.4727μs 69.0957 KOps/s 66.7280 KOps/s $\color{#35bf28}+3.55\%$
test_step_mdp_speed[False-True-False-True-True] 82.4320μs 40.7258μs 24.5545 KOps/s 24.3906 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[False-True-False-True-False] 52.6710μs 25.5334μs 39.1643 KOps/s 38.0049 KOps/s $\color{#35bf28}+3.05\%$
test_step_mdp_speed[False-True-False-False-True] 3.5916ms 27.3081μs 36.6191 KOps/s 36.6765 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[False-True-False-False-False] 47.9610μs 16.7062μs 59.8580 KOps/s 59.5350 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[False-False-True-True-True] 68.4210μs 42.7462μs 23.3939 KOps/s 22.8554 KOps/s $\color{#35bf28}+2.36\%$
test_step_mdp_speed[False-False-True-True-False] 56.9510μs 27.7828μs 35.9935 KOps/s 36.0609 KOps/s $\color{#d91a1a}-0.19\%$
test_step_mdp_speed[False-False-True-False-True] 51.5610μs 26.8780μs 37.2052 KOps/s 37.3463 KOps/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[False-False-True-False-False] 42.4310μs 16.6010μs 60.2372 KOps/s 59.6963 KOps/s $\color{#35bf28}+0.91\%$
test_step_mdp_speed[False-False-False-True-True] 75.8320μs 44.6337μs 22.4046 KOps/s 22.8144 KOps/s $\color{#d91a1a}-1.80\%$
test_step_mdp_speed[False-False-False-True-False] 79.2620μs 29.5968μs 33.7874 KOps/s 34.6648 KOps/s $\color{#d91a1a}-2.53\%$
test_step_mdp_speed[False-False-False-False-True] 66.2020μs 28.3947μs 35.2179 KOps/s 35.4044 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[False-False-False-False-False] 54.6320μs 18.2955μs 54.6583 KOps/s 54.6675 KOps/s $\color{#d91a1a}-0.02\%$
test_values[generalized_advantage_estimate-True-True] 24.3546ms 23.9279ms 41.7921 Ops/s 42.0271 Ops/s $\color{#d91a1a}-0.56\%$
test_values[vec_generalized_advantage_estimate-True-True] 0.1027s 2.9335ms 340.8907 Ops/s 360.6837 Ops/s $\textbf{\color{#d91a1a}-5.49\%}$
test_values[td0_return_estimate-False-False] 0.1011ms 75.8180μs 13.1895 KOps/s 13.2071 KOps/s $\color{#d91a1a}-0.13\%$
test_values[td1_return_estimate-False-False] 53.6560ms 53.1962ms 18.7983 Ops/s 18.9380 Ops/s $\color{#d91a1a}-0.74\%$
test_values[vec_td1_return_estimate-False-False] 1.2597ms 1.0575ms 945.5988 Ops/s 945.5101 Ops/s $+0.01\%$
test_values[td_lambda_return_estimate-True-False] 84.0176ms 83.7159ms 11.9452 Ops/s 11.9453 Ops/s $-0.00\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.2058ms 1.0519ms 950.6274 Ops/s 952.0870 Ops/s $\color{#d91a1a}-0.15\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.0559ms 23.8399ms 41.9465 Ops/s 42.6620 Ops/s $\color{#d91a1a}-1.68\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9998ms 0.7225ms 1.3840 KOps/s 1.3883 KOps/s $\color{#d91a1a}-0.31\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7370ms 0.6425ms 1.5565 KOps/s 1.5533 KOps/s $\color{#35bf28}+0.21\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5384ms 1.4519ms 688.7341 Ops/s 689.2920 Ops/s $\color{#d91a1a}-0.08\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.6935ms 0.6586ms 1.5183 KOps/s 1.5162 KOps/s $\color{#35bf28}+0.14\%$
test_dqn_speed[False-None] 7.4751ms 1.3856ms 721.7161 Ops/s 732.6100 Ops/s $\color{#d91a1a}-1.49\%$
test_dqn_speed[False-backward] 2.0542ms 1.9583ms 510.6352 Ops/s 507.7975 Ops/s $\color{#35bf28}+0.56\%$
test_dqn_speed[True-None] 0.9775ms 0.5231ms 1.9117 KOps/s 1.8791 KOps/s $\color{#35bf28}+1.74\%$
test_dqn_speed[True-backward] 1.1286ms 1.0572ms 945.8979 Ops/s 936.4609 Ops/s $\color{#35bf28}+1.01\%$
test_dqn_speed[reduce-overhead-None] 0.6434ms 0.5296ms 1.8883 KOps/s 1.8086 KOps/s $\color{#35bf28}+4.41\%$
test_dqn_speed[reduce-overhead-backward] 0.9824ms 0.9298ms 1.0755 KOps/s 1.0806 KOps/s $\color{#d91a1a}-0.47\%$
test_ddpg_speed[False-None] 3.0179ms 2.6016ms 384.3756 Ops/s 384.6765 Ops/s $\color{#d91a1a}-0.08\%$
test_ddpg_speed[False-backward] 4.2405ms 3.7336ms 267.8412 Ops/s 265.8087 Ops/s $\color{#35bf28}+0.76\%$
test_ddpg_speed[True-None] 1.5181ms 1.0390ms 962.4789 Ops/s 961.5847 Ops/s $\color{#35bf28}+0.09\%$
test_ddpg_speed[True-backward] 2.1092ms 2.0759ms 481.7230 Ops/s 451.7574 Ops/s $\textbf{\color{#35bf28}+6.63\%}$
test_ddpg_speed[reduce-overhead-None] 1.2195ms 1.0578ms 945.3517 Ops/s 944.9119 Ops/s $\color{#35bf28}+0.05\%$
test_ddpg_speed[reduce-overhead-backward] 1.7653ms 1.6841ms 593.7888 Ops/s 628.7473 Ops/s $\textbf{\color{#d91a1a}-5.56\%}$
test_sac_speed[False-None] 7.9486ms 7.4159ms 134.8452 Ops/s 134.3691 Ops/s $\color{#35bf28}+0.35\%$
test_sac_speed[False-backward] 10.6041ms 10.2820ms 97.2571 Ops/s 97.8391 Ops/s $\color{#d91a1a}-0.59\%$
test_sac_speed[True-None] 1.8792ms 1.5130ms 660.9311 Ops/s 637.9121 Ops/s $\color{#35bf28}+3.61\%$
test_sac_speed[True-backward] 3.3922ms 3.3057ms 302.5071 Ops/s 305.0317 Ops/s $\color{#d91a1a}-0.83\%$
test_sac_speed[reduce-overhead-None] 23.1489ms 12.4106ms 80.5766 Ops/s 79.8022 Ops/s $\color{#35bf28}+0.97\%$
test_sac_speed[reduce-overhead-backward] 1.3258ms 1.2728ms 785.6778 Ops/s 696.1808 Ops/s $\textbf{\color{#35bf28}+12.86\%}$
test_redq_speed[False-None] 7.7873ms 7.0194ms 142.4622 Ops/s 141.1062 Ops/s $\color{#35bf28}+0.96\%$
test_redq_speed[False-backward] 11.5535ms 10.5455ms 94.8268 Ops/s 90.3918 Ops/s $\color{#35bf28}+4.91\%$
test_redq_speed[True-None] 2.0108ms 1.9013ms 525.9576 Ops/s 522.7361 Ops/s $\color{#35bf28}+0.62\%$
test_redq_speed[True-backward] 3.5671ms 3.4708ms 288.1193 Ops/s 271.1656 Ops/s $\textbf{\color{#35bf28}+6.25\%}$
test_redq_speed[reduce-overhead-None] 2.0350ms 1.9232ms 519.9713 Ops/s 521.5125 Ops/s $\color{#d91a1a}-0.30\%$
test_redq_speed[reduce-overhead-backward] 3.5914ms 3.4699ms 288.1944 Ops/s 284.2573 Ops/s $\color{#35bf28}+1.39\%$
test_redq_deprec_speed[False-None] 8.9767ms 8.3597ms 119.6209 Ops/s 119.7552 Ops/s $\color{#d91a1a}-0.11\%$
test_redq_deprec_speed[False-backward] 11.6757ms 11.1406ms 89.7622 Ops/s 89.6389 Ops/s $\color{#35bf28}+0.14\%$
test_redq_deprec_speed[True-None] 2.3826ms 2.2135ms 451.7697 Ops/s 442.3737 Ops/s $\color{#35bf28}+2.12\%$
test_redq_deprec_speed[True-backward] 4.3136ms 3.8114ms 262.3692 Ops/s 262.8190 Ops/s $\color{#d91a1a}-0.17\%$
test_redq_deprec_speed[reduce-overhead-None] 2.3362ms 2.2150ms 451.4755 Ops/s 449.7415 Ops/s $\color{#35bf28}+0.39\%$
test_redq_deprec_speed[reduce-overhead-backward] 4.2214ms 3.8059ms 262.7476 Ops/s 251.6301 Ops/s $\color{#35bf28}+4.42\%$
test_td3_speed[False-None] 7.4858ms 7.2412ms 138.0983 Ops/s 137.6306 Ops/s $\color{#35bf28}+0.34\%$
test_td3_speed[False-backward] 10.1282ms 9.4497ms 105.8236 Ops/s 102.9538 Ops/s $\color{#35bf28}+2.79\%$
test_td3_speed[True-None] 1.5976ms 1.5154ms 659.8702 Ops/s 664.7363 Ops/s $\color{#d91a1a}-0.73\%$
test_td3_speed[True-backward] 3.1407ms 3.0144ms 331.7406 Ops/s 331.1420 Ops/s $\color{#35bf28}+0.18\%$
test_td3_speed[reduce-overhead-None] 48.7453ms 24.9495ms 40.0809 Ops/s 38.8737 Ops/s $\color{#35bf28}+3.11\%$
test_td3_speed[reduce-overhead-backward] 1.2926ms 1.2358ms 809.1845 Ops/s 804.8465 Ops/s $\color{#35bf28}+0.54\%$
test_cql_speed[False-None] 15.3492ms 14.9411ms 66.9293 Ops/s 66.0654 Ops/s $\color{#35bf28}+1.31\%$
test_cql_speed[False-backward] 20.4622ms 19.8290ms 50.4313 Ops/s 49.9923 Ops/s $\color{#35bf28}+0.88\%$
test_cql_speed[True-None] 3.0421ms 2.8502ms 350.8509 Ops/s 340.6338 Ops/s $\color{#35bf28}+3.00\%$
test_cql_speed[True-backward] 5.1633ms 4.8498ms 206.1944 Ops/s 206.0605 Ops/s $\color{#35bf28}+0.07\%$
test_cql_speed[reduce-overhead-None] 21.5682ms 13.0293ms 76.7500 Ops/s 77.5189 Ops/s $\color{#d91a1a}-0.99\%$
test_cql_speed[reduce-overhead-backward] 1.4828ms 1.4123ms 708.0504 Ops/s 707.5220 Ops/s $\color{#35bf28}+0.07\%$
test_a2c_speed[False-None] 3.0697ms 2.9703ms 336.6629 Ops/s 335.9304 Ops/s $\color{#35bf28}+0.22\%$
test_a2c_speed[False-backward] 6.2487ms 5.7034ms 175.3352 Ops/s 173.5847 Ops/s $\color{#35bf28}+1.01\%$
test_a2c_speed[True-None] 1.0944ms 0.9786ms 1.0219 KOps/s 1.0365 KOps/s $\color{#d91a1a}-1.41\%$
test_a2c_speed[True-backward] 2.6390ms 2.5254ms 395.9737 Ops/s 399.4108 Ops/s $\color{#d91a1a}-0.86\%$
test_a2c_speed[reduce-overhead-None] 0.3834s 12.2763ms 81.4581 Ops/s 86.9894 Ops/s $\textbf{\color{#d91a1a}-6.36\%}$
test_a2c_speed[reduce-overhead-backward] 1.0124ms 0.9569ms 1.0450 KOps/s 1.0680 KOps/s $\color{#d91a1a}-2.15\%$
test_ppo_speed[False-None] 3.5103ms 3.4128ms 293.0140 Ops/s 294.1154 Ops/s $\color{#d91a1a}-0.37\%$
test_ppo_speed[False-backward] 6.7948ms 6.3744ms 156.8763 Ops/s 155.8523 Ops/s $\color{#35bf28}+0.66\%$
test_ppo_speed[True-None] 1.0468ms 0.9027ms 1.1078 KOps/s 1.0954 KOps/s $\color{#35bf28}+1.13\%$
test_ppo_speed[True-backward] 2.5850ms 2.4984ms 400.2564 Ops/s 406.7873 Ops/s $\color{#d91a1a}-1.61\%$
test_ppo_speed[reduce-overhead-None] 0.5838ms 0.4742ms 2.1089 KOps/s 1.9894 KOps/s $\textbf{\color{#35bf28}+6.01\%}$
test_ppo_speed[reduce-overhead-backward] 0.9922ms 0.9287ms 1.0768 KOps/s 1.0512 KOps/s $\color{#35bf28}+2.43\%$
test_reinforce_speed[False-None] 2.2312ms 2.1167ms 472.4435 Ops/s 481.7760 Ops/s $\color{#d91a1a}-1.94\%$
test_reinforce_speed[False-backward] 3.4990ms 3.0111ms 332.1061 Ops/s 328.7133 Ops/s $\color{#35bf28}+1.03\%$
test_reinforce_speed[True-None] 0.8819ms 0.7962ms 1.2560 KOps/s 1.2509 KOps/s $\color{#35bf28}+0.41\%$
test_reinforce_speed[True-backward] 2.4238ms 2.3432ms 426.7745 Ops/s 426.0508 Ops/s $\color{#35bf28}+0.17\%$
test_reinforce_speed[reduce-overhead-None] 22.4731ms 11.8495ms 84.3917 Ops/s 87.3722 Ops/s $\color{#d91a1a}-3.41\%$
test_reinforce_speed[reduce-overhead-backward] 1.1097ms 1.0274ms 973.3522 Ops/s 986.8276 Ops/s $\color{#d91a1a}-1.37\%$
test_iql_speed[False-None] 9.3362ms 8.6457ms 115.6651 Ops/s 117.7508 Ops/s $\color{#d91a1a}-1.77\%$
test_iql_speed[False-backward] 12.4268ms 11.9850ms 83.4376 Ops/s 83.6342 Ops/s $\color{#d91a1a}-0.24\%$
test_iql_speed[True-None] 1.8859ms 1.7055ms 586.3538 Ops/s 597.8053 Ops/s $\color{#d91a1a}-1.92\%$
test_iql_speed[True-backward] 4.3711ms 4.2337ms 236.1991 Ops/s 246.0504 Ops/s $\color{#d91a1a}-4.00\%$
test_iql_speed[reduce-overhead-None] 20.1048ms 11.4296ms 87.4920 Ops/s 88.6485 Ops/s $\color{#d91a1a}-1.30\%$
test_iql_speed[reduce-overhead-backward] 1.5715ms 1.5340ms 651.8831 Ops/s 658.2726 Ops/s $\color{#d91a1a}-0.97\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.5985ms 6.0617ms 164.9711 Ops/s 162.6377 Ops/s $\color{#35bf28}+1.43\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.4740ms 0.2610ms 3.8313 KOps/s 3.8671 KOps/s $\color{#d91a1a}-0.93\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4943ms 0.2981ms 3.3540 KOps/s 4.1507 KOps/s $\textbf{\color{#d91a1a}-19.19\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.2277ms 5.8625ms 170.5771 Ops/s 171.0867 Ops/s $\color{#d91a1a}-0.30\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9689ms 0.3152ms 3.1728 KOps/s 2.9477 KOps/s $\textbf{\color{#35bf28}+7.64\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4391ms 0.2690ms 3.7170 KOps/s 3.2215 KOps/s $\textbf{\color{#35bf28}+15.38\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4234ms 1.2278ms 814.4747 Ops/s 743.8346 Ops/s $\textbf{\color{#35bf28}+9.50\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4289ms 1.1719ms 853.3264 Ops/s 791.8642 Ops/s $\textbf{\color{#35bf28}+7.76\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.1174ms 6.0063ms 166.4929 Ops/s 164.9362 Ops/s $\color{#35bf28}+0.94\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8122ms 0.3854ms 2.5946 KOps/s 2.1873 KOps/s $\textbf{\color{#35bf28}+18.62\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6231ms 0.3720ms 2.6882 KOps/s 2.2561 KOps/s $\textbf{\color{#35bf28}+19.16\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.0806ms 5.9256ms 168.7591 Ops/s 169.2336 Ops/s $\color{#d91a1a}-0.28\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.5252ms 0.2884ms 3.4679 KOps/s 3.7718 KOps/s $\textbf{\color{#d91a1a}-8.06\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5025ms 0.2981ms 3.3544 KOps/s 3.2212 KOps/s $\color{#35bf28}+4.13\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1104ms 5.8399ms 171.2361 Ops/s 171.7323 Ops/s $\color{#d91a1a}-0.29\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3687ms 0.2942ms 3.3986 KOps/s 3.3519 KOps/s $\color{#35bf28}+1.39\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5823ms 0.2845ms 3.5147 KOps/s 3.3134 KOps/s $\textbf{\color{#35bf28}+6.08\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.1527ms 6.0318ms 165.7889 Ops/s 166.9664 Ops/s $\color{#d91a1a}-0.71\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9584ms 0.4260ms 2.3476 KOps/s 2.2798 KOps/s $\color{#35bf28}+2.97\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.5874ms 0.4052ms 2.4679 KOps/s 2.2018 KOps/s $\textbf{\color{#35bf28}+12.09\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.7427ms 5.2412ms 190.7963 Ops/s 190.8033 Ops/s $-0.00\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 9.5735ms 2.0185ms 495.4096 Ops/s 531.8099 Ops/s $\textbf{\color{#d91a1a}-6.84\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.9895ms 1.1086ms 902.0754 Ops/s 903.1956 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.4774s 14.7008ms 68.0237 Ops/s 191.7559 Ops/s $\textbf{\color{#d91a1a}-64.53\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 6.7721ms 1.9901ms 502.4880 Ops/s 444.4480 Ops/s $\textbf{\color{#35bf28}+13.06\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.9568ms 1.2341ms 810.3265 Ops/s 869.7764 Ops/s $\textbf{\color{#d91a1a}-6.84\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 8.3388ms 5.5073ms 181.5759 Ops/s 33.3454 Ops/s $\textbf{\color{#35bf28}+444.53\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 8.1055ms 2.1299ms 469.5037 Ops/s 459.1548 Ops/s $\color{#35bf28}+2.25\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 8.3880ms 1.3619ms 734.2736 Ops/s 847.1532 Ops/s $\textbf{\color{#d91a1a}-13.32\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 12.6563ms 12.4193ms 80.5198 Ops/s 79.9625 Ops/s $\color{#35bf28}+0.70\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 18.4387ms 16.4864ms 60.6562 Ops/s 62.5214 Ops/s $\color{#d91a1a}-2.98\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 17.7837ms 17.0668ms 58.5932 Ops/s 57.7963 Ops/s $\color{#35bf28}+1.38\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 17.1098ms 16.6045ms 60.2248 Ops/s 62.3175 Ops/s $\color{#d91a1a}-3.36\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 17.1073ms 16.7542ms 59.6867 Ops/s 58.1945 Ops/s $\color{#35bf28}+2.56\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 18.3962ms 17.7698ms 56.2753 Ops/s 57.6999 Ops/s $\color{#d91a1a}-2.47\%$

@vmoens
Update
6e24ab8 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 25, 2024
@vmoens
[Feature] EnvBase.auto_specs_
3288351 
ghstack-source-id: ec65dba978f964edc02dca64fc05b280f0c12f02
Pull Request resolved: #2601
@vmoens
Update
1a4c9f6 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 25, 2024
@vmoens
[Feature] EnvBase.auto_specs_
f572281 
ghstack-source-id: 9cb10eeb50fa5e4108ceaddad83e717316c77cb3
Pull Request resolved: #2601
@vmoens
Update
924e062 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 25, 2024
@vmoens
[Feature] EnvBase.auto_specs_
eecdf69 
ghstack-source-id: 6929216eb1aeaf034a69c9c5c53c3eddb34140aa
Pull Request resolved: #2601
vmoens added a commit that referenced this pull request Nov 25, 2024
@vmoens
[Feature] EnvBase.auto_specs_
9db0ef9 
ghstack-source-id: 6929216eb1aeaf034a69c9c5c53c3eddb34140aa
Pull Request resolved: #2601
@vmoens
Update
a89eff9 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 25, 2024
@vmoens
[Feature] EnvBase.auto_specs_
317788d 
ghstack-source-id: 329679238c5172d7ff13097ceaa189479d4f4145
Pull Request resolved: #2601
@vmoens vmoens merged commit a89eff9 into gh/vmoens/48/base Nov 25, 2024
14 of 30 checks passed
vmoens added a commit that referenced this pull request Nov 25, 2024
@vmoens
[Feature] EnvBase.auto_specs_
d537dcb 
ghstack-source-id: 329679238c5172d7ff13097ceaa189479d4f4145
Pull Request resolved: #2601
@vmoens vmoens deleted the gh/vmoens/48/head branch November 25, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot