Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Deprecate recurrent_mode API to use decorators/CMs instead #2584

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 19, 2024

Stack from ghstack (oldest at bottom):

Also ensures that all public loss functions are using the appropriate exploration mode and recurrent mode.

cc @thomasbbrunner

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2584

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 9 Unrelated Failures

As of commit 89fa139 with merge base 705ecc2 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 0256235faa306edbba6e10544ef043df9b5cc1c8
Pull Request resolved: #2584
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 80f705e022abc111df3960fc09576d5e266ed4dd
Pull Request resolved: #2584
@vmoens vmoens merged commit 89fa139 into gh/vmoens/43/base Nov 20, 2024
62 of 76 checks passed
vmoens added a commit that referenced this pull request Nov 20, 2024
ghstack-source-id: 80f705e022abc111df3960fc09576d5e266ed4dd
Pull Request resolved: #2584
@vmoens vmoens deleted the gh/vmoens/43/head branch November 20, 2024 10:59
@thomasbbrunner
Copy link
Contributor

Oh, that was super fast. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants