Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] Add trailing spaces when necessary #2581

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[BE] Add trailing spaces when necessary #2581

merged 1 commit into from
Nov 18, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 18, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
a541095 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2581

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Pending, 18 Unrelated Failures

As of commit a541095 with merge base 7829bd3 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Nov 18, 2024
@vmoens
[BE] Add trailing spaces when necessary
64668e8 
ghstack-source-id: 198b5b5668cce8336d44206c10dacb8a9b1a9785
Pull Request resolved: #2581
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2024
@vmoens vmoens added quality code quality ciflow/docs tests full docs CI BE Better errors, logs, docs or test utils labels Nov 18, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 18, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@vmoens vmoens merged commit a541095 into gh/vmoens/50/base Nov 18, 2024
47 of 65 checks passed
@vmoens vmoens deleted the gh/vmoens/50/head branch November 18, 2024 16:20
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 149. Improved: $\large\color{#35bf28}22$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.4303s 0.4287s 2.3329 Ops/s 2.2415 Ops/s $\color{#35bf28}+4.08\%$
test_transformed 0.6105s 0.6088s 1.6427 Ops/s 1.6242 Ops/s $\color{#35bf28}+1.14\%$
test_serial 1.3677s 1.3591s 0.7358 Ops/s 0.7384 Ops/s $\color{#d91a1a}-0.36\%$
test_parallel 1.2883s 1.2776s 0.7827 Ops/s 0.7602 Ops/s $\color{#35bf28}+2.97\%$
test_step_mdp_speed[True-True-True-True-True] 0.1875ms 27.4214μs 36.4678 KOps/s 37.1564 KOps/s $\color{#d91a1a}-1.85\%$
test_step_mdp_speed[True-True-True-True-False] 42.7700μs 15.9711μs 62.6133 KOps/s 63.8320 KOps/s $\color{#d91a1a}-1.91\%$
test_step_mdp_speed[True-True-True-False-True] 96.6890μs 15.7979μs 63.2996 KOps/s 64.2896 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[True-True-True-False-False] 47.7990μs 8.9983μs 111.1319 KOps/s 111.3353 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-True-False-True-True] 94.7070μs 29.4974μs 33.9013 KOps/s 34.4664 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-True-False-True-False] 74.3300μs 17.4624μs 57.2660 KOps/s 56.7037 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[True-True-False-False-True] 74.5780μs 17.2931μs 57.8264 KOps/s 58.6221 KOps/s $\color{#d91a1a}-1.36\%$
test_step_mdp_speed[True-True-False-False-False] 38.5320μs 10.7631μs 92.9103 KOps/s 95.3024 KOps/s $\color{#d91a1a}-2.51\%$
test_step_mdp_speed[True-False-True-True-True] 95.2680μs 31.0302μs 32.2267 KOps/s 32.5795 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[True-False-True-True-False] 63.9500μs 19.2885μs 51.8444 KOps/s 52.8098 KOps/s $\color{#d91a1a}-1.83\%$
test_step_mdp_speed[True-False-True-False-True] 75.5410μs 17.4563μs 57.2858 KOps/s 58.4709 KOps/s $\color{#d91a1a}-2.03\%$
test_step_mdp_speed[True-False-True-False-False] 0.5030ms 10.7469μs 93.0498 KOps/s 96.3660 KOps/s $\color{#d91a1a}-3.44\%$
test_step_mdp_speed[True-False-False-True-True] 82.5340μs 32.8042μs 30.4839 KOps/s 31.1725 KOps/s $\color{#d91a1a}-2.21\%$
test_step_mdp_speed[True-False-False-True-False] 70.7320μs 21.0700μs 47.4608 KOps/s 47.7041 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[True-False-False-False-True] 69.6100μs 18.7706μs 53.2747 KOps/s 54.1636 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-False-False-False-False] 69.9510μs 12.4792μs 80.1332 KOps/s 81.5167 KOps/s $\color{#d91a1a}-1.70\%$
test_step_mdp_speed[False-True-True-True-True] 96.1790μs 30.8606μs 32.4038 KOps/s 32.6866 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[False-True-True-True-False] 58.9700μs 19.4030μs 51.5384 KOps/s 52.4792 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[False-True-True-False-True] 79.1170μs 19.7665μs 50.5907 KOps/s 51.7392 KOps/s $\color{#d91a1a}-2.22\%$
test_step_mdp_speed[False-True-True-False-False] 45.5350μs 12.0559μs 82.9469 KOps/s 84.5731 KOps/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[False-True-False-True-True] 94.4770μs 32.7772μs 30.5090 KOps/s 31.5292 KOps/s $\color{#d91a1a}-3.24\%$
test_step_mdp_speed[False-True-False-True-False] 68.8180μs 20.9343μs 47.7685 KOps/s 48.4563 KOps/s $\color{#d91a1a}-1.42\%$
test_step_mdp_speed[False-True-False-False-True] 2.6648ms 21.4242μs 46.6761 KOps/s 47.9312 KOps/s $\color{#d91a1a}-2.62\%$
test_step_mdp_speed[False-True-False-False-False] 97.7800μs 13.6262μs 73.3883 KOps/s 72.7070 KOps/s $\color{#35bf28}+0.94\%$
test_step_mdp_speed[False-False-True-True-True] 90.6810μs 34.0136μs 29.4000 KOps/s 29.8259 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[False-False-True-True-False] 75.4890μs 22.4353μs 44.5725 KOps/s 45.4429 KOps/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[False-False-True-False-True] 82.8150μs 21.4111μs 46.7048 KOps/s 47.5311 KOps/s $\color{#d91a1a}-1.74\%$
test_step_mdp_speed[False-False-True-False-False] 50.8750μs 13.5863μs 73.6034 KOps/s 74.5667 KOps/s $\color{#d91a1a}-1.29\%$
test_step_mdp_speed[False-False-False-True-True] 78.9070μs 35.1967μs 28.4118 KOps/s 29.0830 KOps/s $\color{#d91a1a}-2.31\%$
test_step_mdp_speed[False-False-False-True-False] 0.6142ms 24.2053μs 41.3133 KOps/s 42.6771 KOps/s $\color{#d91a1a}-3.20\%$
test_step_mdp_speed[False-False-False-False-True] 76.6430μs 22.1310μs 45.1854 KOps/s 44.5142 KOps/s $\color{#35bf28}+1.51\%$
test_step_mdp_speed[False-False-False-False-False] 73.0340μs 15.0926μs 66.2575 KOps/s 66.6126 KOps/s $\color{#d91a1a}-0.53\%$
test_values[generalized_advantage_estimate-True-True] 10.0971ms 9.4926ms 105.3448 Ops/s 102.2453 Ops/s $\color{#35bf28}+3.03\%$
test_values[vec_generalized_advantage_estimate-True-True] 41.1968ms 33.7435ms 29.6354 Ops/s 27.3979 Ops/s $\textbf{\color{#35bf28}+8.17\%}$
test_values[td0_return_estimate-False-False] 0.2133ms 0.1775ms 5.6325 KOps/s 5.8155 KOps/s $\color{#d91a1a}-3.15\%$
test_values[td1_return_estimate-False-False] 27.9353ms 24.1807ms 41.3553 Ops/s 40.8271 Ops/s $\color{#35bf28}+1.29\%$
test_values[vec_td1_return_estimate-False-False] 35.8779ms 33.7539ms 29.6262 Ops/s 27.3233 Ops/s $\textbf{\color{#35bf28}+8.43\%}$
test_values[td_lambda_return_estimate-True-False] 35.6825ms 34.8212ms 28.7181 Ops/s 28.3441 Ops/s $\color{#35bf28}+1.32\%$
test_values[vec_td_lambda_return_estimate-True-False] 35.5731ms 33.7412ms 29.6374 Ops/s 27.3663 Ops/s $\textbf{\color{#35bf28}+8.30\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.9219ms 8.3771ms 119.3728 Ops/s 117.5727 Ops/s $\color{#35bf28}+1.53\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.1764ms 1.8653ms 536.1198 Ops/s 543.8341 Ops/s $\color{#d91a1a}-1.42\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5429ms 0.3536ms 2.8284 KOps/s 2.7914 KOps/s $\color{#35bf28}+1.33\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 38.5969ms 36.4889ms 27.4056 Ops/s 23.6231 Ops/s $\textbf{\color{#35bf28}+16.01\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.2844ms 3.0559ms 327.2341 Ops/s 321.6764 Ops/s $\color{#35bf28}+1.73\%$
test_dqn_speed[False-None] 1.6088ms 1.3122ms 762.0980 Ops/s 739.7188 Ops/s $\color{#35bf28}+3.03\%$
test_dqn_speed[False-backward] 1.9120ms 1.8090ms 552.7959 Ops/s 547.7196 Ops/s $\color{#35bf28}+0.93\%$
test_dqn_speed[True-None] 0.7164ms 0.4658ms 2.1469 KOps/s 2.1120 KOps/s $\color{#35bf28}+1.65\%$
test_dqn_speed[True-backward] 1.0227ms 0.9020ms 1.1087 KOps/s 1.1058 KOps/s $\color{#35bf28}+0.26\%$
test_dqn_speed[reduce-overhead-None] 0.7476ms 0.4695ms 2.1299 KOps/s 2.1223 KOps/s $\color{#35bf28}+0.36\%$
test_dqn_speed[reduce-overhead-backward] 0.9578ms 0.8780ms 1.1389 KOps/s 1.1161 KOps/s $\color{#35bf28}+2.04\%$
test_ddpg_speed[False-None] 3.4865ms 2.7676ms 361.3285 Ops/s 355.7290 Ops/s $\color{#35bf28}+1.57\%$
test_ddpg_speed[False-backward] 4.1058ms 3.8929ms 256.8777 Ops/s 253.1789 Ops/s $\color{#35bf28}+1.46\%$
test_ddpg_speed[True-None] 1.2138ms 1.0081ms 991.9436 Ops/s 976.0828 Ops/s $\color{#35bf28}+1.62\%$
test_ddpg_speed[True-backward] 1.9909ms 1.9164ms 521.8062 Ops/s 514.6395 Ops/s $\color{#35bf28}+1.39\%$
test_ddpg_speed[reduce-overhead-None] 1.2777ms 1.0209ms 979.5167 Ops/s 978.5814 Ops/s $\color{#35bf28}+0.10\%$
test_ddpg_speed[reduce-overhead-backward] 2.5880ms 1.9311ms 517.8315 Ops/s 514.0534 Ops/s $\color{#35bf28}+0.73\%$
test_sac_speed[False-None] 8.7722ms 7.7295ms 129.3751 Ops/s 127.5248 Ops/s $\color{#35bf28}+1.45\%$
test_sac_speed[False-backward] 15.2028ms 10.7993ms 92.5984 Ops/s 93.6046 Ops/s $\color{#d91a1a}-1.07\%$
test_sac_speed[True-None] 2.4130ms 1.8345ms 545.1220 Ops/s 540.5890 Ops/s $\color{#35bf28}+0.84\%$
test_sac_speed[True-backward] 4.4390ms 3.5451ms 282.0765 Ops/s 277.3329 Ops/s $\color{#35bf28}+1.71\%$
test_sac_speed[reduce-overhead-None] 2.3397ms 1.8350ms 544.9463 Ops/s 539.2477 Ops/s $\color{#35bf28}+1.06\%$
test_sac_speed[reduce-overhead-backward] 3.8286ms 3.5344ms 282.9324 Ops/s 277.9933 Ops/s $\color{#35bf28}+1.78\%$
test_redq_speed[False-None] 14.4686ms 13.0034ms 76.9030 Ops/s 72.4414 Ops/s $\textbf{\color{#35bf28}+6.16\%}$
test_redq_speed[False-backward] 24.3542ms 22.5343ms 44.3768 Ops/s 42.3661 Ops/s $\color{#35bf28}+4.75\%$
test_redq_speed[True-None] 5.4983ms 4.7381ms 211.0537 Ops/s 199.3535 Ops/s $\textbf{\color{#35bf28}+5.87\%}$
test_redq_speed[True-backward] 13.9531ms 12.6218ms 79.2280 Ops/s 78.0837 Ops/s $\color{#35bf28}+1.47\%$
test_redq_speed[reduce-overhead-None] 5.6382ms 4.8549ms 205.9763 Ops/s 192.1906 Ops/s $\textbf{\color{#35bf28}+7.17\%}$
test_redq_speed[reduce-overhead-backward] 12.9089ms 12.2144ms 81.8703 Ops/s 77.0397 Ops/s $\textbf{\color{#35bf28}+6.27\%}$
test_redq_deprec_speed[False-None] 14.2234ms 12.8440ms 77.8576 Ops/s 74.0221 Ops/s $\textbf{\color{#35bf28}+5.18\%}$
test_redq_deprec_speed[False-backward] 19.8622ms 18.7017ms 53.4712 Ops/s 50.3659 Ops/s $\textbf{\color{#35bf28}+6.17\%}$
test_redq_deprec_speed[True-None] 4.6491ms 3.6691ms 272.5461 Ops/s 255.3180 Ops/s $\textbf{\color{#35bf28}+6.75\%}$
test_redq_deprec_speed[True-backward] 9.0275ms 8.2064ms 121.8565 Ops/s 112.5539 Ops/s $\textbf{\color{#35bf28}+8.27\%}$
test_redq_deprec_speed[reduce-overhead-None] 5.0129ms 3.6940ms 270.7059 Ops/s 267.2692 Ops/s $\color{#35bf28}+1.29\%$
test_redq_deprec_speed[reduce-overhead-backward] 9.3625ms 8.3647ms 119.5494 Ops/s 116.4536 Ops/s $\color{#35bf28}+2.66\%$
test_td3_speed[False-None] 7.9651ms 7.6789ms 130.2277 Ops/s 125.4668 Ops/s $\color{#35bf28}+3.79\%$
test_td3_speed[False-backward] 11.1821ms 10.0668ms 99.3368 Ops/s 95.6441 Ops/s $\color{#35bf28}+3.86\%$
test_td3_speed[True-None] 1.8002ms 1.6936ms 590.4410 Ops/s 559.3362 Ops/s $\textbf{\color{#35bf28}+5.56\%}$
test_td3_speed[True-backward] 3.7226ms 3.3613ms 297.5057 Ops/s 291.7693 Ops/s $\color{#35bf28}+1.97\%$
test_td3_speed[reduce-overhead-None] 1.8939ms 1.6946ms 590.1120 Ops/s 560.1930 Ops/s $\textbf{\color{#35bf28}+5.34\%}$
test_td3_speed[reduce-overhead-backward] 4.5546ms 3.5432ms 282.2296 Ops/s 290.2313 Ops/s $\color{#d91a1a}-2.76\%$
test_cql_speed[False-None] 39.4986ms 36.6122ms 27.3133 Ops/s 27.6573 Ops/s $\color{#d91a1a}-1.24\%$
test_cql_speed[False-backward] 59.6829ms 46.8560ms 21.3420 Ops/s 21.5492 Ops/s $\color{#d91a1a}-0.96\%$
test_cql_speed[True-None] 17.3044ms 16.0953ms 62.1300 Ops/s 62.0156 Ops/s $\color{#35bf28}+0.18\%$
test_cql_speed[True-backward] 23.3996ms 22.3202ms 44.8026 Ops/s 42.6941 Ops/s $\color{#35bf28}+4.94\%$
test_cql_speed[reduce-overhead-None] 16.7313ms 15.5448ms 64.3303 Ops/s 62.0514 Ops/s $\color{#35bf28}+3.67\%$
test_cql_speed[reduce-overhead-backward] 22.9586ms 22.3383ms 44.7662 Ops/s 43.5462 Ops/s $\color{#35bf28}+2.80\%$
test_a2c_speed[False-None] 9.2015ms 7.0409ms 142.0282 Ops/s 136.6989 Ops/s $\color{#35bf28}+3.90\%$
test_a2c_speed[False-backward] 15.3179ms 14.1525ms 70.6588 Ops/s 66.9896 Ops/s $\textbf{\color{#35bf28}+5.48\%}$
test_a2c_speed[True-None] 3.5297ms 3.3026ms 302.7898 Ops/s 295.2664 Ops/s $\color{#35bf28}+2.55\%$
test_a2c_speed[True-backward] 10.2058ms 9.7045ms 103.0452 Ops/s 101.3963 Ops/s $\color{#35bf28}+1.63\%$
test_a2c_speed[reduce-overhead-None] 3.7024ms 3.2996ms 303.0636 Ops/s 295.4731 Ops/s $\color{#35bf28}+2.57\%$
test_a2c_speed[reduce-overhead-backward] 10.4628ms 9.7037ms 103.0540 Ops/s 99.4849 Ops/s $\color{#35bf28}+3.59\%$
test_ppo_speed[False-None] 8.0438ms 7.2908ms 137.1596 Ops/s 134.3489 Ops/s $\color{#35bf28}+2.09\%$
test_ppo_speed[False-backward] 15.9478ms 14.7854ms 67.6342 Ops/s 67.6598 Ops/s $\color{#d91a1a}-0.04\%$
test_ppo_speed[True-None] 4.4095ms 3.6743ms 272.1602 Ops/s 269.0647 Ops/s $\color{#35bf28}+1.15\%$
test_ppo_speed[True-backward] 9.9801ms 9.5533ms 104.6757 Ops/s 99.0038 Ops/s $\textbf{\color{#35bf28}+5.73\%}$
test_ppo_speed[reduce-overhead-None] 3.9150ms 3.6769ms 271.9646 Ops/s 266.0034 Ops/s $\color{#35bf28}+2.24\%$
test_ppo_speed[reduce-overhead-backward] 13.5202ms 9.8501ms 101.5215 Ops/s 94.4246 Ops/s $\textbf{\color{#35bf28}+7.52\%}$
test_reinforce_speed[False-None] 7.6840ms 6.4632ms 154.7212 Ops/s 148.5360 Ops/s $\color{#35bf28}+4.16\%$
test_reinforce_speed[False-backward] 10.4514ms 9.7974ms 102.0684 Ops/s 99.5955 Ops/s $\color{#35bf28}+2.48\%$
test_reinforce_speed[True-None] 4.0175ms 2.6637ms 375.4155 Ops/s 360.0114 Ops/s $\color{#35bf28}+4.28\%$
test_reinforce_speed[True-backward] 9.3412ms 8.5408ms 117.0854 Ops/s 113.2853 Ops/s $\color{#35bf28}+3.35\%$
test_reinforce_speed[reduce-overhead-None] 2.9106ms 2.6284ms 380.4610 Ops/s 362.6633 Ops/s $\color{#35bf28}+4.91\%$
test_reinforce_speed[reduce-overhead-backward] 10.8603ms 8.9324ms 111.9520 Ops/s 115.1266 Ops/s $\color{#d91a1a}-2.76\%$
test_iql_speed[False-None] 32.6297ms 31.7276ms 31.5183 Ops/s 29.9175 Ops/s $\textbf{\color{#35bf28}+5.35\%}$
test_iql_speed[False-backward] 46.4044ms 44.9706ms 22.2367 Ops/s 21.6005 Ops/s $\color{#35bf28}+2.95\%$
test_iql_speed[True-None] 11.3204ms 10.4958ms 95.2761 Ops/s 89.9035 Ops/s $\textbf{\color{#35bf28}+5.98\%}$
test_iql_speed[True-backward] 23.2211ms 22.0545ms 45.3421 Ops/s 43.8327 Ops/s $\color{#35bf28}+3.44\%$
test_iql_speed[reduce-overhead-None] 12.0773ms 10.8900ms 91.8274 Ops/s 88.8176 Ops/s $\color{#35bf28}+3.39\%$
test_iql_speed[reduce-overhead-backward] 22.3546ms 21.5355ms 46.4350 Ops/s 44.4353 Ops/s $\color{#35bf28}+4.50\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.8079ms 4.8785ms 204.9797 Ops/s 190.7676 Ops/s $\textbf{\color{#35bf28}+7.45\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0210ms 0.5057ms 1.9775 KOps/s 1.8956 KOps/s $\color{#35bf28}+4.32\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6874ms 0.4822ms 2.0739 KOps/s 2.0382 KOps/s $\color{#35bf28}+1.75\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.7038ms 4.8385ms 206.6768 Ops/s 196.7682 Ops/s $\textbf{\color{#35bf28}+5.04\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.3570s 0.7675ms 1.3030 KOps/s 2.0017 KOps/s $\textbf{\color{#d91a1a}-34.91\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7269ms 0.4749ms 2.1055 KOps/s 2.0998 KOps/s $\color{#35bf28}+0.27\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.9588ms 1.6081ms 621.8329 Ops/s 606.5915 Ops/s $\color{#35bf28}+2.51\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.0655ms 1.5615ms 640.3910 Ops/s 625.6971 Ops/s $\color{#35bf28}+2.35\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.6402ms 4.9591ms 201.6489 Ops/s 195.0668 Ops/s $\color{#35bf28}+3.37\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1968ms 0.6352ms 1.5744 KOps/s 1.5285 KOps/s $\color{#35bf28}+3.00\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8590ms 0.6117ms 1.6348 KOps/s 1.6023 KOps/s $\color{#35bf28}+2.03\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.2043ms 4.8593ms 205.7899 Ops/s 197.3070 Ops/s $\color{#35bf28}+4.30\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.1143ms 0.5138ms 1.9462 KOps/s 1.9207 KOps/s $\color{#35bf28}+1.33\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7371ms 0.4810ms 2.0791 KOps/s 2.0532 KOps/s $\color{#35bf28}+1.26\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.6454ms 4.8474ms 206.2973 Ops/s 203.8714 Ops/s $\color{#35bf28}+1.19\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.6542ms 0.5409ms 1.8488 KOps/s 1.9940 KOps/s $\textbf{\color{#d91a1a}-7.28\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7345ms 0.4796ms 2.0852 KOps/s 2.0804 KOps/s $\color{#35bf28}+0.23\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.4208ms 4.9515ms 201.9596 Ops/s 195.4946 Ops/s $\color{#35bf28}+3.31\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8426ms 0.6364ms 1.5714 KOps/s 1.5382 KOps/s $\color{#35bf28}+2.16\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 7.6956ms 0.6247ms 1.6008 KOps/s 1.5887 KOps/s $\color{#35bf28}+0.77\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.4359s 12.8638ms 77.7375 Ops/s 238.8832 Ops/s $\textbf{\color{#d91a1a}-67.46\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 8.3294ms 2.3336ms 428.5297 Ops/s 449.2723 Ops/s $\color{#d91a1a}-4.62\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 5.3637ms 1.3613ms 734.5939 Ops/s 797.5169 Ops/s $\textbf{\color{#d91a1a}-7.89\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.9982ms 4.2550ms 235.0202 Ops/s 256.9488 Ops/s $\textbf{\color{#d91a1a}-8.53\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.4851ms 2.3696ms 422.0066 Ops/s 436.0035 Ops/s $\color{#d91a1a}-3.21\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.1477ms 1.2654ms 790.2783 Ops/s 802.3099 Ops/s $\color{#d91a1a}-1.50\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.4038s 12.4207ms 80.5106 Ops/s 34.1469 Ops/s $\textbf{\color{#35bf28}+135.78\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 3.3858ms 2.2744ms 439.6815 Ops/s 441.5644 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.1206ms 1.3882ms 720.3661 Ops/s 737.2980 Ops/s $\color{#d91a1a}-2.30\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 11.2524ms 10.9018ms 91.7282 Ops/s 88.4400 Ops/s $\color{#35bf28}+3.72\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 15.0853ms 14.2480ms 70.1854 Ops/s 68.4700 Ops/s $\color{#35bf28}+2.51\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 20.6308ms 19.6324ms 50.9361 Ops/s 49.9167 Ops/s $\color{#35bf28}+2.04\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 14.7510ms 14.3040ms 69.9104 Ops/s 68.2475 Ops/s $\color{#35bf28}+2.44\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 20.6660ms 19.9267ms 50.1838 Ops/s 49.7930 Ops/s $\color{#35bf28}+0.78\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 18.1232ms 15.7424ms 63.5226 Ops/s 62.6217 Ops/s $\color{#35bf28}+1.44\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BE Better errors, logs, docs or test utils ciflow/docs tests full docs CI CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot