Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] compile compatibility improvements #2578

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 18, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2578

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures, 17 Unrelated Failures

As of commit ef45f79 with merge base 507766a (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Nov 18, 2024
ghstack-source-id: 6d5df6e8d633ce1887beebf675796dcd627ca397
Pull Request resolved: #2578
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2024
[ghstack-poisoned]
@vmoens vmoens added the Refactoring Refactoring of an existing feature label Nov 18, 2024
[ghstack-poisoned]
[ghstack-poisoned]
@vmoens vmoens merged commit ef45f79 into gh/vmoens/47/base Nov 18, 2024
51 of 72 checks passed
vmoens added a commit that referenced this pull request Nov 18, 2024
ghstack-source-id: 95f8241b56e42b80e828485cb5f377288bff6f5e
Pull Request resolved: #2578
@vmoens vmoens deleted the gh/vmoens/47/head branch November 18, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants