Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Support for tensor collection in the PPOLoss #2543

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[BugFix] Support for tensor collection in the PPOLoss #2543

merged 3 commits into from
Nov 6, 2024

Conversation

priba
Copy link
Contributor

@priba priba commented Nov 6, 2024

Description

The function get_entropy_bonus was not unpacking the entropy from the TensorDict.

Motivation and Context

When using a CompositeDistribution, the return type of the entropy can be either a Tensor or a TensorDict depending on the aggregate_probabilities. This break the get_entropy_bonus that expects a Tensor. We can unpack it accessing by the entropy key.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2543

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 14 Unrelated Failures

As of commit 1f33881 with merge base 997d90e (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2024
@vmoens vmoens added the bug Something isn't working label Nov 6, 2024
vmoens
vmoens approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this
@albertbou92

@vmoens vmoens merged commit 0eabb78 into pytorch:main Nov 6, 2024
62 of 75 checks passed
vmoens pushed a commit that referenced this pull request Nov 14, 2024
@priba @vmoens
[BugFix] Support for tensor collection in the PPOLoss (#2543)
605c0fe 
Co-authored-by: Pau Riba <pau.riba@helsing.ai>
(cherry picked from commit 0eabb78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priba @vmoens @facebook-github-bot