Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix dumps for SamplerWithoutReplacement #2506

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[BugFix] Fix dumps for SamplerWithoutReplacement #2506

merged 1 commit into from
Oct 21, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Oct 21, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2506

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 5 Unrelated Failures

As of commit 764f636 with merge base a27514c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
@vmoens vmoens linked an issue Oct 21, 2024 that may be closed by this pull request
[BUG] SamplerWithoutReplacement.dumps failed #2505
Closed
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 143. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.7262s 0.7253s 1.3788 Ops/s 1.3742 Ops/s $\color{#35bf28}+0.33\%$
test_transformed 1.0607s 0.9852s 1.0150 Ops/s 1.0339 Ops/s $\color{#d91a1a}-1.83\%$
test_serial 2.1956s 2.1178s 0.4722 Ops/s 0.4761 Ops/s $\color{#d91a1a}-0.83\%$
test_parallel 2.0864s 2.0012s 0.4997 Ops/s 0.5057 Ops/s $\color{#d91a1a}-1.18\%$
test_step_mdp_speed[True-True-True-True-True] 0.2495ms 39.9335μs 25.0417 KOps/s 26.3413 KOps/s $\color{#d91a1a}-4.93\%$
test_step_mdp_speed[True-True-True-True-False] 0.3991ms 22.9089μs 43.6512 KOps/s 43.8540 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[True-True-True-False-True] 59.1210μs 20.9917μs 47.6378 KOps/s 48.7408 KOps/s $\color{#d91a1a}-2.26\%$
test_step_mdp_speed[True-True-True-False-False] 0.4192ms 12.4528μs 80.3032 KOps/s 81.6500 KOps/s $\color{#d91a1a}-1.65\%$
test_step_mdp_speed[True-True-False-True-True] 0.4310ms 42.3926μs 23.5890 KOps/s 24.1859 KOps/s $\color{#d91a1a}-2.47\%$
test_step_mdp_speed[True-True-False-True-False] 0.4080ms 25.6090μs 39.0488 KOps/s 39.5950 KOps/s $\color{#d91a1a}-1.38\%$
test_step_mdp_speed[True-True-False-False-True] 0.1394ms 23.6448μs 42.2926 KOps/s 42.0653 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[True-True-False-False-False] 0.4042ms 15.1938μs 65.8164 KOps/s 66.9839 KOps/s $\color{#d91a1a}-1.74\%$
test_step_mdp_speed[True-False-True-True-True] 0.4341ms 44.9207μs 22.2614 KOps/s 22.3782 KOps/s $\color{#d91a1a}-0.52\%$
test_step_mdp_speed[True-False-True-True-False] 95.3210μs 28.1554μs 35.5172 KOps/s 35.1993 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-False-True-False-True] 0.4162ms 23.9304μs 41.7879 KOps/s 42.7099 KOps/s $\color{#d91a1a}-2.16\%$
test_step_mdp_speed[True-False-True-False-False] 0.4043ms 15.3831μs 65.0064 KOps/s 66.4200 KOps/s $\color{#d91a1a}-2.13\%$
test_step_mdp_speed[True-False-False-True-True] 80.9910μs 46.8961μs 21.3238 KOps/s 21.1634 KOps/s $\color{#35bf28}+0.76\%$
test_step_mdp_speed[True-False-False-True-False] 69.9010μs 31.0128μs 32.2447 KOps/s 31.9024 KOps/s $\color{#35bf28}+1.07\%$
test_step_mdp_speed[True-False-False-False-True] 0.4129ms 27.2040μs 36.7594 KOps/s 38.1845 KOps/s $\color{#d91a1a}-3.73\%$
test_step_mdp_speed[True-False-False-False-False] 0.4052ms 18.0288μs 55.4669 KOps/s 56.7073 KOps/s $\color{#d91a1a}-2.19\%$
test_step_mdp_speed[False-True-True-True-True] 84.4410μs 45.1008μs 22.1726 KOps/s 22.5207 KOps/s $\color{#d91a1a}-1.55\%$
test_step_mdp_speed[False-True-True-True-False] 0.4361ms 28.4428μs 35.1583 KOps/s 35.4109 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[False-True-True-False-True] 0.4212ms 29.0095μs 34.4714 KOps/s 35.0922 KOps/s $\color{#d91a1a}-1.77\%$
test_step_mdp_speed[False-True-True-False-False] 57.6310μs 17.5476μs 56.9878 KOps/s 56.4527 KOps/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[False-True-False-True-True] 87.1410μs 47.9550μs 20.8529 KOps/s 21.2078 KOps/s $\color{#d91a1a}-1.67\%$
test_step_mdp_speed[False-True-False-True-False] 0.4183ms 31.0410μs 32.2155 KOps/s 32.2049 KOps/s $\color{#35bf28}+0.03\%$
test_step_mdp_speed[False-True-False-False-True] 3.0905ms 31.5440μs 31.7017 KOps/s 32.3078 KOps/s $\color{#d91a1a}-1.88\%$
test_step_mdp_speed[False-True-False-False-False] 59.2910μs 20.3118μs 49.2324 KOps/s 49.0416 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-False-True-True-True] 0.4345ms 50.1918μs 19.9236 KOps/s 19.9646 KOps/s $\color{#d91a1a}-0.21\%$
test_step_mdp_speed[False-False-True-True-False] 0.4237ms 33.7650μs 29.6165 KOps/s 29.3152 KOps/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[False-False-True-False-True] 0.4218ms 31.4186μs 31.8283 KOps/s 31.7630 KOps/s $\color{#35bf28}+0.21\%$
test_step_mdp_speed[False-False-True-False-False] 63.6410μs 20.0644μs 49.8395 KOps/s 49.1366 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[False-False-False-True-True] 0.4350ms 52.4209μs 19.0763 KOps/s 19.3575 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[False-False-False-True-False] 0.4166ms 35.8801μs 27.8706 KOps/s 27.2714 KOps/s $\color{#35bf28}+2.20\%$
test_step_mdp_speed[False-False-False-False-True] 0.4216ms 33.6816μs 29.6898 KOps/s 29.9479 KOps/s $\color{#d91a1a}-0.86\%$
test_step_mdp_speed[False-False-False-False-False] 0.4073ms 22.5289μs 44.3874 KOps/s 43.6722 KOps/s $\color{#35bf28}+1.64\%$
test_values[generalized_advantage_estimate-True-True] 24.4424ms 23.9663ms 41.7252 Ops/s 41.0566 Ops/s $\color{#35bf28}+1.63\%$
test_values[vec_generalized_advantage_estimate-True-True] 0.1101s 3.0796ms 324.7158 Ops/s 341.0380 Ops/s $\color{#d91a1a}-4.79\%$
test_values[td0_return_estimate-False-False] 84.5810μs 64.6604μs 15.4654 KOps/s 15.4852 KOps/s $\color{#d91a1a}-0.13\%$
test_values[td1_return_estimate-False-False] 54.8640ms 54.1940ms 18.4522 Ops/s 18.3822 Ops/s $\color{#35bf28}+0.38\%$
test_values[vec_td1_return_estimate-False-False] 1.3636ms 1.0572ms 945.9227 Ops/s 942.7069 Ops/s $\color{#35bf28}+0.34\%$
test_values[td_lambda_return_estimate-True-False] 91.1284ms 89.3497ms 11.1920 Ops/s 11.3133 Ops/s $\color{#d91a1a}-1.07\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.3503ms 1.0701ms 934.5220 Ops/s 934.0748 Ops/s $\color{#35bf28}+0.05\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.6521ms 25.4117ms 39.3520 Ops/s 41.2971 Ops/s $\color{#d91a1a}-4.71\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.0369ms 0.7570ms 1.3210 KOps/s 1.3869 KOps/s $\color{#d91a1a}-4.75\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7634ms 0.6678ms 1.4974 KOps/s 1.5546 KOps/s $\color{#d91a1a}-3.68\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5314ms 1.4759ms 677.5618 Ops/s 686.4331 Ops/s $\color{#d91a1a}-1.29\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7821ms 0.6853ms 1.4593 KOps/s 1.5242 KOps/s $\color{#d91a1a}-4.26\%$
test_dqn_speed[False-None] 6.5015ms 1.3311ms 751.2540 Ops/s 749.4011 Ops/s $\color{#35bf28}+0.25\%$
test_dqn_speed[False-backward] 1.9452ms 1.8392ms 543.7004 Ops/s 557.8391 Ops/s $\color{#d91a1a}-2.53\%$
test_dqn_speed[True-None] 0.9654ms 0.5538ms 1.8058 KOps/s 1.7571 KOps/s $\color{#35bf28}+2.77\%$
test_dqn_speed[True-backward] 1.0533ms 0.9937ms 1.0063 KOps/s 987.5605 Ops/s $\color{#35bf28}+1.90\%$
test_dqn_speed[reduce-overhead-None] 1.0000ms 0.5661ms 1.7663 KOps/s 1.7698 KOps/s $\color{#d91a1a}-0.20\%$
test_dqn_speed[reduce-overhead-backward] 1.1671ms 1.0252ms 975.3800 Ops/s 989.2096 Ops/s $\color{#d91a1a}-1.40\%$
test_ddpg_speed[False-None] 3.1366ms 2.7256ms 366.8924 Ops/s 367.0019 Ops/s $\color{#d91a1a}-0.03\%$
test_ddpg_speed[False-backward] 4.1310ms 3.9605ms 252.4922 Ops/s 254.8496 Ops/s $\color{#d91a1a}-0.92\%$
test_ddpg_speed[True-None] 1.6466ms 1.2290ms 813.6550 Ops/s 789.6540 Ops/s $\color{#35bf28}+3.04\%$
test_ddpg_speed[True-backward] 2.2383ms 2.2062ms 453.2710 Ops/s 412.1440 Ops/s $\textbf{\color{#35bf28}+9.98\%}$
test_ddpg_speed[reduce-overhead-None] 1.6568ms 1.2430ms 804.4916 Ops/s 800.6073 Ops/s $\color{#35bf28}+0.49\%$
test_ddpg_speed[reduce-overhead-backward] 2.3020ms 2.2174ms 450.9729 Ops/s 455.3621 Ops/s $\color{#d91a1a}-0.96\%$
test_sac_speed[False-None] 8.0296ms 7.5543ms 132.3753 Ops/s 131.1713 Ops/s $\color{#35bf28}+0.92\%$
test_sac_speed[False-backward] 11.3034ms 10.7472ms 93.0478 Ops/s 93.6800 Ops/s $\color{#d91a1a}-0.67\%$
test_sac_speed[True-None] 2.2074ms 2.0254ms 493.7386 Ops/s 476.6017 Ops/s $\color{#35bf28}+3.60\%$
test_sac_speed[True-backward] 4.0345ms 3.9318ms 254.3387 Ops/s 208.5170 Ops/s $\textbf{\color{#35bf28}+21.98\%}$
test_sac_speed[reduce-overhead-None] 2.5014ms 2.0503ms 487.7375 Ops/s 492.4228 Ops/s $\color{#d91a1a}-0.95\%$
test_sac_speed[reduce-overhead-backward] 4.0181ms 3.9282ms 254.5710 Ops/s 256.3971 Ops/s $\color{#d91a1a}-0.71\%$
test_redq_speed[False-None] 15.5382ms 10.6870ms 93.5716 Ops/s 96.2104 Ops/s $\color{#d91a1a}-2.74\%$
test_redq_speed[False-backward] 18.3205ms 17.1067ms 58.4568 Ops/s 57.6433 Ops/s $\color{#35bf28}+1.41\%$
test_redq_speed[True-None] 3.8292ms 3.5867ms 278.8098 Ops/s 271.5358 Ops/s $\color{#35bf28}+2.68\%$
test_redq_speed[True-backward] 8.8325ms 8.5735ms 116.6389 Ops/s 120.5692 Ops/s $\color{#d91a1a}-3.26\%$
test_redq_speed[reduce-overhead-None] 4.0697ms 3.6027ms 277.5721 Ops/s 274.8189 Ops/s $\color{#35bf28}+1.00\%$
test_redq_speed[reduce-overhead-backward] 10.2361ms 8.8148ms 113.4458 Ops/s 120.0102 Ops/s $\textbf{\color{#d91a1a}-5.47\%}$
test_redq_deprec_speed[False-None] 11.0981ms 10.4952ms 95.2817 Ops/s 95.1504 Ops/s $\color{#35bf28}+0.14\%$
test_redq_deprec_speed[False-backward] 15.9415ms 15.3376ms 65.1994 Ops/s 66.2784 Ops/s $\color{#d91a1a}-1.63\%$
test_redq_deprec_speed[True-None] 3.6818ms 3.2751ms 305.3379 Ops/s 302.5126 Ops/s $\color{#35bf28}+0.93\%$
test_redq_deprec_speed[True-backward] 7.4814ms 7.2878ms 137.2158 Ops/s 140.6021 Ops/s $\color{#d91a1a}-2.41\%$
test_redq_deprec_speed[reduce-overhead-None] 3.6083ms 3.2526ms 307.4462 Ops/s 309.0879 Ops/s $\color{#d91a1a}-0.53\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.4381ms 7.2143ms 138.6143 Ops/s 138.4959 Ops/s $\color{#35bf28}+0.09\%$
test_td3_speed[False-None] 8.0303ms 7.5529ms 132.4003 Ops/s 133.8772 Ops/s $\color{#d91a1a}-1.10\%$
test_td3_speed[False-backward] 10.6053ms 10.2760ms 97.3144 Ops/s 97.3052 Ops/s $+0.01\%$
test_td3_speed[True-None] 1.9486ms 1.9091ms 523.7964 Ops/s 527.5211 Ops/s $\color{#d91a1a}-0.71\%$
test_td3_speed[True-backward] 3.8326ms 3.7222ms 268.6564 Ops/s 271.2745 Ops/s $\color{#d91a1a}-0.97\%$
test_td3_speed[reduce-overhead-None] 1.9567ms 1.8991ms 526.5684 Ops/s 526.9107 Ops/s $\color{#d91a1a}-0.06\%$
test_td3_speed[reduce-overhead-backward] 3.8355ms 3.7204ms 268.7913 Ops/s 272.3564 Ops/s $\color{#d91a1a}-1.31\%$
test_cql_speed[False-None] 28.2447ms 25.2492ms 39.6051 Ops/s 40.7810 Ops/s $\color{#d91a1a}-2.88\%$
test_cql_speed[False-backward] 0.2844s 39.7838ms 25.1358 Ops/s 29.7668 Ops/s $\textbf{\color{#d91a1a}-15.56\%}$
test_cql_speed[True-None] 11.1644ms 10.8821ms 91.8937 Ops/s 92.9647 Ops/s $\color{#d91a1a}-1.15\%$
test_cql_speed[True-backward] 17.1849ms 16.7679ms 59.6378 Ops/s 58.9637 Ops/s $\color{#35bf28}+1.14\%$
test_cql_speed[reduce-overhead-None] 11.4156ms 10.9384ms 91.4207 Ops/s 95.0743 Ops/s $\color{#d91a1a}-3.84\%$
test_cql_speed[reduce-overhead-backward] 17.2497ms 16.6836ms 59.9393 Ops/s 62.4056 Ops/s $\color{#d91a1a}-3.95\%$
test_a2c_speed[False-None] 6.4817ms 5.2962ms 188.8141 Ops/s 190.3825 Ops/s $\color{#d91a1a}-0.82\%$
test_a2c_speed[False-backward] 12.0165ms 11.7265ms 85.2770 Ops/s 86.3752 Ops/s $\color{#d91a1a}-1.27\%$
test_a2c_speed[True-None] 3.2973ms 3.0613ms 326.6593 Ops/s 325.8186 Ops/s $\color{#35bf28}+0.26\%$
test_a2c_speed[True-backward] 8.8538ms 8.6173ms 116.0463 Ops/s 113.2148 Ops/s $\color{#35bf28}+2.50\%$
test_a2c_speed[reduce-overhead-None] 3.4611ms 3.0332ms 329.6849 Ops/s 328.8046 Ops/s $\color{#35bf28}+0.27\%$
test_a2c_speed[reduce-overhead-backward] 8.8934ms 8.5667ms 116.7309 Ops/s 119.3452 Ops/s $\color{#d91a1a}-2.19\%$
test_ppo_speed[False-None] 6.1006ms 5.6696ms 176.3788 Ops/s 178.0895 Ops/s $\color{#d91a1a}-0.96\%$
test_ppo_speed[False-backward] 12.6467ms 12.2293ms 81.7708 Ops/s 83.3498 Ops/s $\color{#d91a1a}-1.89\%$
test_ppo_speed[True-None] 3.8003ms 3.4207ms 292.3344 Ops/s 286.7036 Ops/s $\color{#35bf28}+1.96\%$
test_ppo_speed[True-backward] 8.4150ms 8.2141ms 121.7420 Ops/s 122.2816 Ops/s $\color{#d91a1a}-0.44\%$
test_ppo_speed[reduce-overhead-None] 3.8855ms 3.4305ms 291.4999 Ops/s 289.7089 Ops/s $\color{#35bf28}+0.62\%$
test_ppo_speed[reduce-overhead-backward] 8.4282ms 8.2850ms 120.6996 Ops/s 121.6675 Ops/s $\color{#d91a1a}-0.80\%$
test_reinforce_speed[False-None] 6.4474ms 4.4065ms 226.9357 Ops/s 224.8235 Ops/s $\color{#35bf28}+0.94\%$
test_reinforce_speed[False-backward] 7.7237ms 7.2102ms 138.6917 Ops/s 136.9049 Ops/s $\color{#35bf28}+1.31\%$
test_reinforce_speed[True-None] 2.5996ms 2.2032ms 453.8822 Ops/s 454.3613 Ops/s $\color{#d91a1a}-0.11\%$
test_reinforce_speed[True-backward] 7.5528ms 7.1340ms 140.1729 Ops/s 142.8035 Ops/s $\color{#d91a1a}-1.84\%$
test_reinforce_speed[reduce-overhead-None] 2.6390ms 2.2166ms 451.1400 Ops/s 445.5214 Ops/s $\color{#35bf28}+1.26\%$
test_reinforce_speed[reduce-overhead-backward] 7.2682ms 7.0772ms 141.2997 Ops/s 141.5791 Ops/s $\color{#d91a1a}-0.20\%$
test_iql_speed[False-None] 23.8216ms 19.8747ms 50.3154 Ops/s 51.6424 Ops/s $\color{#d91a1a}-2.57\%$
test_iql_speed[False-backward] 35.9867ms 30.2094ms 33.1023 Ops/s 33.5315 Ops/s $\color{#d91a1a}-1.28\%$
test_iql_speed[True-None] 7.3159ms 6.7462ms 148.2314 Ops/s 150.1478 Ops/s $\color{#d91a1a}-1.28\%$
test_iql_speed[True-backward] 15.9653ms 15.5670ms 64.2385 Ops/s 64.7614 Ops/s $\color{#d91a1a}-0.81\%$
test_iql_speed[reduce-overhead-None] 7.1632ms 6.7704ms 147.7019 Ops/s 149.1756 Ops/s $\color{#d91a1a}-0.99\%$
test_iql_speed[reduce-overhead-backward] 15.7015ms 15.3796ms 65.0213 Ops/s 64.7068 Ops/s $\color{#35bf28}+0.49\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.5877ms 6.1950ms 161.4198 Ops/s 162.9099 Ops/s $\color{#d91a1a}-0.91\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8442ms 0.2367ms 4.2249 KOps/s 4.2215 KOps/s $\color{#35bf28}+0.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7760ms 0.2635ms 3.7955 KOps/s 4.6970 KOps/s $\textbf{\color{#d91a1a}-19.19\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.6765ms 6.1538ms 162.5007 Ops/s 167.8967 Ops/s $\color{#d91a1a}-3.21\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8586ms 0.2658ms 3.7620 KOps/s 4.3574 KOps/s $\textbf{\color{#d91a1a}-13.67\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4560ms 0.2100ms 4.7629 KOps/s 4.7434 KOps/s $\color{#35bf28}+0.41\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6268ms 1.1965ms 835.7472 Ops/s 789.3910 Ops/s $\textbf{\color{#35bf28}+5.87\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.3349ms 1.1267ms 887.5661 Ops/s 899.1451 Ops/s $\color{#d91a1a}-1.29\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.7439ms 6.3226ms 158.1615 Ops/s 162.4973 Ops/s $\color{#d91a1a}-2.67\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.9451ms 0.4117ms 2.4288 KOps/s 2.2739 KOps/s $\textbf{\color{#35bf28}+6.81\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7963ms 0.3553ms 2.8148 KOps/s 2.8242 KOps/s $\color{#d91a1a}-0.33\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.6375ms 6.1830ms 161.7336 Ops/s 166.3908 Ops/s $\color{#d91a1a}-2.80\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.7091ms 0.2606ms 3.8375 KOps/s 4.2856 KOps/s $\textbf{\color{#d91a1a}-10.46\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5511ms 0.3501ms 2.8562 KOps/s 4.7553 KOps/s $\textbf{\color{#d91a1a}-39.94\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 10.3571ms 6.2653ms 159.6080 Ops/s 167.8229 Ops/s $\color{#d91a1a}-4.89\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.2532ms 0.2330ms 4.2911 KOps/s 3.2973 KOps/s $\textbf{\color{#35bf28}+30.14\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6458ms 0.2112ms 4.7354 KOps/s 3.5008 KOps/s $\textbf{\color{#35bf28}+35.27\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.6522ms 6.2900ms 158.9828 Ops/s 157.8852 Ops/s $\color{#35bf28}+0.70\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9946ms 0.4462ms 2.2411 KOps/s 2.5765 KOps/s $\textbf{\color{#d91a1a}-13.02\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8775ms 0.4357ms 2.2953 KOps/s 2.8042 KOps/s $\textbf{\color{#d91a1a}-18.15\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 7.0077ms 5.2182ms 191.6367 Ops/s 191.8782 Ops/s $\color{#d91a1a}-0.13\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 11.1480ms 2.0476ms 488.3829 Ops/s 489.6532 Ops/s $\color{#d91a1a}-0.26\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2188ms 1.0673ms 936.9664 Ops/s 819.0594 Ops/s $\textbf{\color{#35bf28}+14.40\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.4186s 13.5371ms 73.8710 Ops/s 189.5371 Ops/s $\textbf{\color{#d91a1a}-61.03\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 7.7605ms 1.9871ms 503.2421 Ops/s 498.6656 Ops/s $\color{#35bf28}+0.92\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.2505ms 1.2401ms 806.3544 Ops/s 821.8220 Ops/s $\color{#d91a1a}-1.88\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 8.4358ms 5.4235ms 184.3831 Ops/s 184.0285 Ops/s $\color{#35bf28}+0.19\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 9.3856ms 2.1964ms 455.2858 Ops/s 454.6990 Ops/s $\color{#35bf28}+0.13\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.8890ms 1.3422ms 745.0377 Ops/s 756.2385 Ops/s $\color{#d91a1a}-1.48\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 143. Improved: $\large\color{#35bf28}24$. Worsened: $\large\color{#d91a1a}63$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_simple 0.4346s 0.4281s 2.3360 Ops/s 2.2097 Ops/s $\textbf{\color{#35bf28}+5.71\%}$
test_transformed 0.7268s 0.6277s 1.5931 Ops/s 1.5721 Ops/s $\color{#35bf28}+1.34\%$
test_serial 1.4778s 1.3790s 0.7252 Ops/s 0.7091 Ops/s $\color{#35bf28}+2.26\%$
test_parallel 1.4645s 1.3516s 0.7399 Ops/s 0.7218 Ops/s $\color{#35bf28}+2.50\%$
test_step_mdp_speed[True-True-True-True-True] 0.2147ms 28.0623μs 35.6350 KOps/s 34.2621 KOps/s $\color{#35bf28}+4.01\%$
test_step_mdp_speed[True-True-True-True-False] 53.7110μs 16.7461μs 59.7155 KOps/s 57.4688 KOps/s $\color{#35bf28}+3.91\%$
test_step_mdp_speed[True-True-True-False-True] 67.4970μs 15.7872μs 63.3423 KOps/s 61.2418 KOps/s $\color{#35bf28}+3.43\%$
test_step_mdp_speed[True-True-True-False-False] 34.5750μs 9.2398μs 108.2276 KOps/s 102.9206 KOps/s $\textbf{\color{#35bf28}+5.16\%}$
test_step_mdp_speed[True-True-False-True-True] 66.5250μs 30.3619μs 32.9361 KOps/s 31.6141 KOps/s $\color{#35bf28}+4.18\%$
test_step_mdp_speed[True-True-False-True-False] 60.3830μs 19.1846μs 52.1250 KOps/s 51.2251 KOps/s $\color{#35bf28}+1.76\%$
test_step_mdp_speed[True-True-False-False-True] 53.0300μs 17.6758μs 56.5746 KOps/s 54.0500 KOps/s $\color{#35bf28}+4.67\%$
test_step_mdp_speed[True-True-False-False-False] 39.9750μs 11.3358μs 88.2160 KOps/s 83.5952 KOps/s $\textbf{\color{#35bf28}+5.53\%}$
test_step_mdp_speed[True-False-True-True-True] 75.3610μs 32.5052μs 30.7643 KOps/s 29.6534 KOps/s $\color{#35bf28}+3.75\%$
test_step_mdp_speed[True-False-True-True-False] 53.6510μs 21.0757μs 47.4480 KOps/s 45.6994 KOps/s $\color{#35bf28}+3.83\%$
test_step_mdp_speed[True-False-True-False-True] 46.6170μs 17.9008μs 55.8635 KOps/s 54.3400 KOps/s $\color{#35bf28}+2.80\%$
test_step_mdp_speed[True-False-True-False-False] 0.1368ms 11.2936μs 88.5460 KOps/s 84.2716 KOps/s $\textbf{\color{#35bf28}+5.07\%}$
test_step_mdp_speed[True-False-False-True-True] 0.1084ms 34.5934μs 28.9073 KOps/s 28.2140 KOps/s $\color{#35bf28}+2.46\%$
test_step_mdp_speed[True-False-False-True-False] 97.6690μs 22.5693μs 44.3080 KOps/s 42.0665 KOps/s $\textbf{\color{#35bf28}+5.33\%}$
test_step_mdp_speed[True-False-False-False-True] 0.6124ms 19.4454μs 51.4260 KOps/s 49.4767 KOps/s $\color{#35bf28}+3.94\%$
test_step_mdp_speed[True-False-False-False-False] 63.9400μs 13.1407μs 76.0992 KOps/s 73.3554 KOps/s $\color{#35bf28}+3.74\%$
test_step_mdp_speed[False-True-True-True-True] 97.4330μs 32.2027μs 31.0533 KOps/s 29.7348 KOps/s $\color{#35bf28}+4.43\%$
test_step_mdp_speed[False-True-True-True-False] 85.4510μs 20.9530μs 47.7258 KOps/s 46.4463 KOps/s $\color{#35bf28}+2.75\%$
test_step_mdp_speed[False-True-True-False-True] 82.6850μs 21.0834μs 47.4308 KOps/s 45.8838 KOps/s $\color{#35bf28}+3.37\%$
test_step_mdp_speed[False-True-True-False-False] 54.3820μs 13.2050μs 75.7288 KOps/s 74.3056 KOps/s $\color{#35bf28}+1.92\%$
test_step_mdp_speed[False-True-False-True-True] 98.0340μs 34.0744μs 29.3475 KOps/s 28.3485 KOps/s $\color{#35bf28}+3.52\%$
test_step_mdp_speed[False-True-False-True-False] 90.4000μs 22.8499μs 43.7639 KOps/s 42.0791 KOps/s $\color{#35bf28}+4.00\%$
test_step_mdp_speed[False-True-False-False-True] 2.7392ms 23.0507μs 43.3827 KOps/s 41.7767 KOps/s $\color{#35bf28}+3.84\%$
test_step_mdp_speed[False-True-False-False-False] 50.1950μs 15.1061μs 66.1983 KOps/s 64.5902 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[False-False-True-True-True] 89.1670μs 36.0900μs 27.7085 KOps/s 26.7372 KOps/s $\color{#35bf28}+3.63\%$
test_step_mdp_speed[False-False-True-True-False] 87.3740μs 24.6772μs 40.5232 KOps/s 38.3669 KOps/s $\textbf{\color{#35bf28}+5.62\%}$
test_step_mdp_speed[False-False-True-False-True] 86.6430μs 23.2428μs 43.0240 KOps/s 41.7204 KOps/s $\color{#35bf28}+3.12\%$
test_step_mdp_speed[False-False-True-False-False] 83.7370μs 14.9540μs 66.8717 KOps/s 63.9477 KOps/s $\color{#35bf28}+4.57\%$
test_step_mdp_speed[False-False-False-True-True] 80.7020μs 37.9238μs 26.3687 KOps/s 25.3902 KOps/s $\color{#35bf28}+3.85\%$
test_step_mdp_speed[False-False-False-True-False] 95.5890μs 26.7307μs 37.4102 KOps/s 35.6554 KOps/s $\color{#35bf28}+4.92\%$
test_step_mdp_speed[False-False-False-False-True] 71.4540μs 24.6069μs 40.6390 KOps/s 39.1626 KOps/s $\color{#35bf28}+3.77\%$
test_step_mdp_speed[False-False-False-False-False] 80.5310μs 16.8066μs 59.5003 KOps/s 57.2406 KOps/s $\color{#35bf28}+3.95\%$
test_values[generalized_advantage_estimate-True-True] 9.9645ms 9.7447ms 102.6200 Ops/s 100.6518 Ops/s $\color{#35bf28}+1.96\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.3723ms 34.1603ms 29.2738 Ops/s 27.0520 Ops/s $\textbf{\color{#35bf28}+8.21\%}$
test_values[td0_return_estimate-False-False] 0.2783ms 0.1999ms 5.0029 KOps/s 5.2009 KOps/s $\color{#d91a1a}-3.81\%$
test_values[td1_return_estimate-False-False] 27.3107ms 24.3358ms 41.0917 Ops/s 41.0761 Ops/s $\color{#35bf28}+0.04\%$
test_values[vec_td1_return_estimate-False-False] 36.0248ms 33.9074ms 29.4921 Ops/s 26.6919 Ops/s $\textbf{\color{#35bf28}+10.49\%}$
test_values[td_lambda_return_estimate-True-False] 47.3926ms 34.7363ms 28.7883 Ops/s 28.2955 Ops/s $\color{#35bf28}+1.74\%$
test_values[vec_td_lambda_return_estimate-True-False] 35.6661ms 33.8147ms 29.5729 Ops/s 26.9812 Ops/s $\textbf{\color{#35bf28}+9.61\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.7192ms 8.3851ms 119.2588 Ops/s 117.4082 Ops/s $\color{#35bf28}+1.58\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.4440ms 2.0228ms 494.3661 Ops/s 485.5384 Ops/s $\color{#35bf28}+1.82\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 1.7859ms 0.3588ms 2.7867 KOps/s 2.7497 KOps/s $\color{#35bf28}+1.35\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 46.4565ms 43.9533ms 22.7514 Ops/s 21.5745 Ops/s $\textbf{\color{#35bf28}+5.46\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.1684ms 3.2086ms 311.6666 Ops/s 309.0716 Ops/s $\color{#35bf28}+0.84\%$
test_dqn_speed[False-None] 6.2446ms 1.3673ms 731.3837 Ops/s 667.6242 Ops/s $\textbf{\color{#35bf28}+9.55\%}$
test_dqn_speed[False-backward] 1.9850ms 1.8448ms 542.0579 Ops/s 517.1914 Ops/s $\color{#35bf28}+4.81\%$
test_dqn_speed[True-None] 0.5855ms 0.4686ms 2.1340 KOps/s 2.0991 KOps/s $\color{#35bf28}+1.67\%$
test_dqn_speed[True-backward] 1.0216ms 0.9065ms 1.1031 KOps/s 1.0461 KOps/s $\textbf{\color{#35bf28}+5.45\%}$
test_dqn_speed[reduce-overhead-None] 0.6387ms 0.4740ms 2.1097 KOps/s 2.0628 KOps/s $\color{#35bf28}+2.27\%$
test_dqn_speed[reduce-overhead-backward] 0.9807ms 0.8974ms 1.1143 KOps/s 1.0915 KOps/s $\color{#35bf28}+2.09\%$
test_ddpg_speed[False-None] 3.8034ms 2.8956ms 345.3478 Ops/s 332.6856 Ops/s $\color{#35bf28}+3.81\%$
test_ddpg_speed[False-backward] 5.5001ms 4.1955ms 238.3495 Ops/s 226.4165 Ops/s $\textbf{\color{#35bf28}+5.27\%}$
test_ddpg_speed[True-None] 1.4935ms 1.0223ms 978.2267 Ops/s 963.7579 Ops/s $\color{#35bf28}+1.50\%$
test_ddpg_speed[True-backward] 2.0846ms 1.9601ms 510.1715 Ops/s 452.6570 Ops/s $\textbf{\color{#35bf28}+12.71\%}$
test_ddpg_speed[reduce-overhead-None] 1.2354ms 1.0089ms 991.1778 Ops/s 978.7418 Ops/s $\color{#35bf28}+1.27\%$
test_ddpg_speed[reduce-overhead-backward] 2.4521ms 1.9599ms 510.2308 Ops/s 491.5707 Ops/s $\color{#35bf28}+3.80\%$
test_sac_speed[False-None] 9.0913ms 8.0924ms 123.5728 Ops/s 108.1776 Ops/s $\textbf{\color{#35bf28}+14.23\%}$
test_sac_speed[False-backward] 11.4831ms 10.9157ms 91.6114 Ops/s 80.0415 Ops/s $\textbf{\color{#35bf28}+14.45\%}$
test_sac_speed[True-None] 2.1760ms 1.8739ms 533.6449 Ops/s 522.7900 Ops/s $\color{#35bf28}+2.08\%$
test_sac_speed[True-backward] 3.6877ms 3.6455ms 274.3134 Ops/s 247.2640 Ops/s $\textbf{\color{#35bf28}+10.94\%}$
test_sac_speed[reduce-overhead-None] 2.5375ms 1.8835ms 530.9198 Ops/s 457.7223 Ops/s $\textbf{\color{#35bf28}+15.99\%}$
test_sac_speed[reduce-overhead-backward] 4.2827ms 4.0369ms 247.7134 Ops/s 233.2938 Ops/s $\textbf{\color{#35bf28}+6.18\%}$
test_redq_speed[False-None] 15.4633ms 13.2037ms 75.7364 Ops/s 71.5423 Ops/s $\textbf{\color{#35bf28}+5.86\%}$
test_redq_speed[False-backward] 30.2788ms 23.2580ms 42.9959 Ops/s 41.9321 Ops/s $\color{#35bf28}+2.54\%$
test_redq_speed[True-None] 6.5996ms 5.5866ms 179.0000 Ops/s 166.5378 Ops/s $\textbf{\color{#35bf28}+7.48\%}$
test_redq_speed[True-backward] 14.2533ms 12.9540ms 77.1965 Ops/s 74.3891 Ops/s $\color{#35bf28}+3.77\%$
test_redq_speed[reduce-overhead-None] 8.1880ms 7.0717ms 141.4086 Ops/s 165.0809 Ops/s $\textbf{\color{#d91a1a}-14.34\%}$
test_redq_speed[reduce-overhead-backward] 18.1321ms 13.4294ms 74.4633 Ops/s 74.0750 Ops/s $\color{#35bf28}+0.52\%$
test_redq_deprec_speed[False-None] 15.4091ms 13.8607ms 72.1464 Ops/s 68.0784 Ops/s $\textbf{\color{#35bf28}+5.98\%}$
test_redq_deprec_speed[False-backward] 21.3554ms 19.8659ms 50.3376 Ops/s 47.6559 Ops/s $\textbf{\color{#35bf28}+5.63\%}$
test_redq_deprec_speed[True-None] 4.9882ms 4.0341ms 247.8865 Ops/s 218.6160 Ops/s $\textbf{\color{#35bf28}+13.39\%}$
test_redq_deprec_speed[True-backward] 12.5508ms 11.2624ms 88.7911 Ops/s 102.9786 Ops/s $\textbf{\color{#d91a1a}-13.78\%}$
test_redq_deprec_speed[reduce-overhead-None] 6.2217ms 5.5153ms 181.3125 Ops/s 207.9626 Ops/s $\textbf{\color{#d91a1a}-12.81\%}$
test_redq_deprec_speed[reduce-overhead-backward] 11.9386ms 11.3211ms 88.3306 Ops/s 101.0481 Ops/s $\textbf{\color{#d91a1a}-12.59\%}$
test_td3_speed[False-None] 13.4810ms 10.8013ms 92.5811 Ops/s 106.0974 Ops/s $\textbf{\color{#d91a1a}-12.74\%}$
test_td3_speed[False-backward] 17.4484ms 14.4783ms 69.0691 Ops/s 80.3913 Ops/s $\textbf{\color{#d91a1a}-14.08\%}$
test_td3_speed[True-None] 4.2792ms 3.0504ms 327.8309 Ops/s 461.2330 Ops/s $\textbf{\color{#d91a1a}-28.92\%}$
test_td3_speed[True-backward] 5.5373ms 5.1383ms 194.6185 Ops/s 224.3424 Ops/s $\textbf{\color{#d91a1a}-13.25\%}$
test_td3_speed[reduce-overhead-None] 3.5651ms 3.0532ms 327.5279 Ops/s 498.6412 Ops/s $\textbf{\color{#d91a1a}-34.32\%}$
test_td3_speed[reduce-overhead-backward] 5.3836ms 5.1196ms 195.3290 Ops/s 231.4346 Ops/s $\textbf{\color{#d91a1a}-15.60\%}$
test_cql_speed[False-None] 48.6023ms 44.2384ms 22.6048 Ops/s 25.6398 Ops/s $\textbf{\color{#d91a1a}-11.84\%}$
test_cql_speed[False-backward] 57.1356ms 54.7956ms 18.2496 Ops/s 20.2841 Ops/s $\textbf{\color{#d91a1a}-10.03\%}$
test_cql_speed[True-None] 20.6271ms 17.9643ms 55.6658 Ops/s 60.6341 Ops/s $\textbf{\color{#d91a1a}-8.19\%}$
test_cql_speed[True-backward] 31.1022ms 27.9555ms 35.7712 Ops/s 41.6749 Ops/s $\textbf{\color{#d91a1a}-14.17\%}$
test_cql_speed[reduce-overhead-None] 19.0904ms 17.9248ms 55.7887 Ops/s 59.9465 Ops/s $\textbf{\color{#d91a1a}-6.94\%}$
test_cql_speed[reduce-overhead-backward] 28.4389ms 27.1356ms 36.8520 Ops/s 40.8813 Ops/s $\textbf{\color{#d91a1a}-9.86\%}$
test_a2c_speed[False-None] 10.5048ms 8.7463ms 114.3346 Ops/s 130.8572 Ops/s $\textbf{\color{#d91a1a}-12.63\%}$
test_a2c_speed[False-backward] 20.2101ms 18.5037ms 54.0432 Ops/s 64.6874 Ops/s $\textbf{\color{#d91a1a}-16.45\%}$
test_a2c_speed[True-None] 5.3277ms 4.5433ms 220.1036 Ops/s 267.3075 Ops/s $\textbf{\color{#d91a1a}-17.66\%}$
test_a2c_speed[True-backward] 13.4439ms 12.6755ms 78.8921 Ops/s 89.3153 Ops/s $\textbf{\color{#d91a1a}-11.67\%}$
test_a2c_speed[reduce-overhead-None] 5.1530ms 4.4527ms 224.5834 Ops/s 264.7370 Ops/s $\textbf{\color{#d91a1a}-15.17\%}$
test_a2c_speed[reduce-overhead-backward] 13.9537ms 12.7846ms 78.2191 Ops/s 91.3866 Ops/s $\textbf{\color{#d91a1a}-14.41\%}$
test_ppo_speed[False-None] 11.2895ms 9.7925ms 102.1193 Ops/s 120.4795 Ops/s $\textbf{\color{#d91a1a}-15.24\%}$
test_ppo_speed[False-backward] 31.8533ms 19.5606ms 51.1233 Ops/s 62.2244 Ops/s $\textbf{\color{#d91a1a}-17.84\%}$
test_ppo_speed[True-None] 5.9677ms 4.9810ms 200.7641 Ops/s 238.6944 Ops/s $\textbf{\color{#d91a1a}-15.89\%}$
test_ppo_speed[True-backward] 13.4147ms 12.6967ms 78.7609 Ops/s 92.5198 Ops/s $\textbf{\color{#d91a1a}-14.87\%}$
test_ppo_speed[reduce-overhead-None] 5.7563ms 4.9051ms 203.8690 Ops/s 260.8226 Ops/s $\textbf{\color{#d91a1a}-21.84\%}$
test_ppo_speed[reduce-overhead-backward] 13.3298ms 12.4517ms 80.3102 Ops/s 94.9575 Ops/s $\textbf{\color{#d91a1a}-15.43\%}$
test_reinforce_speed[False-None] 9.4257ms 8.2224ms 121.6196 Ops/s 138.9074 Ops/s $\textbf{\color{#d91a1a}-12.45\%}$
test_reinforce_speed[False-backward] 13.7511ms 12.5908ms 79.4230 Ops/s 94.1627 Ops/s $\textbf{\color{#d91a1a}-15.65\%}$
test_reinforce_speed[True-None] 4.2642ms 3.7815ms 264.4455 Ops/s 358.4876 Ops/s $\textbf{\color{#d91a1a}-26.23\%}$
test_reinforce_speed[True-backward] 12.9783ms 11.7113ms 85.3875 Ops/s 108.2110 Ops/s $\textbf{\color{#d91a1a}-21.09\%}$
test_reinforce_speed[reduce-overhead-None] 4.5891ms 3.9043ms 256.1289 Ops/s 349.9043 Ops/s $\textbf{\color{#d91a1a}-26.80\%}$
test_reinforce_speed[reduce-overhead-backward] 12.4043ms 11.3892ms 87.8025 Ops/s 108.5160 Ops/s $\textbf{\color{#d91a1a}-19.09\%}$
test_iql_speed[False-None] 38.9308ms 36.8307ms 27.1513 Ops/s 28.7945 Ops/s $\textbf{\color{#d91a1a}-5.71\%}$
test_iql_speed[False-backward] 55.2132ms 52.4319ms 19.0724 Ops/s 20.9888 Ops/s $\textbf{\color{#d91a1a}-9.13\%}$
test_iql_speed[True-None] 13.4485ms 12.3310ms 81.0966 Ops/s 87.3654 Ops/s $\textbf{\color{#d91a1a}-7.18\%}$
test_iql_speed[True-backward] 27.0574ms 25.8228ms 38.7254 Ops/s 42.5001 Ops/s $\textbf{\color{#d91a1a}-8.88\%}$
test_iql_speed[reduce-overhead-None] 13.4507ms 12.4187ms 80.5235 Ops/s 87.2714 Ops/s $\textbf{\color{#d91a1a}-7.73\%}$
test_iql_speed[reduce-overhead-backward] 26.3334ms 25.5674ms 39.1124 Ops/s 41.9993 Ops/s $\textbf{\color{#d91a1a}-6.87\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.6533ms 6.5662ms 152.2950 Ops/s 182.2617 Ops/s $\textbf{\color{#d91a1a}-16.44\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8748ms 0.5390ms 1.8552 KOps/s 1.9228 KOps/s $\color{#d91a1a}-3.52\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8402ms 0.5125ms 1.9514 KOps/s 2.0445 KOps/s $\color{#d91a1a}-4.55\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.5605ms 6.5131ms 153.5357 Ops/s 189.6084 Ops/s $\textbf{\color{#d91a1a}-19.02\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.3437ms 0.5426ms 1.8431 KOps/s 1.9740 KOps/s $\textbf{\color{#d91a1a}-6.63\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8598ms 0.5059ms 1.9766 KOps/s 2.0646 KOps/s $\color{#d91a1a}-4.26\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.4388ms 1.7611ms 567.8396 Ops/s 606.8627 Ops/s $\textbf{\color{#d91a1a}-6.43\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.5725ms 1.7113ms 584.3613 Ops/s 628.4437 Ops/s $\textbf{\color{#d91a1a}-7.01\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.6018ms 6.8420ms 146.1571 Ops/s 181.6562 Ops/s $\textbf{\color{#d91a1a}-19.54\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.8789ms 0.6925ms 1.4441 KOps/s 1.5204 KOps/s $\textbf{\color{#d91a1a}-5.02\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9548ms 0.6559ms 1.5247 KOps/s 1.5689 KOps/s $\color{#d91a1a}-2.82\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 11.2510ms 6.5143ms 153.5086 Ops/s 189.4154 Ops/s $\textbf{\color{#d91a1a}-18.96\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 2.1991ms 0.5500ms 1.8182 KOps/s 1.9487 KOps/s $\textbf{\color{#d91a1a}-6.69\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7468ms 0.5220ms 1.9159 KOps/s 2.0406 KOps/s $\textbf{\color{#d91a1a}-6.11\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 9.2009ms 6.3105ms 158.4664 Ops/s 185.4683 Ops/s $\textbf{\color{#d91a1a}-14.56\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.9003ms 0.5527ms 1.8094 KOps/s 1.9622 KOps/s $\textbf{\color{#d91a1a}-7.79\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6920ms 0.5067ms 1.9737 KOps/s 2.0594 KOps/s $\color{#d91a1a}-4.16\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.3408ms 6.7686ms 147.7400 Ops/s 172.6553 Ops/s $\textbf{\color{#d91a1a}-14.43\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 5.6724ms 0.7213ms 1.3863 KOps/s 1.5136 KOps/s $\textbf{\color{#d91a1a}-8.41\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9473ms 0.6616ms 1.5116 KOps/s 1.5285 KOps/s $\color{#d91a1a}-1.11\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 10.8635ms 6.7548ms 148.0423 Ops/s 206.5483 Ops/s $\textbf{\color{#d91a1a}-28.33\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 12.3740ms 3.0734ms 325.3692 Ops/s 415.8388 Ops/s $\textbf{\color{#d91a1a}-21.76\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.8632ms 1.5233ms 656.4659 Ops/s 758.6844 Ops/s $\textbf{\color{#d91a1a}-13.47\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.6427s 19.9219ms 50.1960 Ops/s 201.5999 Ops/s $\textbf{\color{#d91a1a}-75.10\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.6428ms 3.0479ms 328.0955 Ops/s 404.4724 Ops/s $\textbf{\color{#d91a1a}-18.88\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.5891ms 1.6625ms 601.5045 Ops/s 744.8158 Ops/s $\textbf{\color{#d91a1a}-19.24\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 12.0304ms 7.6049ms 131.4937 Ops/s 196.8550 Ops/s $\textbf{\color{#d91a1a}-33.20\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 12.6606ms 3.4124ms 293.0521 Ops/s 389.4981 Ops/s $\textbf{\color{#d91a1a}-24.76\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.9830ms 1.8270ms 547.3502 Ops/s 636.7671 Ops/s $\textbf{\color{#d91a1a}-14.04\%}$

@vmoens vmoens added the bug Something isn't working label Oct 21, 2024
@vmoens vmoens merged commit 9f6c21f into main Oct 21, 2024
73 of 80 checks passed
@vmoens vmoens deleted the fix-dump-no-replacement branch October 21, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SamplerWithoutReplacement.dumps failed
2 participants
@vmoens @facebook-github-bot