Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Avoid reshape(-1) for inputs to objectives modules #2494

Merged
merged 3 commits into from
Oct 15, 2024
Merged

[BugFix] Avoid reshape(-1) for inputs to objectives modules #2494

merged 3 commits into from
Oct 15, 2024

Conversation

kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Oct 15, 2024 •
edited by vmoens
Loading

Description

Avoids flattening the inputs of objectives modules.

NOTE: There is one remaining module that still flattens the input, DreamerActorLoss. This one seems to be more complicated and should be fixed in a follow-up PR.

Motivation and Context

Close #2338

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

cc @matteobettini

@kurtamohler kurtamohler requested a review from vmoens October 15, 2024 02:16
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2494

Note: Links to docs will display an error until the docs builds have been completed.

❌ 21 New Failures, 4 Unrelated Failures

As of commit 3c53e10 with merge base ec04c35 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens
vmoens approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, lots clearer now

@matteobettini
Copy link
Contributor

Love this!

Thanks a mil

@vmoens vmoens merged commit 4736fac into pytorch:main Oct 15, 2024
5 of 8 checks passed
@kurtamohler kurtamohler mentioned this pull request Oct 15, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Objectives
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SAC Loss reshapes tensordict causing loss of time dimension
4 participants
@kurtamohler @matteobettini @vmoens @facebook-github-bot