Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix support for MiniGrid envs #2416

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[BugFix] Fix support for MiniGrid envs #2416

merged 1 commit into from
Sep 4, 2024

Conversation

kurtamohler
Copy link
Collaborator

Description

Support MiniGrid gymnasium environments.

Motivation and Context

close #1467

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • I have updated the tests accordingly (required for a bug fix or a new feature).

@kurtamohler kurtamohler requested a review from vmoens September 3, 2024 22:15
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2416

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 15 Unrelated Failures

As of commit dfa33cc with merge base 5a81930 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2024
@kurtamohler kurtamohler added the Environments Adds or modifies an environment wrapper label Sep 3, 2024
vmoens
vmoens approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens merged commit 60cd104 into pytorch:main Sep 4, 2024
56 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] torchrl doesn't support minigrid gymnasium environments
3 participants
@kurtamohler @vmoens @facebook-github-bot