Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Dict specs in vmas #2415

Merged
merged 3 commits into from
Sep 4, 2024
Merged

[Feature] Dict specs in vmas #2415

merged 3 commits into from
Sep 4, 2024

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Sep 3, 2024 •
edited
Loading

I had this feature in my fork for a long time and di not realize it was not in main.

This allows dictionaries as observations in VMAS

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2415

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 7 Unrelated Failures

As of commit ed585a8 with merge base 5a81930 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2024
vmoens
vmoens approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx! Just a nit

torchrl/envs/libs/vmas.py Outdated
elif isinstance(spec, gym_spaces.Dict):
spec_out = {}
for k in spec.keys():
key = k
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. I have no idea why that was in my code. I hope it was not there for some dark magic that i forgot about

@vmoens vmoens added the enhancement New feature or request label Sep 4, 2024
@matteobettini
Copy link
Contributor Author

let's activate the vmas tests for this

@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Sep 4, 2024
@vmoens vmoens merged commit df4fa78 into pytorch:main Sep 4, 2024
64 of 69 checks passed
@matteobettini matteobettini deleted the vmas_dict branch September 4, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot