Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Faster CatFrames.unfolding with padding="same" #2407

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[Performance] Faster CatFrames.unfolding with padding="same" #2407

merged 1 commit into from
Sep 2, 2024

Conversation

kurtamohler
Copy link
Collaborator

Description

Improves the performance of CatFrames.unfolding with padding="same". Running the performance measurement script in the issue description of #2406 shows a speedup of ~70x compared to the previous implementation:

WITHOUT CATFRAMES
Sampling took 0.0016054896002363724 seconds.
WITH CATFRAMES
Sampling took 0.003015774066928619 seconds.

Motivation and Context

close #2406

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2407

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 8 Unrelated Failures

As of commit 86f4348 with merge base e82a69f (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2024
vmoens
vmoens approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, I'm so grateful for this!
Can you just comment on the 0: indexing?

torchrl/envs/transforms/transforms.py Outdated
for sample_idx, num_repeats in enumerate(num_repeats_per_sample):
if num_repeats > 0:
res_slice = res_flat_series_flat_batch[sample_idx]
res_slice[:, 0:num_repeats] = res_slice[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the 0: here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, :num_repeats will work, without the 0. I'll update it

@kurtamohler kurtamohler force-pushed the CatFrames-unfolding-speedup-0 branch from 862ea28 to 86f4348 Compare September 2, 2024 00:16
@vmoens vmoens added the performance Performance issue or suggestion for improvement label Sep 2, 2024
@vmoens vmoens merged commit d4842fe into pytorch:main Sep 2, 2024
60 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. performance Performance issue or suggestion for improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CatFrames with padding="same" is slow
3 participants
@kurtamohler @vmoens @facebook-github-bot