Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix get-related errors #2361

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[BugFix] Fix get-related errors #2361

merged 1 commit into from
Aug 5, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Aug 5, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2361

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Cancelled Job, 16 Unrelated Failures

As of commit a160afe with merge base 35a1c5b (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}6$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 59.4583ms 59.0328ms 16.9397 Ops/s 16.9324 Ops/s $\color{#35bf28}+0.04\%$
test_sync 31.7812ms 31.2960ms 31.9530 Ops/s 30.7277 Ops/s $\color{#35bf28}+3.99\%$
test_async 55.9041ms 30.2410ms 33.0677 Ops/s 32.5433 Ops/s $\color{#35bf28}+1.61\%$
test_simple 0.5011s 0.4252s 2.3520 Ops/s 2.3634 Ops/s $\color{#d91a1a}-0.48\%$
test_transformed 0.6507s 0.5860s 1.7065 Ops/s 1.7180 Ops/s $\color{#d91a1a}-0.67\%$
test_serial 1.3403s 1.2789s 0.7819 Ops/s 0.7826 Ops/s $\color{#d91a1a}-0.08\%$
test_parallel 1.1729s 1.1014s 0.9080 Ops/s 0.9066 Ops/s $\color{#35bf28}+0.15\%$
test_step_mdp_speed[True-True-True-True-True] 0.3633ms 23.9084μs 41.8262 KOps/s 39.2072 KOps/s $\textbf{\color{#35bf28}+6.68\%}$
test_step_mdp_speed[True-True-True-True-False] 43.6720μs 14.2065μs 70.3905 KOps/s 67.6434 KOps/s $\color{#35bf28}+4.06\%$
test_step_mdp_speed[True-True-True-False-True] 48.5310μs 13.9444μs 71.7136 KOps/s 68.2632 KOps/s $\textbf{\color{#35bf28}+5.05\%}$
test_step_mdp_speed[True-True-True-False-False] 33.4220μs 8.2627μs 121.0254 KOps/s 116.7090 KOps/s $\color{#35bf28}+3.70\%$
test_step_mdp_speed[True-True-False-True-True] 59.5410μs 25.6949μs 38.9182 KOps/s 37.1544 KOps/s $\color{#35bf28}+4.75\%$
test_step_mdp_speed[True-True-False-True-False] 40.7860μs 15.6048μs 64.0829 KOps/s 61.8506 KOps/s $\color{#35bf28}+3.61\%$
test_step_mdp_speed[True-True-False-False-True] 41.3770μs 15.4432μs 64.7533 KOps/s 62.5735 KOps/s $\color{#35bf28}+3.48\%$
test_step_mdp_speed[True-True-False-False-False] 33.7830μs 9.6979μs 103.1152 KOps/s 101.2611 KOps/s $\color{#35bf28}+1.83\%$
test_step_mdp_speed[True-False-True-True-True] 70.9220μs 27.4853μs 36.3830 KOps/s 35.4539 KOps/s $\color{#35bf28}+2.62\%$
test_step_mdp_speed[True-False-True-True-False] 44.4130μs 17.0957μs 58.4942 KOps/s 56.5827 KOps/s $\color{#35bf28}+3.38\%$
test_step_mdp_speed[True-False-True-False-True] 55.4540μs 15.5675μs 64.2362 KOps/s 62.7920 KOps/s $\color{#35bf28}+2.30\%$
test_step_mdp_speed[True-False-True-False-False] 31.7890μs 9.6908μs 103.1908 KOps/s 100.3809 KOps/s $\color{#35bf28}+2.80\%$
test_step_mdp_speed[True-False-False-True-True] 62.6470μs 28.5609μs 35.0129 KOps/s 33.8461 KOps/s $\color{#35bf28}+3.45\%$
test_step_mdp_speed[True-False-False-True-False] 47.9690μs 18.6204μs 53.7045 KOps/s 52.2539 KOps/s $\color{#35bf28}+2.78\%$
test_step_mdp_speed[True-False-False-False-True] 49.2220μs 16.5647μs 60.3692 KOps/s 58.1984 KOps/s $\color{#35bf28}+3.73\%$
test_step_mdp_speed[True-False-False-False-False] 46.0260μs 10.9840μs 91.0412 KOps/s 88.4955 KOps/s $\color{#35bf28}+2.88\%$
test_step_mdp_speed[False-True-True-True-True] 71.8640μs 27.3517μs 36.5607 KOps/s 35.3776 KOps/s $\color{#35bf28}+3.34\%$
test_step_mdp_speed[False-True-True-True-False] 46.7880μs 17.3123μs 57.7623 KOps/s 56.5100 KOps/s $\color{#35bf28}+2.22\%$
test_step_mdp_speed[False-True-True-False-True] 64.3700μs 18.2905μs 54.6731 KOps/s 52.6708 KOps/s $\color{#35bf28}+3.80\%$
test_step_mdp_speed[False-True-True-False-False] 44.4930μs 10.7948μs 92.6374 KOps/s 89.1559 KOps/s $\color{#35bf28}+3.90\%$
test_step_mdp_speed[False-True-False-True-True] 64.1690μs 28.7180μs 34.8213 KOps/s 33.5863 KOps/s $\color{#35bf28}+3.68\%$
test_step_mdp_speed[False-True-False-True-False] 47.9090μs 18.7192μs 53.4210 KOps/s 52.0712 KOps/s $\color{#35bf28}+2.59\%$
test_step_mdp_speed[False-True-False-False-True] 60.3430μs 19.2105μs 52.0548 KOps/s 49.7723 KOps/s $\color{#35bf28}+4.59\%$
test_step_mdp_speed[False-True-False-False-False] 39.6340μs 12.2875μs 81.3837 KOps/s 79.0175 KOps/s $\color{#35bf28}+2.99\%$
test_step_mdp_speed[False-False-True-True-True] 3.3948ms 30.0719μs 33.2537 KOps/s 32.3452 KOps/s $\color{#35bf28}+2.81\%$
test_step_mdp_speed[False-False-True-True-False] 57.3970μs 20.2377μs 49.4127 KOps/s 48.3426 KOps/s $\color{#35bf28}+2.21\%$
test_step_mdp_speed[False-False-True-False-True] 55.9840μs 19.6239μs 50.9583 KOps/s 50.6915 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[False-False-True-False-False] 40.6760μs 12.3070μs 81.2542 KOps/s 79.3562 KOps/s $\color{#35bf28}+2.39\%$
test_step_mdp_speed[False-False-False-True-True] 61.2050μs 31.4980μs 31.7481 KOps/s 31.2519 KOps/s $\color{#35bf28}+1.59\%$
test_step_mdp_speed[False-False-False-True-False] 59.6210μs 21.4453μs 46.6303 KOps/s 45.5743 KOps/s $\color{#35bf28}+2.32\%$
test_step_mdp_speed[False-False-False-False-True] 62.6170μs 20.2169μs 49.4635 KOps/s 47.7742 KOps/s $\color{#35bf28}+3.54\%$
test_step_mdp_speed[False-False-False-False-False] 39.8140μs 13.4803μs 74.1822 KOps/s 72.2749 KOps/s $\color{#35bf28}+2.64\%$
test_values[generalized_advantage_estimate-True-True] 10.0565ms 9.4424ms 105.9055 Ops/s 106.8741 Ops/s $\color{#d91a1a}-0.91\%$
test_values[vec_generalized_advantage_estimate-True-True] 49.6552ms 40.1784ms 24.8890 Ops/s 29.7151 Ops/s $\textbf{\color{#d91a1a}-16.24\%}$
test_values[td0_return_estimate-False-False] 0.2256ms 0.1722ms 5.8089 KOps/s 5.4653 KOps/s $\textbf{\color{#35bf28}+6.29\%}$
test_values[td1_return_estimate-False-False] 26.7655ms 23.4354ms 42.6705 Ops/s 42.9867 Ops/s $\color{#d91a1a}-0.74\%$
test_values[vec_td1_return_estimate-False-False] 39.5458ms 36.0576ms 27.7334 Ops/s 29.8064 Ops/s $\textbf{\color{#d91a1a}-6.95\%}$
test_values[td_lambda_return_estimate-True-False] 37.3105ms 33.7890ms 29.5955 Ops/s 29.7795 Ops/s $\color{#d91a1a}-0.62\%$
test_values[vec_td_lambda_return_estimate-True-False] 37.7639ms 36.0024ms 27.7759 Ops/s 29.9152 Ops/s $\textbf{\color{#d91a1a}-7.15\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.0711ms 8.3456ms 119.8240 Ops/s 123.4162 Ops/s $\color{#d91a1a}-2.91\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.5864ms 2.0852ms 479.5719 Ops/s 488.2703 Ops/s $\color{#d91a1a}-1.78\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5662ms 0.3599ms 2.7782 KOps/s 2.7889 KOps/s $\color{#d91a1a}-0.39\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 52.2904ms 47.5616ms 21.0254 Ops/s 20.6695 Ops/s $\color{#35bf28}+1.72\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.2549ms 3.0716ms 325.5621 Ops/s 327.8319 Ops/s $\color{#d91a1a}-0.69\%$
test_dqn_speed 6.2815ms 1.3229ms 755.8878 Ops/s 763.9490 Ops/s $\color{#d91a1a}-1.06\%$
test_ddpg_speed 3.6254ms 2.7548ms 362.9998 Ops/s 366.8047 Ops/s $\color{#d91a1a}-1.04\%$
test_sac_speed 8.8380ms 8.1676ms 122.4355 Ops/s 122.8553 Ops/s $\color{#d91a1a}-0.34\%$
test_redq_speed 14.0271ms 12.6581ms 79.0008 Ops/s 76.9486 Ops/s $\color{#35bf28}+2.67\%$
test_redq_deprec_speed 13.5259ms 12.7080ms 78.6908 Ops/s 75.4651 Ops/s $\color{#35bf28}+4.27\%$
test_td3_speed 8.1170ms 7.8862ms 126.8031 Ops/s 126.3847 Ops/s $\color{#35bf28}+0.33\%$
test_cql_speed 37.8721ms 35.4886ms 28.1781 Ops/s 28.3379 Ops/s $\color{#d91a1a}-0.56\%$
test_a2c_speed 8.3005ms 7.2597ms 137.7458 Ops/s 137.7572 Ops/s $-0.01\%$
test_ppo_speed 8.2961ms 7.5212ms 132.9579 Ops/s 133.0096 Ops/s $\color{#d91a1a}-0.04\%$
test_reinforce_speed 7.8348ms 6.4633ms 154.7202 Ops/s 155.9267 Ops/s $\color{#d91a1a}-0.77\%$
test_iql_speed 33.3205ms 31.8844ms 31.3633 Ops/s 31.3575 Ops/s $\color{#35bf28}+0.02\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.0038ms 4.7621ms 209.9918 Ops/s 207.5295 Ops/s $\color{#35bf28}+1.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.8142ms 0.4771ms 2.0959 KOps/s 2.0996 KOps/s $\color{#d91a1a}-0.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6905ms 0.4520ms 2.2122 KOps/s 2.2108 KOps/s $\color{#35bf28}+0.06\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.5849ms 4.7449ms 210.7515 Ops/s 211.8707 Ops/s $\color{#d91a1a}-0.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.4111ms 0.4734ms 2.1122 KOps/s 1.8265 KOps/s $\textbf{\color{#35bf28}+15.64\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6729ms 0.4516ms 2.2143 KOps/s 2.2360 KOps/s $\color{#d91a1a}-0.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.8376ms 1.6819ms 594.5751 Ops/s 591.2249 Ops/s $\color{#35bf28}+0.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.2955ms 1.5999ms 625.0254 Ops/s 626.6044 Ops/s $\color{#d91a1a}-0.25\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.3032ms 4.8998ms 204.0883 Ops/s 200.9930 Ops/s $\color{#35bf28}+1.54\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9785ms 0.6162ms 1.6229 KOps/s 1.6267 KOps/s $\color{#d91a1a}-0.23\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7991ms 0.5866ms 1.7047 KOps/s 1.7139 KOps/s $\color{#d91a1a}-0.53\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.5280ms 4.7797ms 209.2202 Ops/s 207.0868 Ops/s $\color{#35bf28}+1.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3741ms 0.4789ms 2.0883 KOps/s 2.0990 KOps/s $\color{#d91a1a}-0.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6637ms 0.4552ms 2.1971 KOps/s 2.1911 KOps/s $\color{#35bf28}+0.27\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.2106ms 4.7227ms 211.7415 Ops/s 208.6766 Ops/s $\color{#35bf28}+1.47\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7202ms 0.4718ms 2.1194 KOps/s 2.1207 KOps/s $\color{#d91a1a}-0.06\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6382ms 0.4567ms 2.1898 KOps/s 2.2115 KOps/s $\color{#d91a1a}-0.98\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.6125ms 4.8788ms 204.9697 Ops/s 197.4206 Ops/s $\color{#35bf28}+3.82\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.3816ms 0.6171ms 1.6206 KOps/s 1.6116 KOps/s $\color{#35bf28}+0.56\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1197s 0.7433ms 1.3453 KOps/s 1.6932 KOps/s $\textbf{\color{#d91a1a}-20.55\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1022s 5.7244ms 174.6922 Ops/s 164.8907 Ops/s $\textbf{\color{#35bf28}+5.94\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.7151ms 12.8563ms 77.7826 Ops/s 78.1197 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.6028ms 1.1095ms 901.3439 Ops/s 906.5601 Ops/s $\color{#d91a1a}-0.58\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1095s 5.8998ms 169.4972 Ops/s 170.9414 Ops/s $\color{#d91a1a}-0.84\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.7871ms 12.7683ms 78.3192 Ops/s 77.6640 Ops/s $\color{#35bf28}+0.84\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.8962ms 1.1478ms 871.2291 Ops/s 923.9249 Ops/s $\textbf{\color{#d91a1a}-5.70\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1108s 6.0715ms 164.7032 Ops/s 124.4089 Ops/s $\textbf{\color{#35bf28}+32.39\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 0.1131s 14.9277ms 66.9894 Ops/s 77.4978 Ops/s $\textbf{\color{#d91a1a}-13.56\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.7560ms 1.2536ms 797.7071 Ops/s 775.0300 Ops/s $\color{#35bf28}+2.93\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1057s 0.1054s 9.4916 Ops/s 9.2039 Ops/s $\color{#35bf28}+3.13\%$
test_sync 95.0886ms 90.0487ms 11.1051 Ops/s 10.6290 Ops/s $\color{#35bf28}+4.48\%$
test_async 0.1719s 83.5359ms 11.9709 Ops/s 11.7310 Ops/s $\color{#35bf28}+2.04\%$
test_single_pixels 0.1158s 0.1155s 8.6599 Ops/s 8.6147 Ops/s $\color{#35bf28}+0.52\%$
test_sync_pixels 76.8905ms 75.4441ms 13.2548 Ops/s 13.0375 Ops/s $\color{#35bf28}+1.67\%$
test_async_pixels 0.1472s 70.6684ms 14.1506 Ops/s 14.0586 Ops/s $\color{#35bf28}+0.65\%$
test_simple 0.7532s 0.7523s 1.3292 Ops/s 1.2865 Ops/s $\color{#35bf28}+3.32\%$
test_transformed 1.0742s 1.0025s 0.9975 Ops/s 1.0076 Ops/s $\color{#d91a1a}-1.00\%$
test_serial 2.2433s 2.1736s 0.4601 Ops/s 0.4606 Ops/s $\color{#d91a1a}-0.12\%$
test_parallel 1.9483s 1.8841s 0.5308 Ops/s 0.5263 Ops/s $\color{#35bf28}+0.86\%$
test_step_mdp_speed[True-True-True-True-True] 0.1229ms 36.3186μs 27.5341 KOps/s 27.5722 KOps/s $\color{#d91a1a}-0.14\%$
test_step_mdp_speed[True-True-True-True-False] 46.6020μs 20.7262μs 48.2480 KOps/s 48.0835 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[True-True-True-False-True] 70.6120μs 21.1371μs 47.3101 KOps/s 49.0166 KOps/s $\color{#d91a1a}-3.48\%$
test_step_mdp_speed[True-True-True-False-False] 33.0400μs 11.7378μs 85.1949 KOps/s 84.4146 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[True-True-False-True-True] 0.1175ms 38.0214μs 26.3010 KOps/s 26.5132 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[True-True-False-True-False] 0.2078ms 22.5749μs 44.2970 KOps/s 44.2418 KOps/s $\color{#35bf28}+0.12\%$
test_step_mdp_speed[True-True-False-False-True] 49.1110μs 22.4114μs 44.6202 KOps/s 44.4110 KOps/s $\color{#35bf28}+0.47\%$
test_step_mdp_speed[True-True-False-False-False] 35.4010μs 13.8427μs 72.2404 KOps/s 71.1696 KOps/s $\color{#35bf28}+1.50\%$
test_step_mdp_speed[True-False-True-True-True] 84.1220μs 40.6037μs 24.6283 KOps/s 24.8343 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[True-False-True-True-False] 48.1710μs 24.8590μs 40.2269 KOps/s 39.6734 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[True-False-True-False-True] 0.1002ms 22.5022μs 44.4402 KOps/s 43.8817 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[True-False-True-False-False] 31.9920μs 13.7565μs 72.6929 KOps/s 71.5523 KOps/s $\color{#35bf28}+1.59\%$
test_step_mdp_speed[True-False-False-True-True] 89.0120μs 42.0151μs 23.8009 KOps/s 23.7053 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[True-False-False-True-False] 50.2620μs 27.1007μs 36.8994 KOps/s 37.0815 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[True-False-False-False-True] 55.1210μs 24.4569μs 40.8883 KOps/s 40.4727 KOps/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[True-False-False-False-False] 51.7510μs 15.8280μs 63.1791 KOps/s 62.7148 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-True-True-True-True] 74.3010μs 40.0968μs 24.9396 KOps/s 24.9463 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[False-True-True-True-False] 48.6410μs 24.7250μs 40.4449 KOps/s 40.1565 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[False-True-True-False-True] 68.0410μs 26.8320μs 37.2690 KOps/s 38.0899 KOps/s $\color{#d91a1a}-2.16\%$
test_step_mdp_speed[False-True-True-False-False] 48.4210μs 16.0707μs 62.2252 KOps/s 63.2578 KOps/s $\color{#d91a1a}-1.63\%$
test_step_mdp_speed[False-True-False-True-True] 75.0620μs 42.7895μs 23.3702 KOps/s 23.8754 KOps/s $\color{#d91a1a}-2.12\%$
test_step_mdp_speed[False-True-False-True-False] 57.4310μs 27.2296μs 36.7247 KOps/s 37.4164 KOps/s $\color{#d91a1a}-1.85\%$
test_step_mdp_speed[False-True-False-False-True] 54.7520μs 29.0009μs 34.4817 KOps/s 34.9121 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[False-True-False-False-False] 48.8610μs 18.1780μs 55.0115 KOps/s 55.7966 KOps/s $\color{#d91a1a}-1.41\%$
test_step_mdp_speed[False-False-True-True-True] 4.0704ms 45.6461μs 21.9077 KOps/s 22.1797 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[False-False-True-True-False] 69.6710μs 29.3223μs 34.1037 KOps/s 34.1881 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-False-True-False-True] 59.3810μs 29.1535μs 34.3011 KOps/s 35.2026 KOps/s $\color{#d91a1a}-2.56\%$
test_step_mdp_speed[False-False-True-False-False] 47.0110μs 18.0648μs 55.3564 KOps/s 56.1727 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[False-False-False-True-True] 77.3820μs 46.6921μs 21.4169 KOps/s 21.6423 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[False-False-False-True-False] 61.9510μs 31.0698μs 32.1856 KOps/s 31.7172 KOps/s $\color{#35bf28}+1.48\%$
test_step_mdp_speed[False-False-False-False-True] 56.9220μs 30.8782μs 32.3853 KOps/s 32.6877 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[False-False-False-False-False] 95.2420μs 19.7261μs 50.6942 KOps/s 50.5823 KOps/s $\color{#35bf28}+0.22\%$
test_values[generalized_advantage_estimate-True-True] 26.7668ms 25.2334ms 39.6299 Ops/s 40.7264 Ops/s $\color{#d91a1a}-2.69\%$
test_values[vec_generalized_advantage_estimate-True-True] 96.7112ms 2.8334ms 352.9285 Ops/s 367.2777 Ops/s $\color{#d91a1a}-3.91\%$
test_values[td0_return_estimate-False-False] 90.1220μs 65.9018μs 15.1741 KOps/s 14.8227 KOps/s $\color{#35bf28}+2.37\%$
test_values[td1_return_estimate-False-False] 58.6580ms 57.1587ms 17.4952 Ops/s 18.0680 Ops/s $\color{#d91a1a}-3.17\%$
test_values[vec_td1_return_estimate-False-False] 1.4477ms 1.0895ms 917.8705 Ops/s 915.1764 Ops/s $\color{#35bf28}+0.29\%$
test_values[td_lambda_return_estimate-True-False] 92.5733ms 90.6726ms 11.0287 Ops/s 11.4116 Ops/s $\color{#d91a1a}-3.36\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.4234ms 1.0840ms 922.4963 Ops/s 921.2852 Ops/s $\color{#35bf28}+0.13\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 26.7685ms 26.0956ms 38.3206 Ops/s 41.4535 Ops/s $\textbf{\color{#d91a1a}-7.56\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9366ms 0.7205ms 1.3879 KOps/s 1.3833 KOps/s $\color{#35bf28}+0.34\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7605ms 0.6694ms 1.4938 KOps/s 1.4876 KOps/s $\color{#35bf28}+0.42\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5565ms 1.4712ms 679.7163 Ops/s 677.7765 Ops/s $\color{#35bf28}+0.29\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7337ms 0.6850ms 1.4598 KOps/s 1.4544 KOps/s $\color{#35bf28}+0.37\%$
test_dqn_speed 1.6744ms 1.3555ms 737.7366 Ops/s 754.5704 Ops/s $\color{#d91a1a}-2.23\%$
test_ddpg_speed 3.0602ms 2.7288ms 366.4633 Ops/s 370.5415 Ops/s $\color{#d91a1a}-1.10\%$
test_sac_speed 8.1794ms 7.8198ms 127.8813 Ops/s 128.0576 Ops/s $\color{#d91a1a}-0.14\%$
test_redq_speed 11.2881ms 9.9331ms 100.6735 Ops/s 100.8858 Ops/s $\color{#d91a1a}-0.21\%$
test_redq_deprec_speed 10.9201ms 10.6915ms 93.5322 Ops/s 91.0470 Ops/s $\color{#35bf28}+2.73\%$
test_td3_speed 7.8508ms 7.7686ms 128.7234 Ops/s 129.2641 Ops/s $\color{#d91a1a}-0.42\%$
test_cql_speed 25.3904ms 24.6015ms 40.6479 Ops/s 40.4355 Ops/s $\color{#35bf28}+0.53\%$
test_a2c_speed 5.5420ms 5.3185ms 188.0245 Ops/s 180.7548 Ops/s $\color{#35bf28}+4.02\%$
test_ppo_speed 6.3919ms 5.6340ms 177.4938 Ops/s 169.9095 Ops/s $\color{#35bf28}+4.46\%$
test_reinforce_speed 4.5174ms 4.3166ms 231.6618 Ops/s 223.6632 Ops/s $\color{#35bf28}+3.58\%$
test_iql_speed 19.4169ms 18.7921ms 53.2139 Ops/s 52.0350 Ops/s $\color{#35bf28}+2.27\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.7125ms 6.6161ms 151.1454 Ops/s 150.0472 Ops/s $\color{#35bf28}+0.73\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1091s 0.5858ms 1.7070 KOps/s 1.9805 KOps/s $\textbf{\color{#d91a1a}-13.81\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6541ms 0.4851ms 2.0615 KOps/s 2.0667 KOps/s $\color{#d91a1a}-0.26\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.9120ms 6.6165ms 151.1379 Ops/s 152.4753 Ops/s $\color{#d91a1a}-0.88\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9328ms 0.4995ms 2.0020 KOps/s 1.9959 KOps/s $\color{#35bf28}+0.31\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6398ms 0.4790ms 2.0876 KOps/s 2.0825 KOps/s $\color{#35bf28}+0.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.1002ms 1.9016ms 525.8668 Ops/s 523.0749 Ops/s $\color{#35bf28}+0.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.9700ms 1.8184ms 549.9335 Ops/s 550.9824 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.9393ms 6.7797ms 147.5000 Ops/s 147.2862 Ops/s $\color{#35bf28}+0.15\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1579s 0.8202ms 1.2192 KOps/s 1.5321 KOps/s $\textbf{\color{#d91a1a}-20.42\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8204ms 0.6340ms 1.5774 KOps/s 1.5864 KOps/s $\color{#d91a1a}-0.57\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.7975ms 6.6769ms 149.7706 Ops/s 150.1653 Ops/s $\color{#d91a1a}-0.26\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7526ms 0.5067ms 1.9736 KOps/s 1.9752 KOps/s $\color{#d91a1a}-0.08\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6517ms 0.4873ms 2.0521 KOps/s 2.0621 KOps/s $\color{#d91a1a}-0.48\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.8802ms 6.6089ms 151.3106 Ops/s 151.1863 Ops/s $\color{#35bf28}+0.08\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1297s 0.6800ms 1.4707 KOps/s 1.9966 KOps/s $\textbf{\color{#d91a1a}-26.34\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6874ms 0.4800ms 2.0833 KOps/s 2.0806 KOps/s $\color{#35bf28}+0.13\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.9059ms 6.8090ms 146.8638 Ops/s 146.3771 Ops/s $\color{#35bf28}+0.33\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.0163ms 0.6629ms 1.5085 KOps/s 1.2434 KOps/s $\textbf{\color{#35bf28}+21.33\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8116ms 0.6358ms 1.5729 KOps/s 1.5856 KOps/s $\color{#d91a1a}-0.80\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1295s 7.6700ms 130.3779 Ops/s 130.2122 Ops/s $\color{#35bf28}+0.13\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 21.0827ms 15.7698ms 63.4125 Ops/s 62.4256 Ops/s $\color{#35bf28}+1.58\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.1615ms 1.1529ms 867.3628 Ops/s 743.8142 Ops/s $\textbf{\color{#35bf28}+16.61\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1266s 10.0454ms 99.5483 Ops/s 131.8564 Ops/s $\textbf{\color{#d91a1a}-24.50\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.1378ms 15.7928ms 63.3198 Ops/s 61.7692 Ops/s $\color{#35bf28}+2.51\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.4053ms 1.3520ms 739.6244 Ops/s 767.7616 Ops/s $\color{#d91a1a}-3.66\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1253s 7.7942ms 128.3004 Ops/s 129.5556 Ops/s $\color{#d91a1a}-0.97\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.3126ms 15.7231ms 63.6007 Ops/s 62.5802 Ops/s $\color{#35bf28}+1.63\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 6.3696ms 1.5091ms 662.6561 Ops/s 791.7068 Ops/s $\textbf{\color{#d91a1a}-16.30\%}$

@vmoens vmoens merged commit e76d8cb into main Aug 5, 2024
51 of 71 checks passed
@vmoens vmoens deleted the fix-calls-to-get branch August 5, 2024 12:02
@vmoens vmoens added the bug Something isn't working label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot