Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Refactor calls to get without default that raise KeyError #2353

Merged
merged 2 commits into from
Aug 4, 2024
Merged

[Refactor] Refactor calls to get without default that raise KeyError #2353

merged 2 commits into from
Aug 4, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Aug 4, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2353

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs, 10 Pending, 11 Unrelated Failures

As of commit c333330 with merge base 3267533 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2024
@vmoens vmoens added the Refactoring Refactoring of an existing feature label Aug 4, 2024
@vmoens vmoens merged commit 35a1c5b into main Aug 4, 2024
37 of 58 checks passed
@vmoens vmoens deleted the fix-get branch August 4, 2024 14:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}5$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 71.9184ms 60.7347ms 16.4651 Ops/s 16.6353 Ops/s $\color{#d91a1a}-1.02\%$
test_sync 42.4131ms 33.1940ms 30.1259 Ops/s 28.3001 Ops/s $\textbf{\color{#35bf28}+6.45\%}$
test_async 71.2824ms 31.7842ms 31.4622 Ops/s 31.2693 Ops/s $\color{#35bf28}+0.62\%$
test_simple 0.5216s 0.4381s 2.2824 Ops/s 2.4310 Ops/s $\textbf{\color{#d91a1a}-6.11\%}$
test_transformed 0.6723s 0.5931s 1.6861 Ops/s 1.6700 Ops/s $\color{#35bf28}+0.96\%$
test_serial 1.3935s 1.3109s 0.7628 Ops/s 0.7494 Ops/s $\color{#35bf28}+1.78\%$
test_parallel 1.2039s 1.1251s 0.8888 Ops/s 0.8559 Ops/s $\color{#35bf28}+3.84\%$
test_step_mdp_speed[True-True-True-True-True] 0.1945ms 23.6988μs 42.1963 KOps/s 41.8633 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[True-True-True-True-False] 65.9330μs 13.8794μs 72.0491 KOps/s 71.2116 KOps/s $\color{#35bf28}+1.18\%$
test_step_mdp_speed[True-True-True-False-True] 43.3320μs 13.7630μs 72.6588 KOps/s 71.3595 KOps/s $\color{#35bf28}+1.82\%$
test_step_mdp_speed[True-True-True-False-False] 55.4230μs 8.1111μs 123.2879 KOps/s 122.1895 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-True-False-True-True] 92.9340μs 25.7467μs 38.8399 KOps/s 38.9931 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[True-True-False-True-False] 87.4940μs 15.4008μs 64.9319 KOps/s 63.9303 KOps/s $\color{#35bf28}+1.57\%$
test_step_mdp_speed[True-True-False-False-True] 57.2070μs 15.0765μs 66.3285 KOps/s 65.2861 KOps/s $\color{#35bf28}+1.60\%$
test_step_mdp_speed[True-True-False-False-False] 60.4830μs 9.5107μs 105.1450 KOps/s 104.2726 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[True-False-True-True-True] 0.1496ms 26.8669μs 37.2206 KOps/s 37.0197 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[True-False-True-True-False] 71.9820μs 16.8702μs 59.2761 KOps/s 59.2783 KOps/s $-0.00\%$
test_step_mdp_speed[True-False-True-False-True] 81.8830μs 15.3225μs 65.2637 KOps/s 65.1701 KOps/s $\color{#35bf28}+0.14\%$
test_step_mdp_speed[True-False-True-False-False] 39.4430μs 9.5646μs 104.5520 KOps/s 104.5502 KOps/s $+0.00\%$
test_step_mdp_speed[True-False-False-True-True] 0.1030ms 28.3397μs 35.2862 KOps/s 35.5778 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[True-False-False-True-False] 53.5800μs 18.2424μs 54.8175 KOps/s 55.1296 KOps/s $\color{#d91a1a}-0.57\%$
test_step_mdp_speed[True-False-False-False-True] 86.2010μs 16.6521μs 60.0524 KOps/s 60.8216 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[True-False-False-False-False] 49.1220μs 10.8414μs 92.2394 KOps/s 91.7087 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[False-True-True-True-True] 84.4880μs 26.9963μs 37.0421 KOps/s 37.2229 KOps/s $\color{#d91a1a}-0.49\%$
test_step_mdp_speed[False-True-True-True-False] 79.6180μs 17.0557μs 58.6313 KOps/s 59.2847 KOps/s $\color{#d91a1a}-1.10\%$
test_step_mdp_speed[False-True-True-False-True] 55.2230μs 17.8577μs 55.9981 KOps/s 56.4604 KOps/s $\color{#d91a1a}-0.82\%$
test_step_mdp_speed[False-True-True-False-False] 63.0770μs 10.7050μs 93.4142 KOps/s 94.0671 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-True-False-True-True] 68.6080μs 28.2520μs 35.3958 KOps/s 35.6323 KOps/s $\color{#d91a1a}-0.66\%$
test_step_mdp_speed[False-True-False-True-False] 77.0440μs 18.0842μs 55.2967 KOps/s 54.8578 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[False-True-False-False-True] 50.6850μs 19.0316μs 52.5441 KOps/s 52.4658 KOps/s $\color{#35bf28}+0.15\%$
test_step_mdp_speed[False-True-False-False-False] 64.5710μs 12.0754μs 82.8132 KOps/s 83.1798 KOps/s $\color{#d91a1a}-0.44\%$
test_step_mdp_speed[False-False-True-True-True] 3.9013ms 30.1118μs 33.2096 KOps/s 33.3978 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[False-False-True-True-False] 81.8120μs 19.9237μs 50.1914 KOps/s 51.0016 KOps/s $\color{#d91a1a}-1.59\%$
test_step_mdp_speed[False-False-True-False-True] 85.8200μs 19.4798μs 51.3352 KOps/s 52.7486 KOps/s $\color{#d91a1a}-2.68\%$
test_step_mdp_speed[False-False-True-False-False] 58.1580μs 12.0203μs 83.1927 KOps/s 83.2509 KOps/s $\color{#d91a1a}-0.07\%$
test_step_mdp_speed[False-False-False-True-True] 0.1062ms 30.9653μs 32.2942 KOps/s 32.3110 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[False-False-False-True-False] 69.9210μs 20.9369μs 47.7626 KOps/s 47.5824 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[False-False-False-False-True] 55.8840μs 20.3318μs 49.1841 KOps/s 49.8155 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[False-False-False-False-False] 68.5280μs 13.3518μs 74.8964 KOps/s 74.2213 KOps/s $\color{#35bf28}+0.91\%$
test_values[generalized_advantage_estimate-True-True] 13.3462ms 9.7226ms 102.8529 Ops/s 101.9256 Ops/s $\color{#35bf28}+0.91\%$
test_values[vec_generalized_advantage_estimate-True-True] 38.0093ms 35.9212ms 27.8387 Ops/s 29.6098 Ops/s $\textbf{\color{#d91a1a}-5.98\%}$
test_values[td0_return_estimate-False-False] 0.2563ms 0.1881ms 5.3152 KOps/s 5.4432 KOps/s $\color{#d91a1a}-2.35\%$
test_values[td1_return_estimate-False-False] 27.7064ms 24.2758ms 41.1933 Ops/s 41.4588 Ops/s $\color{#d91a1a}-0.64\%$
test_values[vec_td1_return_estimate-False-False] 38.2747ms 35.9782ms 27.7946 Ops/s 29.6161 Ops/s $\textbf{\color{#d91a1a}-6.15\%}$
test_values[td_lambda_return_estimate-True-False] 36.6225ms 34.8799ms 28.6698 Ops/s 28.8177 Ops/s $\color{#d91a1a}-0.51\%$
test_values[vec_td_lambda_return_estimate-True-False] 39.2412ms 35.8463ms 27.8969 Ops/s 29.4976 Ops/s $\textbf{\color{#d91a1a}-5.43\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.0106ms 8.2578ms 121.0973 Ops/s 120.0724 Ops/s $\color{#35bf28}+0.85\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2784ms 1.8027ms 554.7187 Ops/s 486.5159 Ops/s $\textbf{\color{#35bf28}+14.02\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4628ms 0.3592ms 2.7838 KOps/s 2.7495 KOps/s $\color{#35bf28}+1.25\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.9017ms 46.1340ms 21.6760 Ops/s 22.2922 Ops/s $\color{#d91a1a}-2.76\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.2298ms 3.1219ms 320.3135 Ops/s 316.5242 Ops/s $\color{#35bf28}+1.20\%$
test_dqn_speed 7.3039ms 1.3537ms 738.7291 Ops/s 753.6036 Ops/s $\color{#d91a1a}-1.97\%$
test_ddpg_speed 3.6891ms 2.7961ms 357.6350 Ops/s 341.5226 Ops/s $\color{#35bf28}+4.72\%$
test_sac_speed 9.4252ms 8.6628ms 115.4363 Ops/s 108.7592 Ops/s $\textbf{\color{#35bf28}+6.14\%}$
test_redq_speed 15.4558ms 13.4398ms 74.4056 Ops/s 74.0950 Ops/s $\color{#35bf28}+0.42\%$
test_redq_deprec_speed 15.5737ms 14.2153ms 70.3467 Ops/s 71.7407 Ops/s $\color{#d91a1a}-1.94\%$
test_td3_speed 9.1171ms 8.5047ms 117.5824 Ops/s 112.9262 Ops/s $\color{#35bf28}+4.12\%$
test_cql_speed 39.5947ms 37.1396ms 26.9254 Ops/s 26.7343 Ops/s $\color{#35bf28}+0.71\%$
test_a2c_speed 9.1131ms 7.7064ms 129.7627 Ops/s 128.2505 Ops/s $\color{#35bf28}+1.18\%$
test_ppo_speed 9.7947ms 8.1787ms 122.2681 Ops/s 123.6052 Ops/s $\color{#d91a1a}-1.08\%$
test_reinforce_speed 8.3445ms 6.8930ms 145.0757 Ops/s 144.8767 Ops/s $\color{#35bf28}+0.14\%$
test_iql_speed 34.7590ms 32.8752ms 30.4180 Ops/s 29.6072 Ops/s $\color{#35bf28}+2.74\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.9548ms 5.2249ms 191.3898 Ops/s 188.5122 Ops/s $\color{#35bf28}+1.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.4914ms 0.5013ms 1.9950 KOps/s 1.9802 KOps/s $\color{#35bf28}+0.75\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7450ms 0.4818ms 2.0756 KOps/s 2.1037 KOps/s $\color{#d91a1a}-1.34\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.7040ms 5.1418ms 194.4850 Ops/s 195.0680 Ops/s $\color{#d91a1a}-0.30\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9254ms 0.4959ms 2.0163 KOps/s 2.0170 KOps/s $\color{#d91a1a}-0.03\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7516ms 0.4737ms 2.1110 KOps/s 2.1034 KOps/s $\color{#35bf28}+0.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.5430ms 1.7334ms 576.8930 Ops/s 578.7372 Ops/s $\color{#d91a1a}-0.32\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.8433ms 1.6563ms 603.7509 Ops/s 604.6054 Ops/s $\color{#d91a1a}-0.14\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.1833ms 5.3441ms 187.1211 Ops/s 183.4766 Ops/s $\color{#35bf28}+1.99\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.9131ms 0.6436ms 1.5537 KOps/s 1.5549 KOps/s $\color{#d91a1a}-0.08\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8112ms 0.6065ms 1.6487 KOps/s 1.6359 KOps/s $\color{#35bf28}+0.78\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.4237ms 5.2614ms 190.0633 Ops/s 184.9781 Ops/s $\color{#35bf28}+2.75\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.2746ms 0.5046ms 1.9818 KOps/s 1.4446 KOps/s $\textbf{\color{#35bf28}+37.18\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6398ms 0.4728ms 2.1150 KOps/s 2.1007 KOps/s $\color{#35bf28}+0.68\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1737ms 5.0908ms 196.4334 Ops/s 189.4932 Ops/s $\color{#35bf28}+3.66\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7148ms 0.4994ms 2.0023 KOps/s 1.9933 KOps/s $\color{#35bf28}+0.45\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 7.9960ms 0.4878ms 2.0499 KOps/s 2.0259 KOps/s $\color{#35bf28}+1.18\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 8.0022ms 5.2461ms 190.6161 Ops/s 184.9778 Ops/s $\color{#35bf28}+3.05\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0549ms 0.6464ms 1.5470 KOps/s 1.5510 KOps/s $\color{#d91a1a}-0.26\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9416ms 0.6336ms 1.5783 KOps/s 1.6260 KOps/s $\color{#d91a1a}-2.93\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1363s 8.9599ms 111.6079 Ops/s 147.6173 Ops/s $\textbf{\color{#d91a1a}-24.39\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.0320ms 13.5771ms 73.6533 Ops/s 72.0998 Ops/s $\color{#35bf28}+2.15\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.9653ms 1.1704ms 854.4397 Ops/s 853.7998 Ops/s $\color{#35bf28}+0.07\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1242s 6.2343ms 160.4029 Ops/s 154.8240 Ops/s $\color{#35bf28}+3.60\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.5126ms 13.6509ms 73.2552 Ops/s 72.9151 Ops/s $\color{#35bf28}+0.47\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.9966ms 1.1860ms 843.1351 Ops/s 838.8073 Ops/s $\color{#35bf28}+0.52\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1279s 6.6338ms 150.7442 Ops/s 150.5978 Ops/s $\color{#35bf28}+0.10\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.3956ms 13.6538ms 73.2396 Ops/s 61.5620 Ops/s $\textbf{\color{#35bf28}+18.97\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.9372ms 1.2968ms 771.1466 Ops/s 771.4103 Ops/s $\color{#d91a1a}-0.03\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1092s 0.1070s 9.3426 Ops/s 9.2809 Ops/s $\color{#35bf28}+0.66\%$
test_sync 95.0962ms 92.6618ms 10.7919 Ops/s 10.7178 Ops/s $\color{#35bf28}+0.69\%$
test_async 0.1794s 89.8262ms 11.1326 Ops/s 11.1803 Ops/s $\color{#d91a1a}-0.43\%$
test_single_pixels 0.1186s 0.1176s 8.5061 Ops/s 8.4778 Ops/s $\color{#35bf28}+0.33\%$
test_sync_pixels 76.6401ms 75.7193ms 13.2067 Ops/s 13.0015 Ops/s $\color{#35bf28}+1.58\%$
test_async_pixels 0.1464s 72.1984ms 13.8507 Ops/s 14.0179 Ops/s $\color{#d91a1a}-1.19\%$
test_simple 0.7833s 0.7658s 1.3058 Ops/s 1.2623 Ops/s $\color{#35bf28}+3.45\%$
test_transformed 1.0778s 1.0070s 0.9930 Ops/s 0.9994 Ops/s $\color{#d91a1a}-0.64\%$
test_serial 2.2553s 2.1867s 0.4573 Ops/s 0.4496 Ops/s $\color{#35bf28}+1.72\%$
test_parallel 1.9611s 1.8926s 0.5284 Ops/s 0.5218 Ops/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[True-True-True-True-True] 94.0170μs 36.8310μs 27.1510 KOps/s 27.6242 KOps/s $\color{#d91a1a}-1.71\%$
test_step_mdp_speed[True-True-True-True-False] 38.0120μs 20.9646μs 47.6994 KOps/s 47.7195 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[True-True-True-False-True] 40.8530μs 20.7404μs 48.2150 KOps/s 48.1441 KOps/s $\color{#35bf28}+0.15\%$
test_step_mdp_speed[True-True-True-False-False] 37.3220μs 11.8539μs 84.3607 KOps/s 84.2878 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-False-True-True] 55.8530μs 39.0535μs 25.6059 KOps/s 25.6198 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[True-True-False-True-False] 40.1420μs 23.3283μs 42.8665 KOps/s 42.8288 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-False-False-True] 42.6630μs 23.5381μs 42.4843 KOps/s 43.8838 KOps/s $\color{#d91a1a}-3.19\%$
test_step_mdp_speed[True-True-False-False-False] 28.5420μs 14.1933μs 70.4559 KOps/s 70.6231 KOps/s $\color{#d91a1a}-0.24\%$
test_step_mdp_speed[True-False-True-True-True] 68.0740μs 41.4253μs 24.1398 KOps/s 24.4128 KOps/s $\color{#d91a1a}-1.12\%$
test_step_mdp_speed[True-False-True-True-False] 42.9330μs 25.4009μs 39.3687 KOps/s 39.1153 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[True-False-True-False-True] 41.8820μs 23.1495μs 43.1974 KOps/s 43.7371 KOps/s $\color{#d91a1a}-1.23\%$
test_step_mdp_speed[True-False-True-False-False] 28.7820μs 14.0457μs 71.1960 KOps/s 70.6996 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[True-False-False-True-True] 74.9640μs 43.2891μs 23.1005 KOps/s 23.1771 KOps/s $\color{#d91a1a}-0.33\%$
test_step_mdp_speed[True-False-False-True-False] 48.0920μs 27.7372μs 36.0527 KOps/s 36.0093 KOps/s $\color{#35bf28}+0.12\%$
test_step_mdp_speed[True-False-False-False-True] 50.1530μs 25.2428μs 39.6152 KOps/s 40.1185 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[True-False-False-False-False] 33.2020μs 16.2778μs 61.4333 KOps/s 61.0817 KOps/s $\color{#35bf28}+0.58\%$
test_step_mdp_speed[False-True-True-True-True] 65.2340μs 41.5656μs 24.0584 KOps/s 24.5228 KOps/s $\color{#d91a1a}-1.89\%$
test_step_mdp_speed[False-True-True-True-False] 43.1520μs 25.6338μs 39.0110 KOps/s 39.2283 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[False-True-True-False-True] 50.8830μs 27.6897μs 36.1145 KOps/s 37.3777 KOps/s $\color{#d91a1a}-3.38\%$
test_step_mdp_speed[False-True-True-False-False] 40.7220μs 16.1024μs 62.1026 KOps/s 62.5683 KOps/s $\color{#d91a1a}-0.74\%$
test_step_mdp_speed[False-True-False-True-True] 66.1940μs 43.8973μs 22.7804 KOps/s 23.4045 KOps/s $\color{#d91a1a}-2.67\%$
test_step_mdp_speed[False-True-False-True-False] 58.6530μs 27.7591μs 36.0242 KOps/s 35.8890 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[False-True-False-False-True] 48.9120μs 29.6443μs 33.7333 KOps/s 34.5634 KOps/s $\color{#d91a1a}-2.40\%$
test_step_mdp_speed[False-True-False-False-False] 43.9120μs 18.4130μs 54.3094 KOps/s 54.9749 KOps/s $\color{#d91a1a}-1.21\%$
test_step_mdp_speed[False-False-True-True-True] 3.8851ms 46.0996μs 21.6922 KOps/s 21.9815 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[False-False-True-True-False] 75.8440μs 29.8375μs 33.5149 KOps/s 33.2751 KOps/s $\color{#35bf28}+0.72\%$
test_step_mdp_speed[False-False-True-False-True] 47.4620μs 29.4622μs 33.9418 KOps/s 34.5223 KOps/s $\color{#d91a1a}-1.68\%$
test_step_mdp_speed[False-False-True-False-False] 34.2920μs 18.2063μs 54.9262 KOps/s 55.0497 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-False-False-True-True] 65.9740μs 47.3005μs 21.1414 KOps/s 21.0758 KOps/s $\color{#35bf28}+0.31\%$
test_step_mdp_speed[False-False-False-True-False] 47.3730μs 31.5407μs 31.7051 KOps/s 30.9788 KOps/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[False-False-False-False-True] 57.3730μs 31.0802μs 32.1748 KOps/s 32.2047 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[False-False-False-False-False] 37.8720μs 20.0687μs 49.8289 KOps/s 49.2669 KOps/s $\color{#35bf28}+1.14\%$
test_values[generalized_advantage_estimate-True-True] 25.0578ms 24.5409ms 40.7484 Ops/s 38.9758 Ops/s $\color{#35bf28}+4.55\%$
test_values[vec_generalized_advantage_estimate-True-True] 95.7654ms 2.8149ms 355.2523 Ops/s 362.1745 Ops/s $\color{#d91a1a}-1.91\%$
test_values[td0_return_estimate-False-False] 90.4460μs 66.8216μs 14.9652 KOps/s 14.5657 KOps/s $\color{#35bf28}+2.74\%$
test_values[td1_return_estimate-False-False] 58.1851ms 56.8555ms 17.5885 Ops/s 17.0808 Ops/s $\color{#35bf28}+2.97\%$
test_values[vec_td1_return_estimate-False-False] 1.4599ms 1.0922ms 915.6159 Ops/s 910.1098 Ops/s $\color{#35bf28}+0.60\%$
test_values[td_lambda_return_estimate-True-False] 92.2275ms 87.8973ms 11.3769 Ops/s 10.8564 Ops/s $\color{#35bf28}+4.79\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.4347ms 1.0880ms 919.1104 Ops/s 911.2883 Ops/s $\color{#35bf28}+0.86\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.9177ms 24.7298ms 40.4370 Ops/s 38.4762 Ops/s $\textbf{\color{#35bf28}+5.10\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9422ms 0.7223ms 1.3844 KOps/s 1.3270 KOps/s $\color{#35bf28}+4.33\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7729ms 0.6743ms 1.4831 KOps/s 1.4537 KOps/s $\color{#35bf28}+2.03\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5337ms 1.4723ms 679.2226 Ops/s 677.3551 Ops/s $\color{#35bf28}+0.28\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7234ms 0.6877ms 1.4541 KOps/s 1.4172 KOps/s $\color{#35bf28}+2.61\%$
test_dqn_speed 7.2341ms 1.3492ms 741.1702 Ops/s 732.3128 Ops/s $\color{#35bf28}+1.21\%$
test_ddpg_speed 3.8661ms 2.7811ms 359.5729 Ops/s 361.9144 Ops/s $\color{#d91a1a}-0.65\%$
test_sac_speed 8.2126ms 7.9328ms 126.0591 Ops/s 125.9338 Ops/s $\color{#35bf28}+0.10\%$
test_redq_speed 12.3153ms 10.3769ms 96.3683 Ops/s 96.9024 Ops/s $\color{#d91a1a}-0.55\%$
test_redq_deprec_speed 11.4081ms 10.9772ms 91.0977 Ops/s 88.9432 Ops/s $\color{#35bf28}+2.42\%$
test_td3_speed 8.0432ms 7.8784ms 126.9296 Ops/s 127.3272 Ops/s $\color{#d91a1a}-0.31\%$
test_cql_speed 26.9411ms 25.6252ms 39.0241 Ops/s 39.7196 Ops/s $\color{#d91a1a}-1.75\%$
test_a2c_speed 6.1814ms 5.6316ms 177.5704 Ops/s 176.9416 Ops/s $\color{#35bf28}+0.36\%$
test_ppo_speed 6.0987ms 5.9282ms 168.6856 Ops/s 167.9989 Ops/s $\color{#35bf28}+0.41\%$
test_reinforce_speed 4.7229ms 4.4940ms 222.5174 Ops/s 219.5103 Ops/s $\color{#35bf28}+1.37\%$
test_iql_speed 20.1376ms 19.7210ms 50.7073 Ops/s 51.2673 Ops/s $\color{#d91a1a}-1.09\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.9244ms 6.8010ms 147.0371 Ops/s 147.8341 Ops/s $\color{#d91a1a}-0.54\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.9406ms 0.5204ms 1.9217 KOps/s 1.9244 KOps/s $\color{#d91a1a}-0.14\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7219ms 0.4992ms 2.0031 KOps/s 2.0124 KOps/s $\color{#d91a1a}-0.46\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.8411ms 6.6276ms 150.8837 Ops/s 150.9933 Ops/s $\color{#d91a1a}-0.07\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9766ms 0.5105ms 1.9590 KOps/s 1.9447 KOps/s $\color{#35bf28}+0.74\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7876ms 0.4937ms 2.0257 KOps/s 2.0070 KOps/s $\color{#35bf28}+0.93\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.1682ms 1.9947ms 501.3286 Ops/s 503.0825 Ops/s $\color{#d91a1a}-0.35\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.1018ms 1.8853ms 530.4327 Ops/s 533.4979 Ops/s $\color{#d91a1a}-0.57\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.9331ms 6.8178ms 146.6750 Ops/s 146.6956 Ops/s $\color{#d91a1a}-0.01\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7808ms 0.6675ms 1.4982 KOps/s 1.4929 KOps/s $\color{#35bf28}+0.35\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8432ms 0.6499ms 1.5386 KOps/s 1.5453 KOps/s $\color{#d91a1a}-0.43\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.8572ms 6.7290ms 148.6104 Ops/s 148.3605 Ops/s $\color{#35bf28}+0.17\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8292ms 0.5170ms 1.9344 KOps/s 1.9190 KOps/s $\color{#35bf28}+0.80\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6251ms 0.4987ms 2.0050 KOps/s 2.0001 KOps/s $\color{#35bf28}+0.25\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 9.0325ms 6.8607ms 145.7567 Ops/s 150.0840 Ops/s $\color{#d91a1a}-2.88\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1271s 0.6792ms 1.4723 KOps/s 1.9396 KOps/s $\textbf{\color{#d91a1a}-24.09\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6652ms 0.4916ms 2.0343 KOps/s 2.0108 KOps/s $\color{#35bf28}+1.17\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.9989ms 6.8872ms 145.1960 Ops/s 146.2419 Ops/s $\color{#d91a1a}-0.72\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.0518ms 0.6674ms 1.4982 KOps/s 1.4906 KOps/s $\color{#35bf28}+0.52\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8158ms 0.6487ms 1.5416 KOps/s 1.5423 KOps/s $\color{#d91a1a}-0.04\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1294s 7.6843ms 130.1350 Ops/s 97.9807 Ops/s $\textbf{\color{#35bf28}+32.82\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 22.2902ms 16.4740ms 60.7019 Ops/s 60.4719 Ops/s $\color{#35bf28}+0.38\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.2126ms 1.1982ms 834.6035 Ops/s 744.5534 Ops/s $\textbf{\color{#35bf28}+12.09\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1254s 10.0002ms 99.9981 Ops/s 131.3047 Ops/s $\textbf{\color{#d91a1a}-23.84\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 19.0917ms 16.4971ms 60.6166 Ops/s 60.4617 Ops/s $\color{#35bf28}+0.26\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.4233ms 1.3357ms 748.6688 Ops/s 779.8616 Ops/s $\color{#d91a1a}-4.00\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1257s 7.8101ms 128.0389 Ops/s 127.1426 Ops/s $\color{#35bf28}+0.70\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.1793ms 16.6274ms 60.1419 Ops/s 59.9797 Ops/s $\color{#35bf28}+0.27\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.1779ms 1.2853ms 778.0374 Ops/s 698.0809 Ops/s $\textbf{\color{#35bf28}+11.45\%}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Refactoring Refactoring of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot