Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Better dumps/loads #2343

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[BugFix] Better dumps/loads #2343

merged 2 commits into from
Jul 31, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jul 31, 2024 •
edited
Loading

Fixes regular dumps and loads with lazy memmap storages when the dest dir matches the storage dir.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2343

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 4 Unrelated Failures

As of commit a6603a6 with merge base da89826 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}11$. Worsened: $\large\color{#d91a1a}1$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 59.5665ms 58.2316ms 17.1728 Ops/s 17.1051 Ops/s $\color{#35bf28}+0.40\%$
test_sync 39.4616ms 33.0669ms 30.2417 Ops/s 30.3848 Ops/s $\color{#d91a1a}-0.47\%$
test_async 53.3223ms 30.4871ms 32.8007 Ops/s 32.3518 Ops/s $\color{#35bf28}+1.39\%$
test_simple 0.4928s 0.4188s 2.3878 Ops/s 2.4036 Ops/s $\color{#d91a1a}-0.66\%$
test_transformed 0.6344s 0.5749s 1.7395 Ops/s 1.7475 Ops/s $\color{#d91a1a}-0.45\%$
test_serial 1.3546s 1.2840s 0.7788 Ops/s 0.8088 Ops/s $\color{#d91a1a}-3.70\%$
test_parallel 1.1892s 1.1106s 0.9004 Ops/s 0.8937 Ops/s $\color{#35bf28}+0.75\%$
test_step_mdp_speed[True-True-True-True-True] 0.2210ms 24.1452μs 41.4161 KOps/s 41.3958 KOps/s $\color{#35bf28}+0.05\%$
test_step_mdp_speed[True-True-True-True-False] 48.0790μs 14.1231μs 70.8058 KOps/s 70.3127 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[True-True-True-False-True] 54.4510μs 13.9125μs 71.8778 KOps/s 71.5682 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[True-True-True-False-False] 42.6520μs 8.0625μs 124.0317 KOps/s 120.9969 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[True-True-False-True-True] 62.0150μs 25.8618μs 38.6671 KOps/s 38.6391 KOps/s $\color{#35bf28}+0.07\%$
test_step_mdp_speed[True-True-False-True-False] 49.8720μs 15.7713μs 63.4062 KOps/s 63.1665 KOps/s $\color{#35bf28}+0.38\%$
test_step_mdp_speed[True-True-False-False-True] 56.8960μs 15.3805μs 65.0174 KOps/s 64.5292 KOps/s $\color{#35bf28}+0.76\%$
test_step_mdp_speed[True-True-False-False-False] 59.8610μs 9.5796μs 104.3881 KOps/s 101.5134 KOps/s $\color{#35bf28}+2.83\%$
test_step_mdp_speed[True-False-True-True-True] 64.1090μs 27.1195μs 36.8739 KOps/s 36.0106 KOps/s $\color{#35bf28}+2.40\%$
test_step_mdp_speed[True-False-True-True-False] 39.5730μs 17.1225μs 58.4026 KOps/s 57.0655 KOps/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[True-False-True-False-True] 60.7030μs 15.3787μs 65.0250 KOps/s 63.6556 KOps/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[True-False-True-False-False] 56.2040μs 9.4479μs 105.8441 KOps/s 101.7335 KOps/s $\color{#35bf28}+4.04\%$
test_step_mdp_speed[True-False-False-True-True] 61.3340μs 28.4065μs 35.2032 KOps/s 34.3280 KOps/s $\color{#35bf28}+2.55\%$
test_step_mdp_speed[True-False-False-True-False] 63.2670μs 18.2909μs 54.6720 KOps/s 53.6538 KOps/s $\color{#35bf28}+1.90\%$
test_step_mdp_speed[True-False-False-False-True] 68.7580μs 16.6413μs 60.0915 KOps/s 59.2221 KOps/s $\color{#35bf28}+1.47\%$
test_step_mdp_speed[True-False-False-False-False] 36.2180μs 10.8801μs 91.9107 KOps/s 91.2077 KOps/s $\color{#35bf28}+0.77\%$
test_step_mdp_speed[False-True-True-True-True] 75.4600μs 27.2259μs 36.7297 KOps/s 36.3829 KOps/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[False-True-True-True-False] 42.2190μs 16.9656μs 58.9429 KOps/s 57.6130 KOps/s $\color{#35bf28}+2.31\%$
test_step_mdp_speed[False-True-True-False-True] 56.6450μs 17.8576μs 55.9987 KOps/s 56.2672 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[False-True-True-False-False] 38.2610μs 10.7870μs 92.7038 KOps/s 90.6773 KOps/s $\color{#35bf28}+2.23\%$
test_step_mdp_speed[False-True-False-True-True] 74.3080μs 28.3957μs 35.2166 KOps/s 34.5244 KOps/s $\color{#35bf28}+2.00\%$
test_step_mdp_speed[False-True-False-True-False] 71.8200μs 18.3654μs 54.4501 KOps/s 53.4516 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[False-True-False-False-True] 52.8580μs 19.1179μs 52.3071 KOps/s 51.9516 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[False-True-False-False-False] 48.2090μs 12.1249μs 82.4752 KOps/s 78.8333 KOps/s $\color{#35bf28}+4.62\%$
test_step_mdp_speed[False-False-True-True-True] 3.4584ms 29.9634μs 33.3741 KOps/s 32.4171 KOps/s $\color{#35bf28}+2.95\%$
test_step_mdp_speed[False-False-True-True-False] 53.0790μs 19.7962μs 50.5148 KOps/s 49.2666 KOps/s $\color{#35bf28}+2.53\%$
test_step_mdp_speed[False-False-True-False-True] 53.7800μs 19.3573μs 51.6601 KOps/s 51.4579 KOps/s $\color{#35bf28}+0.39\%$
test_step_mdp_speed[False-False-True-False-False] 43.4710μs 12.1444μs 82.3424 KOps/s 80.4530 KOps/s $\color{#35bf28}+2.35\%$
test_step_mdp_speed[False-False-False-True-True] 62.2760μs 31.2335μs 32.0169 KOps/s 31.8039 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[False-False-False-True-False] 75.3700μs 21.0346μs 47.5407 KOps/s 46.4361 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[False-False-False-False-True] 52.7780μs 20.3625μs 49.1100 KOps/s 48.6847 KOps/s $\color{#35bf28}+0.87\%$
test_step_mdp_speed[False-False-False-False-False] 51.5960μs 13.3313μs 75.0113 KOps/s 73.3137 KOps/s $\color{#35bf28}+2.32\%$
test_values[generalized_advantage_estimate-True-True] 9.6954ms 9.4062ms 106.3130 Ops/s 100.8442 Ops/s $\textbf{\color{#35bf28}+5.42\%}$
test_values[vec_generalized_advantage_estimate-True-True] 38.6782ms 33.7951ms 29.5901 Ops/s 27.6979 Ops/s $\textbf{\color{#35bf28}+6.83\%}$
test_values[td0_return_estimate-False-False] 0.2426ms 0.1714ms 5.8335 KOps/s 5.8338 KOps/s $-0.01\%$
test_values[td1_return_estimate-False-False] 27.5177ms 23.6334ms 42.3130 Ops/s 42.1138 Ops/s $\color{#35bf28}+0.47\%$
test_values[vec_td1_return_estimate-False-False] 35.9478ms 33.9142ms 29.4862 Ops/s 27.6877 Ops/s $\textbf{\color{#35bf28}+6.50\%}$
test_values[td_lambda_return_estimate-True-False] 37.9623ms 33.9166ms 29.4840 Ops/s 29.2397 Ops/s $\color{#35bf28}+0.84\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.1016ms 33.9619ms 29.4447 Ops/s 27.7429 Ops/s $\textbf{\color{#35bf28}+6.13\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.9144ms 8.2098ms 121.8050 Ops/s 121.9686 Ops/s $\color{#d91a1a}-0.13\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2372ms 1.8032ms 554.5549 Ops/s 505.9490 Ops/s $\textbf{\color{#35bf28}+9.61\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5374ms 0.3597ms 2.7804 KOps/s 2.8004 KOps/s $\color{#d91a1a}-0.71\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 42.2474ms 39.8924ms 25.0674 Ops/s 21.6017 Ops/s $\textbf{\color{#35bf28}+16.04\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.9335ms 3.0697ms 325.7607 Ops/s 328.6588 Ops/s $\color{#d91a1a}-0.88\%$
test_dqn_speed 6.2310ms 1.3495ms 740.9959 Ops/s 769.8833 Ops/s $\color{#d91a1a}-3.75\%$
test_ddpg_speed 3.5787ms 2.7612ms 362.1554 Ops/s 367.4054 Ops/s $\color{#d91a1a}-1.43\%$
test_sac_speed 9.9738ms 8.0677ms 123.9511 Ops/s 124.3839 Ops/s $\color{#d91a1a}-0.35\%$
test_redq_speed 15.1126ms 12.9969ms 76.9415 Ops/s 76.8571 Ops/s $\color{#35bf28}+0.11\%$
test_redq_deprec_speed 13.9612ms 12.7705ms 78.3052 Ops/s 76.3903 Ops/s $\color{#35bf28}+2.51\%$
test_td3_speed 8.3572ms 7.9970ms 125.0474 Ops/s 125.3349 Ops/s $\color{#d91a1a}-0.23\%$
test_cql_speed 37.5084ms 35.4657ms 28.1963 Ops/s 27.7188 Ops/s $\color{#35bf28}+1.72\%$
test_a2c_speed 8.5858ms 7.2849ms 137.2704 Ops/s 131.5727 Ops/s $\color{#35bf28}+4.33\%$
test_ppo_speed 8.6285ms 7.5745ms 132.0220 Ops/s 124.7823 Ops/s $\textbf{\color{#35bf28}+5.80\%}$
test_reinforce_speed 7.7566ms 6.4454ms 155.1505 Ops/s 148.8765 Ops/s $\color{#35bf28}+4.21\%$
test_iql_speed 34.0629ms 32.0580ms 31.1935 Ops/s 30.5098 Ops/s $\color{#35bf28}+2.24\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.2563ms 4.8654ms 205.5328 Ops/s 194.1396 Ops/s $\textbf{\color{#35bf28}+5.87\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.6114ms 0.4778ms 2.0931 KOps/s 2.0517 KOps/s $\color{#35bf28}+2.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6754ms 0.4510ms 2.2174 KOps/s 2.1708 KOps/s $\color{#35bf28}+2.14\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.4247ms 4.8279ms 207.1314 Ops/s 201.1508 Ops/s $\color{#35bf28}+2.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8494ms 0.4780ms 2.0923 KOps/s 2.1271 KOps/s $\color{#d91a1a}-1.64\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7680ms 0.4470ms 2.2373 KOps/s 2.2021 KOps/s $\color{#35bf28}+1.60\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.3199ms 1.6882ms 592.3621 Ops/s 593.8468 Ops/s $\color{#d91a1a}-0.25\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.1784ms 1.6010ms 624.5965 Ops/s 620.1631 Ops/s $\color{#35bf28}+0.71\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 7.8053ms 4.9899ms 200.4050 Ops/s 198.9392 Ops/s $\color{#35bf28}+0.74\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.6834ms 0.6094ms 1.6409 KOps/s 1.6355 KOps/s $\color{#35bf28}+0.33\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8781ms 0.5876ms 1.7017 KOps/s 1.7011 KOps/s $\color{#35bf28}+0.04\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.3743ms 4.8074ms 208.0108 Ops/s 203.8775 Ops/s $\color{#35bf28}+2.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5697ms 0.4754ms 2.1036 KOps/s 2.0756 KOps/s $\color{#35bf28}+1.35\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7264ms 0.4566ms 2.1899 KOps/s 2.1908 KOps/s $\color{#d91a1a}-0.04\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.3603ms 4.7723ms 209.5432 Ops/s 199.5332 Ops/s $\textbf{\color{#35bf28}+5.02\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8033ms 0.4754ms 2.1033 KOps/s 2.1084 KOps/s $\color{#d91a1a}-0.24\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6172ms 0.4471ms 2.2366 KOps/s 2.1599 KOps/s $\color{#35bf28}+3.55\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.4380ms 4.9123ms 203.5705 Ops/s 202.0433 Ops/s $\color{#35bf28}+0.76\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.4187ms 0.6158ms 1.6240 KOps/s 1.6361 KOps/s $\color{#d91a1a}-0.74\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8211ms 0.5857ms 1.7074 KOps/s 1.6652 KOps/s $\color{#35bf28}+2.54\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1359s 8.6478ms 115.6368 Ops/s 154.1658 Ops/s $\textbf{\color{#d91a1a}-24.99\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 16.6844ms 12.9731ms 77.0827 Ops/s 76.3099 Ops/s $\color{#35bf28}+1.01\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.6587ms 1.1172ms 895.1321 Ops/s 901.3721 Ops/s $\color{#d91a1a}-0.69\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1143s 6.0193ms 166.1328 Ops/s 168.2802 Ops/s $\color{#d91a1a}-1.28\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.7229ms 12.9251ms 77.3686 Ops/s 65.0185 Ops/s $\textbf{\color{#35bf28}+18.99\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6384ms 1.1180ms 894.4175 Ops/s 740.2866 Ops/s $\textbf{\color{#35bf28}+20.82\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1169s 6.2011ms 161.2612 Ops/s 164.4442 Ops/s $\color{#d91a1a}-1.94\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.0457ms 13.1772ms 75.8886 Ops/s 75.4629 Ops/s $\color{#35bf28}+0.56\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.1268ms 1.2881ms 776.3528 Ops/s 763.6921 Ops/s $\color{#35bf28}+1.66\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1091s 0.1088s 9.1881 Ops/s 9.1310 Ops/s $\color{#35bf28}+0.62\%$
test_sync 95.5621ms 95.2732ms 10.4961 Ops/s 10.5578 Ops/s $\color{#d91a1a}-0.58\%$
test_async 0.2545s 90.3581ms 11.0671 Ops/s 11.2835 Ops/s $\color{#d91a1a}-1.92\%$
test_single_pixels 0.1183s 0.1181s 8.4669 Ops/s 8.3947 Ops/s $\color{#35bf28}+0.86\%$
test_sync_pixels 77.3402ms 75.5475ms 13.2367 Ops/s 13.6526 Ops/s $\color{#d91a1a}-3.05\%$
test_async_pixels 0.1445s 70.3086ms 14.2230 Ops/s 14.5037 Ops/s $\color{#d91a1a}-1.94\%$
test_simple 0.7946s 0.7843s 1.2751 Ops/s 1.2501 Ops/s $\color{#35bf28}+2.00\%$
test_transformed 1.0999s 1.0298s 0.9711 Ops/s 0.9767 Ops/s $\color{#d91a1a}-0.57\%$
test_serial 2.3721s 2.2893s 0.4368 Ops/s 0.4412 Ops/s $\color{#d91a1a}-0.98\%$
test_parallel 2.0432s 1.9838s 0.5041 Ops/s 0.5040 Ops/s $\color{#35bf28}+0.01\%$
test_step_mdp_speed[True-True-True-True-True] 0.3326ms 36.4206μs 27.4570 KOps/s 26.8908 KOps/s $\color{#35bf28}+2.11\%$
test_step_mdp_speed[True-True-True-True-False] 45.0010μs 21.0173μs 47.5799 KOps/s 47.8006 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[True-True-True-False-True] 0.2130ms 20.6314μs 48.4698 KOps/s 48.4354 KOps/s $\color{#35bf28}+0.07\%$
test_step_mdp_speed[True-True-True-False-False] 0.2114ms 11.8857μs 84.1350 KOps/s 85.0333 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[True-True-False-True-True] 58.5610μs 38.5028μs 25.9721 KOps/s 25.6811 KOps/s $\color{#35bf28}+1.13\%$
test_step_mdp_speed[True-True-False-True-False] 0.2277ms 23.2873μs 42.9419 KOps/s 43.1485 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-True-False-False-True] 0.2434ms 22.7179μs 44.0182 KOps/s 44.2827 KOps/s $\color{#d91a1a}-0.60\%$
test_step_mdp_speed[True-True-False-False-False] 0.2064ms 14.1126μs 70.8586 KOps/s 71.2362 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[True-False-True-True-True] 70.0410μs 40.7473μs 24.5415 KOps/s 24.4317 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[True-False-True-True-False] 0.2207ms 25.3487μs 39.4498 KOps/s 39.8413 KOps/s $\color{#d91a1a}-0.98\%$
test_step_mdp_speed[True-False-True-False-True] 0.2070ms 22.8922μs 43.6831 KOps/s 44.3039 KOps/s $\color{#d91a1a}-1.40\%$
test_step_mdp_speed[True-False-True-False-False] 0.2064ms 14.1427μs 70.7076 KOps/s 72.0994 KOps/s $\color{#d91a1a}-1.93\%$
test_step_mdp_speed[True-False-False-True-True] 62.9910μs 42.7117μs 23.4128 KOps/s 23.3269 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[True-False-False-True-False] 0.2118ms 27.4315μs 36.4544 KOps/s 36.4961 KOps/s $\color{#d91a1a}-0.11\%$
test_step_mdp_speed[True-False-False-False-True] 0.2311ms 24.9441μs 40.0896 KOps/s 40.5406 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[True-False-False-False-False] 35.0410μs 16.1208μs 62.0315 KOps/s 61.8888 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[False-True-True-True-True] 0.2238ms 40.5819μs 24.6415 KOps/s 24.6436 KOps/s $-0.01\%$
test_step_mdp_speed[False-True-True-True-False] 53.8510μs 25.4463μs 39.2984 KOps/s 39.4519 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[False-True-True-False-True] 0.2383ms 26.9145μs 37.1547 KOps/s 36.9073 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[False-True-True-False-False] 35.1510μs 15.9498μs 62.6968 KOps/s 61.4014 KOps/s $\color{#35bf28}+2.11\%$
test_step_mdp_speed[False-True-False-True-True] 0.2436ms 42.6075μs 23.4700 KOps/s 23.3504 KOps/s $\color{#35bf28}+0.51\%$
test_step_mdp_speed[False-True-False-True-False] 0.2171ms 27.2363μs 36.7157 KOps/s 36.3418 KOps/s $\color{#35bf28}+1.03\%$
test_step_mdp_speed[False-True-False-False-True] 0.2261ms 28.6242μs 34.9355 KOps/s 34.5370 KOps/s $\color{#35bf28}+1.15\%$
test_step_mdp_speed[False-True-False-False-False] 41.1210μs 18.2007μs 54.9430 KOps/s 55.1138 KOps/s $\color{#d91a1a}-0.31\%$
test_step_mdp_speed[False-False-True-True-True] 3.9595ms 45.3942μs 22.0293 KOps/s 22.2167 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[False-False-True-True-False] 0.2267ms 29.7581μs 33.6042 KOps/s 33.9179 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[False-False-True-False-True] 0.2152ms 28.5196μs 35.0636 KOps/s 34.5431 KOps/s $\color{#35bf28}+1.51\%$
test_step_mdp_speed[False-False-True-False-False] 47.7900μs 18.2170μs 54.8939 KOps/s 54.7658 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[False-False-False-True-True] 0.2432ms 46.7764μs 21.3783 KOps/s 21.4797 KOps/s $\color{#d91a1a}-0.47\%$
test_step_mdp_speed[False-False-False-True-False] 0.2206ms 32.1599μs 31.0946 KOps/s 31.5816 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[False-False-False-False-True] 0.2302ms 30.4060μs 32.8883 KOps/s 32.5027 KOps/s $\color{#35bf28}+1.19\%$
test_step_mdp_speed[False-False-False-False-False] 0.2157ms 20.1037μs 49.7421 KOps/s 50.0733 KOps/s $\color{#d91a1a}-0.66\%$
test_values[generalized_advantage_estimate-True-True] 25.0105ms 24.4675ms 40.8706 Ops/s 39.2878 Ops/s $\color{#35bf28}+4.03\%$
test_values[vec_generalized_advantage_estimate-True-True] 96.8349ms 2.8378ms 352.3873 Ops/s 355.8355 Ops/s $\color{#d91a1a}-0.97\%$
test_values[td0_return_estimate-False-False] 92.0320μs 66.4078μs 15.0585 KOps/s 15.3591 KOps/s $\color{#d91a1a}-1.96\%$
test_values[td1_return_estimate-False-False] 56.0125ms 55.2693ms 18.0932 Ops/s 18.3439 Ops/s $\color{#d91a1a}-1.37\%$
test_values[vec_td1_return_estimate-False-False] 1.3999ms 1.0869ms 920.0678 Ops/s 921.8036 Ops/s $\color{#d91a1a}-0.19\%$
test_values[td_lambda_return_estimate-True-False] 88.4134ms 87.7546ms 11.3954 Ops/s 11.2028 Ops/s $\color{#35bf28}+1.72\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.4634ms 1.0839ms 922.6209 Ops/s 929.6462 Ops/s $\color{#d91a1a}-0.76\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.4076ms 24.1367ms 41.4307 Ops/s 38.9071 Ops/s $\textbf{\color{#35bf28}+6.49\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9589ms 0.7250ms 1.3794 KOps/s 1.3921 KOps/s $\color{#d91a1a}-0.91\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8785ms 0.6734ms 1.4850 KOps/s 1.5148 KOps/s $\color{#d91a1a}-1.97\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4967ms 1.4710ms 679.8228 Ops/s 678.4773 Ops/s $\color{#35bf28}+0.20\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9298ms 0.6864ms 1.4569 KOps/s 1.4797 KOps/s $\color{#d91a1a}-1.54\%$
test_dqn_speed 7.1778ms 1.3363ms 748.3471 Ops/s 757.7106 Ops/s $\color{#d91a1a}-1.24\%$
test_ddpg_speed 2.9872ms 2.7249ms 366.9803 Ops/s 368.7317 Ops/s $\color{#d91a1a}-0.47\%$
test_sac_speed 8.2420ms 7.8130ms 127.9915 Ops/s 126.9596 Ops/s $\color{#35bf28}+0.81\%$
test_redq_speed 12.0731ms 10.2368ms 97.6863 Ops/s 98.7374 Ops/s $\color{#d91a1a}-1.06\%$
test_redq_deprec_speed 11.2766ms 10.9050ms 91.7013 Ops/s 91.7723 Ops/s $\color{#d91a1a}-0.08\%$
test_td3_speed 7.9358ms 7.7515ms 129.0069 Ops/s 128.3897 Ops/s $\color{#35bf28}+0.48\%$
test_cql_speed 25.8202ms 25.0834ms 39.8670 Ops/s 39.9423 Ops/s $\color{#d91a1a}-0.19\%$
test_a2c_speed 5.7888ms 5.5893ms 178.9146 Ops/s 180.8618 Ops/s $\color{#d91a1a}-1.08\%$
test_ppo_speed 6.0881ms 5.9167ms 169.0138 Ops/s 172.2843 Ops/s $\color{#d91a1a}-1.90\%$
test_reinforce_speed 5.1364ms 4.5167ms 221.3996 Ops/s 223.1567 Ops/s $\color{#d91a1a}-0.79\%$
test_iql_speed 20.0640ms 19.5760ms 51.0830 Ops/s 51.5349 Ops/s $\color{#d91a1a}-0.88\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.8438ms 6.6484ms 150.4122 Ops/s 150.3989 Ops/s $+0.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7377ms 0.5117ms 1.9544 KOps/s 1.9370 KOps/s $\color{#35bf28}+0.90\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7198ms 0.4929ms 2.0287 KOps/s 2.0277 KOps/s $\color{#35bf28}+0.05\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.9242ms 6.5510ms 152.6484 Ops/s 152.6891 Ops/s $\color{#d91a1a}-0.03\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.5811ms 0.5104ms 1.9594 KOps/s 1.9520 KOps/s $\color{#35bf28}+0.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7990ms 0.4895ms 2.0430 KOps/s 2.0416 KOps/s $\color{#35bf28}+0.07\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.2073ms 1.9413ms 515.1237 Ops/s 515.2795 Ops/s $\color{#d91a1a}-0.03\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.0089ms 1.8473ms 541.3429 Ops/s 542.6799 Ops/s $\color{#d91a1a}-0.25\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.9721ms 6.7729ms 147.6478 Ops/s 147.2569 Ops/s $\color{#35bf28}+0.27\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0351ms 0.6615ms 1.5117 KOps/s 1.4921 KOps/s $\color{#35bf28}+1.31\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9101ms 0.6397ms 1.5632 KOps/s 1.5594 KOps/s $\color{#35bf28}+0.25\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.8773ms 6.6811ms 149.6765 Ops/s 150.1935 Ops/s $\color{#d91a1a}-0.34\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9440ms 0.5149ms 1.9423 KOps/s 1.9283 KOps/s $\color{#35bf28}+0.73\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6232ms 0.4947ms 2.0213 KOps/s 1.9919 KOps/s $\color{#35bf28}+1.48\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.8967ms 6.5543ms 152.5724 Ops/s 152.0189 Ops/s $\color{#35bf28}+0.36\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1590s 0.7439ms 1.3443 KOps/s 1.9562 KOps/s $\textbf{\color{#d91a1a}-31.28\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6735ms 0.4914ms 2.0349 KOps/s 2.0198 KOps/s $\color{#35bf28}+0.75\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.9843ms 6.8016ms 147.0239 Ops/s 148.3520 Ops/s $\color{#d91a1a}-0.90\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9007ms 0.6637ms 1.5068 KOps/s 1.2325 KOps/s $\textbf{\color{#35bf28}+22.26\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8429ms 0.6396ms 1.5636 KOps/s 1.5646 KOps/s $\color{#d91a1a}-0.06\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1293s 7.5773ms 131.9739 Ops/s 132.8859 Ops/s $\color{#d91a1a}-0.69\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.4521ms 15.9714ms 62.6121 Ops/s 62.0847 Ops/s $\color{#35bf28}+0.85\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.0115ms 1.3475ms 742.1012 Ops/s 780.5750 Ops/s $\color{#d91a1a}-4.93\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1260s 7.5465ms 132.5124 Ops/s 132.5014 Ops/s $+0.01\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1367s 18.5218ms 53.9906 Ops/s 61.8698 Ops/s $\textbf{\color{#d91a1a}-12.74\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.9595ms 1.3240ms 755.3043 Ops/s 782.8233 Ops/s $\color{#d91a1a}-3.52\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1253s 7.7178ms 129.5703 Ops/s 129.8001 Ops/s $\color{#d91a1a}-0.18\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.2282ms 16.3639ms 61.1102 Ops/s 61.0824 Ops/s $\color{#35bf28}+0.05\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.5066ms 1.4971ms 667.9541 Ops/s 691.8941 Ops/s $\color{#d91a1a}-3.46\%$

@vmoens vmoens added the bug Something isn't working label Jul 31, 2024
@vmoens vmoens merged commit c1093b7 into main Jul 31, 2024
69 of 75 checks passed
@vmoens vmoens deleted the storage branch July 31, 2024 18:20
@N00bcak N00bcak mentioned this pull request Aug 13, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot