Fix brax examples #2318

Jendker · 2024-07-24T15:14:27Z

Description

This fixes the brax examples. It explicitly specifies the device to run env on as recommended in the error messages.

Motivation and Context

This fixes the issues which I was getting with the original errors:

/home/jorbik/Projects/rl/torchrl/envs/libs/brax.py:207: UserWarning: No device is set for env BraxEnv(env=ant, batch_size=torch.Size([4]), device=None). Setting a device in Brax wrapped environments is strongly recommended.
  warnings.warn(
Traceback (most recent call last):
  File "/home/jorbik/Projects/rl/test.py", line 19, in <module>
    print(batch_size, timer.timeit(10))
                      ^^^^^^^^^^^^^^^^
  File "/home/jorbik/miniconda3/envs/torchrl/lib/python3.11/site-packages/torch/utils/benchmark/utils/timer.py", line 274, in timeit
    self._timeit(number=max(int(number // 100), 2))
  File "/home/jorbik/miniconda3/envs/torchrl/lib/python3.11/site-packages/torch/utils/benchmark/utils/timer.py", line 264, in _timeit
    return max(self._timer.timeit(number), 1e-9)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jorbik/miniconda3/envs/torchrl/lib/python3.11/timeit.py", line 180, in timeit
    timing = self.inner(it, self.timer)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<timeit-src>", line 6, in inner
  File "/home/jorbik/Projects/rl/torchrl/envs/common.py", line 2587, in rollout
    tensordicts = self._rollout_stop_early(**kwargs)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jorbik/Projects/rl/torchrl/envs/common.py", line 2674, in _rollout_stop_early
    tensordict = self.step(tensordict)
                 ^^^^^^^^^^^^^^^^^^^^^
  File "/home/jorbik/Projects/rl/torchrl/envs/common.py", line 1483, in step
    next_tensordict = self._step(tensordict)
                      ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jorbik/Projects/rl/torchrl/envs/libs/brax.py", line 418, in _step
    out = self._step_without_grad(tensordict)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jorbik/Projects/rl/torchrl/envs/libs/brax.py", line 348, in _step_without_grad
    next_state = self._vmap_jit_env_step(state, action)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: Received incompatible devices for jitted computation. Got ARG_SHARDING with device ids [0] on platform GPU and ARG_SHARDING with device ids [0] on platform CPU
--------------------
For simplicity, JAX has removed its internal frames from the traceback of the following exception. Set JAX_TRACEBACK_FILTERING=off to include these.

Closes #2319

I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds core functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (update in the documentation)
Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

I have read the CONTRIBUTION guide (required)
My change requires a change to the documentation.
I have updated the tests accordingly (required for a bug fix or a new feature).
I have updated the documentation accordingly.

pytorch-bot · 2024-07-24T15:14:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2318

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 9 Unrelated Failures

As of commit b2cb6f6 with merge base 1ca33a2 ():

NEW FAILURES - The following jobs have failed:

Continuous Benchmark (PR) / CPU Pytest benchmark (gh)
Workflow failed! Resource not accessible by integration
Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
Workflow failed! Resource not accessible by integration
Generate documentation / build-docs (3.9, 12.1) / linux-job (gh)
No files were found with the provided path: /home/ec2-user/actions-runner/_work/_temp/artifacts/. No artifacts will be uploaded.
Unit-tests on Windows / unittests-cpu / windows-job (gh)
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

Examples Tests on Linux / tests (3.9, 12.1) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Habitat Tests on Linux / tests (3.9, 12.1) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Libs Tests on Linux / unittests-gym (3.9, 12.1) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Libs Tests on Linux / unittests-sklearn (3.9, 12.1) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
RLHF Tests on Linux / unittests (3.9, 12.1) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Unit-tests on Linux / tests-gpu (3.10, 12.1) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Unit-tests on Linux / tests-olddeps (3.8, 11.6) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Unit-tests on Linux / tests-optdeps (3.10, 12.1) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128
Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-07-24T15:14:33Z

Hi @Jendker!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Jendker · 2024-07-24T15:14:56Z

Is it still required to sign Meta CLA? Isn't torchRL under PyTorch Foundation?

vmoens

LGTM thanks!

vmoens · 2024-07-24T20:15:37Z

Is it still required to sign Meta CLA? Isn't torchRL under PyTorch Foundation?

Here it's just doc so I'm moving forward but yeah the CLA is still there to be signed unfortunately

Fix brax examples

b2cb6f6

vmoens approved these changes Jul 24, 2024

View reviewed changes

vmoens merged commit 8a74642 into pytorch:main Jul 24, 2024
32 of 46 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix brax examples #2318

Fix brax examples #2318

Jendker commented Jul 24, 2024 •

edited

Loading

pytorch-bot bot commented Jul 24, 2024 •

edited

Loading

facebook-github-bot commented Jul 24, 2024

Jendker commented Jul 24, 2024

vmoens left a comment

vmoens commented Jul 24, 2024

Fix brax examples #2318

Fix brax examples #2318

Conversation

Jendker commented Jul 24, 2024 • edited Loading

Description

Motivation and Context

Types of changes

Checklist

pytorch-bot bot commented Jul 24, 2024 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2318

❌ 4 New Failures, 9 Unrelated Failures

facebook-github-bot commented Jul 24, 2024

Action Required

Process

Jendker commented Jul 24, 2024

vmoens left a comment

Choose a reason for hiding this comment

vmoens commented Jul 24, 2024

Jendker commented Jul 24, 2024 •

edited

Loading

pytorch-bot bot commented Jul 24, 2024 •

edited

Loading