[Feature] Add modules.OrnsteinUhlenbeckProcessModule
#2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2297
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 New Failures, 1 Pending, 2 Unrelated FailuresAs of commit 04b1511 with merge base c4b2eb0 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vmoens
changed the title
modules.OrnsteinUhlenbeckProcessModulemodules.OrnsteinUhlenbeckProcessModule
vmoens
approved these changes
Jul 19, 2024
vmoens
reviewed
Jul 19, 2024
Comment on lines
+78
to
79
| OrnsteinUhlenbeckProcessModule | ||
| OrnsteinUhlenbeckProcessWrapper |
There was a problem hiding this comment.
Suggested change
| OrnsteinUhlenbeckProcessModule | |
| OrnsteinUhlenbeckProcessWrapper | |
| OrnsteinUhlenbeckProcessModule |
since we want to deprecate it
There was a problem hiding this comment.
hmm upon reflection, let's keep this one, people may still see it in their code
There was a problem hiding this comment.
Yeah I'd think it's typically a good idea to keep the old documentation and only remove it at the point when the deprecated feature is actually removed
kurtamohler
force-pushed
the
convert-wrappers-to-modules-1
branch
from
f7ca3f5 to
04b1511
Compare
|
I've added the deprecation warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
OrnsteinUhlenbeckProcessModule, which serves the same purpose asOrnsteinUhlenbeckProcessWrapper, but derives fromTensorDictModuleBaserather thanTensorDictModuleWrapperMotivation and Context
part of #2295
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!