Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Fix VMAS tests #2287

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[Tests] Fix VMAS tests #2287

merged 1 commit into from
Jul 10, 2024

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Jul 10, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2287

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit fc1387c with merge base ea79350 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2024
@vmoens vmoens added the Tests Incomplete or broken unit tests label Jul 10, 2024
@vmoens vmoens changed the title [CI] Fix VMAS tests [Tests] Fix VMAS tests Jul 10, 2024
vmoens
vmoens approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bc-breaking? Since we had tests that worked and they don't, should the users be informed of anything?

@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Jul 10, 2024
@vmoens vmoens merged commit dcd332d into pytorch:main Jul 10, 2024
49 of 54 checks passed
@matteobettini
Copy link
Contributor Author

Is this bc-breaking? Since we had tests that worked and they don't, should the users be informed of anything?

nono, not bc-breaking, the tests had some narrow assumpions that have been extended.

@matteobettini matteobettini deleted the fix_vmas branch July 10, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper Tests Incomplete or broken unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot