Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] _make_ordinal_device #2237

Merged
merged 5 commits into from
Jun 19, 2024
Merged

[Feature] _make_ordinal_device #2237

merged 5 commits into from
Jun 19, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 18, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2237

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 6 Unrelated Failures

As of commit 6cece06 with merge base 45ab9de (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2024
@vmoens vmoens linked an issue Jun 18, 2024 that may be closed by this pull request
[BUG] check_env_specs + PixelRenderTransform does not tolerate "cuda" device #2236
Closed
3 tasks
@vmoens vmoens added the enhancement New feature or request label Jun 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}11$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1285s 61.6093ms 16.2313 Ops/s 17.1159 Ops/s $\textbf{\color{#d91a1a}-5.17\%}$
test_sync 41.6290ms 34.3925ms 29.0761 Ops/s 28.9495 Ops/s $\color{#35bf28}+0.44\%$
test_async 58.7581ms 29.9597ms 33.3782 Ops/s 33.1123 Ops/s $\color{#35bf28}+0.80\%$
test_simple 0.4934s 0.4185s 2.3896 Ops/s 2.5600 Ops/s $\textbf{\color{#d91a1a}-6.66\%}$
test_transformed 0.5630s 0.5509s 1.8152 Ops/s 1.8344 Ops/s $\color{#d91a1a}-1.04\%$
test_serial 1.3678s 1.2969s 0.7710 Ops/s 0.7707 Ops/s $\color{#35bf28}+0.05\%$
test_parallel 1.1607s 1.0939s 0.9141 Ops/s 0.8987 Ops/s $\color{#35bf28}+1.72\%$
test_step_mdp_speed[True-True-True-True-True] 0.2689ms 21.9623μs 45.5326 KOps/s 46.3219 KOps/s $\color{#d91a1a}-1.70\%$
test_step_mdp_speed[True-True-True-True-False] 63.3790μs 13.4207μs 74.5115 KOps/s 74.9513 KOps/s $\color{#d91a1a}-0.59\%$
test_step_mdp_speed[True-True-True-False-True] 48.8320μs 12.7552μs 78.3992 KOps/s 78.4752 KOps/s $\color{#d91a1a}-0.10\%$
test_step_mdp_speed[True-True-True-False-False] 38.1120μs 7.7500μs 129.0327 KOps/s 127.1829 KOps/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[True-True-False-True-True] 0.1017ms 23.2507μs 43.0095 KOps/s 43.0326 KOps/s $\color{#d91a1a}-0.05\%$
test_step_mdp_speed[True-True-False-True-False] 51.2460μs 14.6403μs 68.3045 KOps/s 68.0656 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[True-True-False-False-True] 55.2740μs 14.2250μs 70.2987 KOps/s 71.9667 KOps/s $\color{#d91a1a}-2.32\%$
test_step_mdp_speed[True-True-False-False-False] 46.7680μs 9.0495μs 110.5032 KOps/s 110.6058 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[True-False-True-True-True] 67.7770μs 24.7100μs 40.4694 KOps/s 41.0561 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[True-False-True-True-False] 44.7740μs 16.0451μs 62.3242 KOps/s 62.3336 KOps/s $\color{#d91a1a}-0.01\%$
test_step_mdp_speed[True-False-True-False-True] 55.2640μs 14.2951μs 69.9538 KOps/s 71.3699 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[True-False-True-False-False] 39.7950μs 9.0919μs 109.9879 KOps/s 109.1432 KOps/s $\color{#35bf28}+0.77\%$
test_step_mdp_speed[True-False-False-True-True] 77.9870μs 26.0405μs 38.4018 KOps/s 38.9686 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[True-False-False-True-False] 71.2740μs 17.3014μs 57.7988 KOps/s 57.7040 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-False-False-False-True] 95.1510μs 15.3841μs 65.0024 KOps/s 65.6532 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[True-False-False-False-False] 41.2380μs 10.1937μs 98.1002 KOps/s 96.6155 KOps/s $\color{#35bf28}+1.54\%$
test_step_mdp_speed[False-True-True-True-True] 74.7000μs 24.8451μs 40.2494 KOps/s 41.0720 KOps/s $\color{#d91a1a}-2.00\%$
test_step_mdp_speed[False-True-True-True-False] 48.8310μs 16.0126μs 62.4509 KOps/s 61.8680 KOps/s $\color{#35bf28}+0.94\%$
test_step_mdp_speed[False-True-True-False-True] 56.2350μs 16.5307μs 60.4934 KOps/s 61.5576 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[False-True-True-False-False] 42.4290μs 10.3754μs 96.3818 KOps/s 96.8711 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[False-True-False-True-True] 67.1260μs 26.1846μs 38.1903 KOps/s 39.4141 KOps/s $\color{#d91a1a}-3.11\%$
test_step_mdp_speed[False-True-False-True-False] 51.5160μs 17.2270μs 58.0485 KOps/s 57.3466 KOps/s $\color{#35bf28}+1.22\%$
test_step_mdp_speed[False-True-False-False-True] 50.2840μs 17.6742μs 56.5796 KOps/s 57.0033 KOps/s $\color{#d91a1a}-0.74\%$
test_step_mdp_speed[False-True-False-False-False] 52.7790μs 11.5060μs 86.9114 KOps/s 86.1932 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[False-False-True-True-True] 74.3590μs 27.3141μs 36.6111 KOps/s 37.2895 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[False-False-True-True-False] 52.7880μs 18.6975μs 53.4830 KOps/s 53.2611 KOps/s $\color{#35bf28}+0.42\%$
test_step_mdp_speed[False-False-True-False-True] 96.6490μs 17.6862μs 56.5414 KOps/s 56.7554 KOps/s $\color{#d91a1a}-0.38\%$
test_step_mdp_speed[False-False-True-False-False] 62.1860μs 11.4977μs 86.9741 KOps/s 85.7662 KOps/s $\color{#35bf28}+1.41\%$
test_step_mdp_speed[False-False-False-True-True] 55.9850μs 28.6065μs 34.9571 KOps/s 35.2697 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[False-False-False-True-False] 53.9210μs 19.6651μs 50.8514 KOps/s 49.2608 KOps/s $\color{#35bf28}+3.23\%$
test_step_mdp_speed[False-False-False-False-True] 58.6200μs 18.6769μs 53.5422 KOps/s 53.9338 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[False-False-False-False-False] 44.9840μs 12.6111μs 79.2953 KOps/s 77.8897 KOps/s $\color{#35bf28}+1.80\%$
test_values[generalized_advantage_estimate-True-True] 11.4047ms 9.9628ms 100.3738 Ops/s 100.7491 Ops/s $\color{#d91a1a}-0.37\%$
test_values[vec_generalized_advantage_estimate-True-True] 42.3311ms 36.0440ms 27.7439 Ops/s 29.5794 Ops/s $\textbf{\color{#d91a1a}-6.21\%}$
test_values[td0_return_estimate-False-False] 0.2431ms 0.1934ms 5.1704 KOps/s 4.8784 KOps/s $\textbf{\color{#35bf28}+5.99\%}$
test_values[td1_return_estimate-False-False] 25.4981ms 25.0184ms 39.9705 Ops/s 40.3414 Ops/s $\color{#d91a1a}-0.92\%$
test_values[vec_td1_return_estimate-False-False] 41.0900ms 38.1869ms 26.1870 Ops/s 29.4657 Ops/s $\textbf{\color{#d91a1a}-11.13\%}$
test_values[td_lambda_return_estimate-True-False] 39.3505ms 36.1846ms 27.6361 Ops/s 27.9571 Ops/s $\color{#d91a1a}-1.15\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.7533ms 35.7977ms 27.9348 Ops/s 29.5949 Ops/s $\textbf{\color{#d91a1a}-5.61\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.8082ms 8.3125ms 120.3014 Ops/s 118.0622 Ops/s $\color{#35bf28}+1.90\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.4058ms 2.0279ms 493.1302 Ops/s 491.8950 Ops/s $\color{#35bf28}+0.25\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5142ms 0.3633ms 2.7524 KOps/s 2.7583 KOps/s $\color{#d91a1a}-0.22\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.8678ms 45.7582ms 21.8540 Ops/s 20.9411 Ops/s $\color{#35bf28}+4.36\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.0642ms 3.1653ms 315.9225 Ops/s 324.9275 Ops/s $\color{#d91a1a}-2.77\%$
test_dqn_speed 2.0677ms 1.4175ms 705.4822 Ops/s 716.9283 Ops/s $\color{#d91a1a}-1.60\%$
test_ddpg_speed 3.6616ms 3.0556ms 327.2641 Ops/s 327.3690 Ops/s $\color{#d91a1a}-0.03\%$
test_sac_speed 10.4171ms 9.2739ms 107.8300 Ops/s 108.5673 Ops/s $\color{#d91a1a}-0.68\%$
test_redq_speed 15.7010ms 14.5236ms 68.8534 Ops/s 68.7844 Ops/s $\color{#35bf28}+0.10\%$
test_redq_deprec_speed 16.9300ms 15.9701ms 62.6169 Ops/s 65.9747 Ops/s $\textbf{\color{#d91a1a}-5.09\%}$
test_td3_speed 19.5667ms 9.8664ms 101.3537 Ops/s 106.1095 Ops/s $\color{#d91a1a}-4.48\%$
test_cql_speed 48.0045ms 40.9844ms 24.3995 Ops/s 25.6644 Ops/s $\color{#d91a1a}-4.93\%$
test_a2c_speed 9.1938ms 8.6413ms 115.7227 Ops/s 120.6559 Ops/s $\color{#d91a1a}-4.09\%$
test_ppo_speed 9.9203ms 9.2802ms 107.7563 Ops/s 114.4343 Ops/s $\textbf{\color{#d91a1a}-5.84\%}$
test_reinforce_speed 9.0681ms 7.6834ms 130.1502 Ops/s 136.4934 Ops/s $\color{#d91a1a}-4.65\%$
test_iql_speed 37.0879ms 35.3696ms 28.2729 Ops/s 28.4564 Ops/s $\color{#d91a1a}-0.64\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.7967ms 4.0726ms 245.5424 Ops/s 250.0356 Ops/s $\color{#d91a1a}-1.80\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0304ms 0.5424ms 1.8436 KOps/s 1.8419 KOps/s $\color{#35bf28}+0.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7970ms 0.5081ms 1.9682 KOps/s 1.9556 KOps/s $\color{#35bf28}+0.65\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.2520ms 4.1968ms 238.2761 Ops/s 248.6996 Ops/s $\color{#d91a1a}-4.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9257ms 0.5232ms 1.9113 KOps/s 1.8834 KOps/s $\color{#35bf28}+1.48\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7466ms 0.5083ms 1.9672 KOps/s 1.9635 KOps/s $\color{#35bf28}+0.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.7067ms 1.8377ms 544.1491 Ops/s 558.4462 Ops/s $\color{#d91a1a}-2.56\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.1019ms 1.7497ms 571.5235 Ops/s 590.4918 Ops/s $\color{#d91a1a}-3.21\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8620ms 4.4221ms 226.1385 Ops/s 238.9686 Ops/s $\textbf{\color{#d91a1a}-5.37\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9790ms 0.6571ms 1.5218 KOps/s 1.5240 KOps/s $\color{#d91a1a}-0.14\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1347s 0.7589ms 1.3177 KOps/s 1.4069 KOps/s $\textbf{\color{#d91a1a}-6.34\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.5350ms 3.9859ms 250.8863 Ops/s 244.9076 Ops/s $\color{#35bf28}+2.44\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8083ms 0.5328ms 1.8770 KOps/s 1.8401 KOps/s $\color{#35bf28}+2.01\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.0777ms 0.5111ms 1.9564 KOps/s 1.9656 KOps/s $\color{#d91a1a}-0.47\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.5363ms 4.0417ms 247.4226 Ops/s 262.4130 Ops/s $\textbf{\color{#d91a1a}-5.71\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1225s 0.6884ms 1.4527 KOps/s 1.3886 KOps/s $\color{#35bf28}+4.61\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7226ms 0.4997ms 2.0013 KOps/s 1.9505 KOps/s $\color{#35bf28}+2.61\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8954ms 4.4961ms 222.4130 Ops/s 237.5919 Ops/s $\textbf{\color{#d91a1a}-6.39\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8260ms 0.6757ms 1.4799 KOps/s 1.4980 KOps/s $\color{#d91a1a}-1.21\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0049ms 0.6486ms 1.5417 KOps/s 1.5725 KOps/s $\color{#d91a1a}-1.96\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1336s 6.8060ms 146.9290 Ops/s 152.1899 Ops/s $\color{#d91a1a}-3.46\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1367s 15.6639ms 63.8411 Ops/s 62.2686 Ops/s $\color{#35bf28}+2.53\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.6466ms 1.0881ms 919.0075 Ops/s 923.8680 Ops/s $\color{#d91a1a}-0.53\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1309s 6.6382ms 150.6435 Ops/s 157.2263 Ops/s $\color{#d91a1a}-4.19\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.1868ms 13.0781ms 76.4639 Ops/s 74.8638 Ops/s $\color{#35bf28}+2.14\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.6996ms 1.1112ms 899.9161 Ops/s 903.5620 Ops/s $\color{#d91a1a}-0.40\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1291s 6.6423ms 150.5510 Ops/s 152.6990 Ops/s $\color{#d91a1a}-1.41\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 16.4662ms 13.3568ms 74.8681 Ops/s 71.7495 Ops/s $\color{#35bf28}+4.35\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.5252ms 1.3253ms 754.5195 Ops/s 745.4319 Ops/s $\color{#35bf28}+1.22\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1790s 0.1283s 7.7968 Ops/s 8.7371 Ops/s $\textbf{\color{#d91a1a}-10.76\%}$
test_sync 0.1056s 0.1046s 9.5628 Ops/s 9.8011 Ops/s $\color{#d91a1a}-2.43\%$
test_async 0.1990s 98.5225ms 10.1500 Ops/s 10.1317 Ops/s $\color{#35bf28}+0.18\%$
test_single_pixels 0.1283s 0.1281s 7.8073 Ops/s 7.9222 Ops/s $\color{#d91a1a}-1.45\%$
test_sync_pixels 84.7735ms 82.1664ms 12.1704 Ops/s 12.4804 Ops/s $\color{#d91a1a}-2.48\%$
test_async_pixels 0.1480s 68.4589ms 14.6073 Ops/s 15.2333 Ops/s $\color{#d91a1a}-4.11\%$
test_simple 0.8899s 0.8248s 1.2124 Ops/s 1.2438 Ops/s $\color{#d91a1a}-2.52\%$
test_transformed 1.1427s 1.0808s 0.9252 Ops/s 0.9604 Ops/s $\color{#d91a1a}-3.67\%$
test_serial 2.5528s 2.4890s 0.4018 Ops/s 0.4119 Ops/s $\color{#d91a1a}-2.45\%$
test_parallel 2.4545s 2.3574s 0.4242 Ops/s 0.4262 Ops/s $\color{#d91a1a}-0.47\%$
test_step_mdp_speed[True-True-True-True-True] 0.1172ms 33.4484μs 29.8968 KOps/s 29.8860 KOps/s $\color{#35bf28}+0.04\%$
test_step_mdp_speed[True-True-True-True-False] 41.6710μs 20.0168μs 49.9579 KOps/s 51.2039 KOps/s $\color{#d91a1a}-2.43\%$
test_step_mdp_speed[True-True-True-False-True] 34.8300μs 19.0863μs 52.3935 KOps/s 52.6550 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-True-True-False-False] 42.7110μs 11.4608μs 87.2540 KOps/s 88.4129 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[True-True-False-True-True] 69.8210μs 35.5929μs 28.0955 KOps/s 28.7366 KOps/s $\color{#d91a1a}-2.23\%$
test_step_mdp_speed[True-True-False-True-False] 57.8610μs 21.7379μs 46.0027 KOps/s 46.9547 KOps/s $\color{#d91a1a}-2.03\%$
test_step_mdp_speed[True-True-False-False-True] 45.3910μs 21.5641μs 46.3733 KOps/s 48.7228 KOps/s $\color{#d91a1a}-4.82\%$
test_step_mdp_speed[True-True-False-False-False] 55.8310μs 13.4803μs 74.1826 KOps/s 76.1640 KOps/s $\color{#d91a1a}-2.60\%$
test_step_mdp_speed[True-False-True-True-True] 80.2910μs 37.5616μs 26.6229 KOps/s 27.1069 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[True-False-True-True-False] 58.0810μs 24.0916μs 41.5083 KOps/s 42.7924 KOps/s $\color{#d91a1a}-3.00\%$
test_step_mdp_speed[True-False-True-False-True] 51.4310μs 20.9703μs 47.6865 KOps/s 48.9668 KOps/s $\color{#d91a1a}-2.61\%$
test_step_mdp_speed[True-False-True-False-False] 46.3000μs 13.4135μs 74.5520 KOps/s 74.9879 KOps/s $\color{#d91a1a}-0.58\%$
test_step_mdp_speed[True-False-False-True-True] 62.0410μs 38.9670μs 25.6627 KOps/s 25.8652 KOps/s $\color{#d91a1a}-0.78\%$
test_step_mdp_speed[True-False-False-True-False] 56.8810μs 26.0885μs 38.3311 KOps/s 39.3493 KOps/s $\color{#d91a1a}-2.59\%$
test_step_mdp_speed[True-False-False-False-True] 40.4410μs 23.2786μs 42.9578 KOps/s 44.0716 KOps/s $\color{#d91a1a}-2.53\%$
test_step_mdp_speed[True-False-False-False-False] 36.9600μs 15.1520μs 65.9978 KOps/s 66.3546 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[False-True-True-True-True] 59.4910μs 37.1345μs 26.9292 KOps/s 26.9136 KOps/s $\color{#35bf28}+0.06\%$
test_step_mdp_speed[False-True-True-True-False] 43.8510μs 23.9131μs 41.8180 KOps/s 42.6219 KOps/s $\color{#d91a1a}-1.89\%$
test_step_mdp_speed[False-True-True-False-True] 44.3110μs 25.6037μs 39.0569 KOps/s 40.0386 KOps/s $\color{#d91a1a}-2.45\%$
test_step_mdp_speed[False-True-True-False-False] 55.0710μs 15.2199μs 65.7036 KOps/s 66.8065 KOps/s $\color{#d91a1a}-1.65\%$
test_step_mdp_speed[False-True-False-True-True] 76.0610μs 39.4800μs 25.3293 KOps/s 25.6929 KOps/s $\color{#d91a1a}-1.42\%$
test_step_mdp_speed[False-True-False-True-False] 67.0810μs 25.5826μs 39.0890 KOps/s 39.5150 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-True-False-False-True] 47.5310μs 26.9527μs 37.1021 KOps/s 37.4326 KOps/s $\color{#d91a1a}-0.88\%$
test_step_mdp_speed[False-True-False-False-False] 42.7810μs 17.5390μs 57.0156 KOps/s 59.5081 KOps/s $\color{#d91a1a}-4.19\%$
test_step_mdp_speed[False-False-True-True-True] 74.6010μs 41.2334μs 24.2522 KOps/s 24.6308 KOps/s $\color{#d91a1a}-1.54\%$
test_step_mdp_speed[False-False-True-True-False] 49.2300μs 27.8832μs 35.8639 KOps/s 36.5504 KOps/s $\color{#d91a1a}-1.88\%$
test_step_mdp_speed[False-False-True-False-True] 58.4610μs 27.2940μs 36.6380 KOps/s 37.3898 KOps/s $\color{#d91a1a}-2.01\%$
test_step_mdp_speed[False-False-True-False-False] 53.0410μs 17.4349μs 57.3562 KOps/s 59.0196 KOps/s $\color{#d91a1a}-2.82\%$
test_step_mdp_speed[False-False-False-True-True] 58.3410μs 43.3368μs 23.0751 KOps/s 23.4499 KOps/s $\color{#d91a1a}-1.60\%$
test_step_mdp_speed[False-False-False-True-False] 68.3210μs 29.6666μs 33.7080 KOps/s 34.2652 KOps/s $\color{#d91a1a}-1.63\%$
test_step_mdp_speed[False-False-False-False-True] 72.6920μs 29.1505μs 34.3048 KOps/s 35.1976 KOps/s $\color{#d91a1a}-2.54\%$
test_step_mdp_speed[False-False-False-False-False] 34.5800μs 18.8098μs 53.1639 KOps/s 53.7047 KOps/s $\color{#d91a1a}-1.01\%$
test_values[generalized_advantage_estimate-True-True] 24.3682ms 23.9067ms 41.8292 Ops/s 42.7006 Ops/s $\color{#d91a1a}-2.04\%$
test_values[vec_generalized_advantage_estimate-True-True] 97.0771ms 2.8356ms 352.6569 Ops/s 375.7018 Ops/s $\textbf{\color{#d91a1a}-6.13\%}$
test_values[td0_return_estimate-False-False] 0.1128ms 65.8863μs 15.1777 KOps/s 15.4880 KOps/s $\color{#d91a1a}-2.00\%$
test_values[td1_return_estimate-False-False] 54.3809ms 53.7882ms 18.5914 Ops/s 19.1105 Ops/s $\color{#d91a1a}-2.72\%$
test_values[vec_td1_return_estimate-False-False] 1.2709ms 1.0760ms 929.4004 Ops/s 938.8202 Ops/s $\color{#d91a1a}-1.00\%$
test_values[td_lambda_return_estimate-True-False] 86.0397ms 85.7080ms 11.6675 Ops/s 12.0202 Ops/s $\color{#d91a1a}-2.93\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.2673ms 1.0721ms 932.7480 Ops/s 940.3989 Ops/s $\color{#d91a1a}-0.81\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.1167ms 23.8218ms 41.9783 Ops/s 43.0586 Ops/s $\color{#d91a1a}-2.51\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9650ms 0.7118ms 1.4048 KOps/s 1.4235 KOps/s $\color{#d91a1a}-1.31\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7531ms 0.6614ms 1.5119 KOps/s 1.5381 KOps/s $\color{#d91a1a}-1.71\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5453ms 1.4636ms 683.2583 Ops/s 687.4978 Ops/s $\color{#d91a1a}-0.62\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7028ms 0.6755ms 1.4804 KOps/s 1.5080 KOps/s $\color{#d91a1a}-1.83\%$
test_dqn_speed 1.5998ms 1.4525ms 688.4820 Ops/s 696.2555 Ops/s $\color{#d91a1a}-1.12\%$
test_ddpg_speed 3.3325ms 2.9621ms 337.5973 Ops/s 342.3037 Ops/s $\color{#d91a1a}-1.37\%$
test_sac_speed 8.5581ms 8.2932ms 120.5812 Ops/s 121.5577 Ops/s $\color{#d91a1a}-0.80\%$
test_redq_speed 10.7692ms 10.3781ms 96.3572 Ops/s 96.2306 Ops/s $\color{#35bf28}+0.13\%$
test_redq_deprec_speed 11.8852ms 11.4140ms 87.6120 Ops/s 90.4214 Ops/s $\color{#d91a1a}-3.11\%$
test_td3_speed 17.5655ms 8.3160ms 120.2506 Ops/s 121.4117 Ops/s $\color{#d91a1a}-0.96\%$
test_cql_speed 26.4314ms 25.4029ms 39.3656 Ops/s 39.3485 Ops/s $\color{#35bf28}+0.04\%$
test_a2c_speed 5.9277ms 5.6957ms 175.5712 Ops/s 180.8663 Ops/s $\color{#d91a1a}-2.93\%$
test_ppo_speed 6.7220ms 5.9885ms 166.9869 Ops/s 169.8740 Ops/s $\color{#d91a1a}-1.70\%$
test_reinforce_speed 6.2605ms 4.7023ms 212.6621 Ops/s 219.8323 Ops/s $\color{#d91a1a}-3.26\%$
test_iql_speed 20.4785ms 19.8753ms 50.3136 Ops/s 50.8219 Ops/s $\color{#d91a1a}-1.00\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.6832ms 4.6386ms 215.5810 Ops/s 218.0319 Ops/s $\color{#d91a1a}-1.12\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7598ms 0.5884ms 1.6995 KOps/s 1.7130 KOps/s $\color{#d91a1a}-0.79\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.6258ms 0.5748ms 1.7396 KOps/s 1.7871 KOps/s $\color{#d91a1a}-2.66\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.8390ms 4.6025ms 217.2736 Ops/s 217.1751 Ops/s $\color{#35bf28}+0.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7566ms 0.5894ms 1.6966 KOps/s 1.7326 KOps/s $\color{#d91a1a}-2.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.5492ms 0.5766ms 1.7344 KOps/s 1.8121 KOps/s $\color{#d91a1a}-4.29\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.3769ms 2.1157ms 472.6457 Ops/s 490.2056 Ops/s $\color{#d91a1a}-3.58\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 2.2516ms 1.9787ms 505.3951 Ops/s 519.0939 Ops/s $\color{#d91a1a}-2.64\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8331ms 4.7260ms 211.5951 Ops/s 212.1607 Ops/s $\color{#d91a1a}-0.27\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1230s 0.8288ms 1.2065 KOps/s 1.4180 KOps/s $\textbf{\color{#d91a1a}-14.91\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8602ms 0.6950ms 1.4388 KOps/s 1.4646 KOps/s $\color{#d91a1a}-1.76\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.9121ms 4.6620ms 214.4999 Ops/s 216.1925 Ops/s $\color{#d91a1a}-0.78\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7347ms 0.5979ms 1.6725 KOps/s 1.7193 KOps/s $\color{#d91a1a}-2.72\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.9710ms 0.5873ms 1.7028 KOps/s 1.7502 KOps/s $\color{#d91a1a}-2.71\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.9159ms 4.6574ms 214.7106 Ops/s 218.8505 Ops/s $\color{#d91a1a}-1.89\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6902ms 0.5886ms 1.6989 KOps/s 1.7372 KOps/s $\color{#d91a1a}-2.21\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7562ms 0.5772ms 1.7325 KOps/s 1.7892 KOps/s $\color{#d91a1a}-3.17\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.8726ms 4.7810ms 209.1616 Ops/s 210.9307 Ops/s $\color{#d91a1a}-0.84\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8326ms 0.7242ms 1.3809 KOps/s 1.4190 KOps/s $\color{#d91a1a}-2.68\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 5.1762ms 0.7101ms 1.4083 KOps/s 1.4431 KOps/s $\color{#d91a1a}-2.41\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1423s 7.7442ms 129.1282 Ops/s 133.7419 Ops/s $\color{#d91a1a}-3.45\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.4170ms 15.6749ms 63.7963 Ops/s 65.8347 Ops/s $\color{#d91a1a}-3.10\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.3494ms 1.3123ms 762.0365 Ops/s 782.2282 Ops/s $\color{#d91a1a}-2.58\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1248s 7.4212ms 134.7483 Ops/s 136.4426 Ops/s $\color{#d91a1a}-1.24\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1340s 18.0282ms 55.4685 Ops/s 66.0186 Ops/s $\textbf{\color{#d91a1a}-15.98\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.3672ms 1.3412ms 745.6260 Ops/s 759.6638 Ops/s $\color{#d91a1a}-1.85\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1247s 7.6242ms 131.1621 Ops/s 100.1690 Ops/s $\textbf{\color{#35bf28}+30.94\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.5610ms 15.7873ms 63.3419 Ops/s 65.0086 Ops/s $\color{#d91a1a}-2.56\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.5601ms 1.4677ms 681.3476 Ops/s 692.2552 Ops/s $\color{#d91a1a}-1.58\%$

@vmoens vmoens merged commit c44a521 into main Jun 19, 2024
35 of 47 checks passed
@vmoens vmoens deleted the make-ordinal-device branch June 19, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] check_env_specs + PixelRenderTransform does not tolerate "cuda" device
2 participants
@vmoens @facebook-github-bot