Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quality] better error message for CompositeSpec shape mismatch #2223

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[Quality] better error message for CompositeSpec shape mismatch #2223

merged 1 commit into from
Jun 11, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 11, 2024

closes #2222

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2223

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 15 Unrelated Failures

As of commit 7db222e with merge base 1029f10 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2024
@vmoens vmoens added quality code quality and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 11, 2024
@vmoens vmoens merged commit 0c008db into main Jun 11, 2024
15 of 25 checks passed
@vmoens vmoens deleted the fix-error-speccheck branch June 11, 2024 09:42
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1171s 59.3198ms 16.8578 Ops/s 17.4227 Ops/s $\color{#d91a1a}-3.24\%$
test_sync 37.4120ms 31.2798ms 31.9695 Ops/s 31.3573 Ops/s $\color{#35bf28}+1.95\%$
test_async 58.1577ms 29.2904ms 34.1409 Ops/s 33.9620 Ops/s $\color{#35bf28}+0.53\%$
test_simple 0.4631s 0.3956s 2.5275 Ops/s 2.5920 Ops/s $\color{#d91a1a}-2.49\%$
test_transformed 0.6415s 0.5632s 1.7755 Ops/s 1.8452 Ops/s $\color{#d91a1a}-3.78\%$
test_serial 1.3838s 1.3183s 0.7586 Ops/s 0.7730 Ops/s $\color{#d91a1a}-1.86\%$
test_parallel 1.1549s 1.0838s 0.9227 Ops/s 0.9239 Ops/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[True-True-True-True-True] 0.3011ms 21.7415μs 45.9950 KOps/s 46.4118 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[True-True-True-True-False] 37.0090μs 13.2633μs 75.3961 KOps/s 76.2587 KOps/s $\color{#d91a1a}-1.13\%$
test_step_mdp_speed[True-True-True-False-True] 43.5110μs 12.8490μs 77.8268 KOps/s 78.4134 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-True-True-False-False] 37.6400μs 7.8027μs 128.1608 KOps/s 129.5642 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[True-True-False-True-True] 0.1045ms 22.7362μs 43.9827 KOps/s 43.7453 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[True-True-False-True-False] 43.8110μs 14.5495μs 68.7308 KOps/s 68.9740 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[True-True-False-False-True] 34.6850μs 14.0960μs 70.9421 KOps/s 71.9741 KOps/s $\color{#d91a1a}-1.43\%$
test_step_mdp_speed[True-True-False-False-False] 0.1576ms 9.2008μs 108.6859 KOps/s 113.8077 KOps/s $\color{#d91a1a}-4.50\%$
test_step_mdp_speed[True-False-True-True-True] 60.4930μs 24.3731μs 41.0289 KOps/s 41.0782 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[True-False-True-True-False] 41.0670μs 15.8806μs 62.9698 KOps/s 64.6717 KOps/s $\color{#d91a1a}-2.63\%$
test_step_mdp_speed[True-False-True-False-True] 41.1160μs 14.0674μs 71.0865 KOps/s 72.5002 KOps/s $\color{#d91a1a}-1.95\%$
test_step_mdp_speed[True-False-True-False-False] 36.9080μs 9.0857μs 110.0630 KOps/s 113.3883 KOps/s $\color{#d91a1a}-2.93\%$
test_step_mdp_speed[True-False-False-True-True] 0.1056ms 25.3878μs 39.3889 KOps/s 38.5148 KOps/s $\color{#35bf28}+2.27\%$
test_step_mdp_speed[True-False-False-True-False] 46.7770μs 17.1689μs 58.2447 KOps/s 59.5865 KOps/s $\color{#d91a1a}-2.25\%$
test_step_mdp_speed[True-False-False-False-True] 71.9950μs 15.2699μs 65.4884 KOps/s 66.9813 KOps/s $\color{#d91a1a}-2.23\%$
test_step_mdp_speed[True-False-False-False-False] 45.4150μs 10.1836μs 98.1968 KOps/s 99.9049 KOps/s $\color{#d91a1a}-1.71\%$
test_step_mdp_speed[False-True-True-True-True] 63.3980μs 24.3968μs 40.9889 KOps/s 41.2716 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[False-True-True-True-False] 48.3500μs 15.9124μs 62.8442 KOps/s 63.7281 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[False-True-True-False-True] 44.8040μs 16.1637μs 61.8672 KOps/s 62.8301 KOps/s $\color{#d91a1a}-1.53\%$
test_step_mdp_speed[False-True-True-False-False] 34.5150μs 10.2489μs 97.5716 KOps/s 99.6135 KOps/s $\color{#d91a1a}-2.05\%$
test_step_mdp_speed[False-True-False-True-True] 58.8590μs 25.5996μs 39.0631 KOps/s 39.8138 KOps/s $\color{#d91a1a}-1.89\%$
test_step_mdp_speed[False-True-False-True-False] 42.5000μs 17.0307μs 58.7176 KOps/s 59.1224 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[False-True-False-False-True] 54.4910μs 17.3316μs 57.6980 KOps/s 58.0362 KOps/s $\color{#d91a1a}-0.58\%$
test_step_mdp_speed[False-True-False-False-False] 36.6080μs 11.5098μs 86.8825 KOps/s 88.9371 KOps/s $\color{#d91a1a}-2.31\%$
test_step_mdp_speed[False-False-True-True-True] 83.7160μs 26.5976μs 37.5974 KOps/s 37.8032 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[False-False-True-True-False] 73.4870μs 18.2655μs 54.7481 KOps/s 55.3957 KOps/s $\color{#d91a1a}-1.17\%$
test_step_mdp_speed[False-False-True-False-True] 42.7200μs 17.3703μs 57.5696 KOps/s 58.3356 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[False-False-True-False-False] 35.7770μs 11.4497μs 87.3389 KOps/s 90.0844 KOps/s $\color{#d91a1a}-3.05\%$
test_step_mdp_speed[False-False-False-True-True] 43.9220μs 28.2234μs 35.4316 KOps/s 35.8963 KOps/s $\color{#d91a1a}-1.29\%$
test_step_mdp_speed[False-False-False-True-False] 80.2700μs 19.5864μs 51.0557 KOps/s 52.1981 KOps/s $\color{#d91a1a}-2.19\%$
test_step_mdp_speed[False-False-False-False-True] 47.4690μs 18.4081μs 54.3238 KOps/s 55.2784 KOps/s $\color{#d91a1a}-1.73\%$
test_step_mdp_speed[False-False-False-False-False] 46.1660μs 12.5749μs 79.5233 KOps/s 81.4193 KOps/s $\color{#d91a1a}-2.33\%$
test_values[generalized_advantage_estimate-True-True] 13.2861ms 9.7534ms 102.5282 Ops/s 105.8548 Ops/s $\color{#d91a1a}-3.14\%$
test_values[vec_generalized_advantage_estimate-True-True] 50.0460ms 36.9177ms 27.0873 Ops/s 28.0168 Ops/s $\color{#d91a1a}-3.32\%$
test_values[td0_return_estimate-False-False] 0.2301ms 0.1730ms 5.7805 KOps/s 5.6881 KOps/s $\color{#35bf28}+1.63\%$
test_values[td1_return_estimate-False-False] 25.4590ms 24.0670ms 41.5506 Ops/s 41.0808 Ops/s $\color{#35bf28}+1.14\%$
test_values[vec_td1_return_estimate-False-False] 52.4074ms 36.3125ms 27.5387 Ops/s 27.9145 Ops/s $\color{#d91a1a}-1.35\%$
test_values[td_lambda_return_estimate-True-False] 37.6318ms 34.6050ms 28.8975 Ops/s 28.9219 Ops/s $\color{#d91a1a}-0.08\%$
test_values[vec_td_lambda_return_estimate-True-False] 39.5041ms 35.9985ms 27.7789 Ops/s 27.9224 Ops/s $\color{#d91a1a}-0.51\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 11.8717ms 8.3088ms 120.3549 Ops/s 122.5061 Ops/s $\color{#d91a1a}-1.76\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.5809ms 2.0855ms 479.4978 Ops/s 547.8257 Ops/s $\textbf{\color{#d91a1a}-12.47\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4591ms 0.3625ms 2.7586 KOps/s 2.7565 KOps/s $\color{#35bf28}+0.08\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 50.3388ms 48.7521ms 20.5120 Ops/s 20.1737 Ops/s $\color{#35bf28}+1.68\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 4.2392ms 3.0664ms 326.1121 Ops/s 327.8956 Ops/s $\color{#d91a1a}-0.54\%$
test_dqn_speed 1.8111ms 1.3745ms 727.5580 Ops/s 701.2970 Ops/s $\color{#35bf28}+3.74\%$
test_ddpg_speed 3.6517ms 2.9180ms 342.6964 Ops/s 341.9995 Ops/s $\color{#35bf28}+0.20\%$
test_sac_speed 9.4620ms 8.7751ms 113.9587 Ops/s 113.5169 Ops/s $\color{#35bf28}+0.39\%$
test_redq_speed 15.7987ms 13.9449ms 71.7108 Ops/s 72.2550 Ops/s $\color{#d91a1a}-0.75\%$
test_redq_deprec_speed 15.2534ms 14.1355ms 70.7436 Ops/s 70.0444 Ops/s $\color{#35bf28}+1.00\%$
test_td3_speed 18.0062ms 8.7532ms 114.2439 Ops/s 114.4506 Ops/s $\color{#d91a1a}-0.18\%$
test_cql_speed 38.9317ms 37.4061ms 26.7336 Ops/s 26.5598 Ops/s $\color{#35bf28}+0.65\%$
test_a2c_speed 9.5188ms 7.9275ms 126.1429 Ops/s 127.3080 Ops/s $\color{#d91a1a}-0.92\%$
test_ppo_speed 9.6710ms 8.5007ms 117.6368 Ops/s 123.3266 Ops/s $\color{#d91a1a}-4.61\%$
test_reinforce_speed 7.6968ms 6.9417ms 144.0569 Ops/s 146.0718 Ops/s $\color{#d91a1a}-1.38\%$
test_iql_speed 36.1236ms 33.8229ms 29.5657 Ops/s 29.6234 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.9966ms 3.7687ms 265.3444 Ops/s 267.7871 Ops/s $\color{#d91a1a}-0.91\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8529ms 0.5109ms 1.9574 KOps/s 1.9695 KOps/s $\color{#d91a1a}-0.61\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.5272ms 0.4874ms 2.0515 KOps/s 2.0675 KOps/s $\color{#d91a1a}-0.77\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.4422ms 3.8008ms 263.1013 Ops/s 268.9269 Ops/s $\color{#d91a1a}-2.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7580ms 0.5063ms 1.9752 KOps/s 2.0001 KOps/s $\color{#d91a1a}-1.25\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.7216ms 0.4853ms 2.0604 KOps/s 2.0848 KOps/s $\color{#d91a1a}-1.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.2469ms 1.7138ms 583.5153 Ops/s 583.3713 Ops/s $\color{#35bf28}+0.02\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.9870ms 1.6175ms 618.2482 Ops/s 614.7036 Ops/s $\color{#35bf28}+0.58\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.8012ms 3.8722ms 258.2486 Ops/s 260.1025 Ops/s $\color{#d91a1a}-0.71\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1291ms 0.6405ms 1.5613 KOps/s 1.5586 KOps/s $\color{#35bf28}+0.17\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1232s 0.7014ms 1.4257 KOps/s 1.6382 KOps/s $\textbf{\color{#d91a1a}-12.97\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.7180ms 3.8972ms 256.5950 Ops/s 269.2315 Ops/s $\color{#d91a1a}-4.69\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6358ms 0.5138ms 1.9462 KOps/s 1.9721 KOps/s $\color{#d91a1a}-1.31\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.5885ms 0.4899ms 2.0410 KOps/s 2.0807 KOps/s $\color{#d91a1a}-1.91\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.5985ms 3.6980ms 270.4187 Ops/s 274.0839 Ops/s $\color{#d91a1a}-1.34\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.1145s 0.6606ms 1.5139 KOps/s 1.9891 KOps/s $\textbf{\color{#d91a1a}-23.89\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7958ms 0.4854ms 2.0601 KOps/s 2.0896 KOps/s $\color{#d91a1a}-1.41\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.4085ms 3.9442ms 253.5378 Ops/s 258.4574 Ops/s $\color{#d91a1a}-1.90\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7686ms 0.6360ms 1.5724 KOps/s 1.6082 KOps/s $\color{#d91a1a}-2.23\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.8622ms 0.6118ms 1.6346 KOps/s 1.6752 KOps/s $\color{#d91a1a}-2.42\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1203s 6.0548ms 165.1585 Ops/s 160.8230 Ops/s $\color{#35bf28}+2.70\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1257s 14.8939ms 67.1417 Ops/s 67.2239 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.8120ms 1.0816ms 924.5812 Ops/s 947.5054 Ops/s $\color{#d91a1a}-2.42\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1178s 6.0703ms 164.7360 Ops/s 170.1078 Ops/s $\color{#d91a1a}-3.16\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.1236ms 12.7301ms 78.5542 Ops/s 80.0930 Ops/s $\color{#d91a1a}-1.92\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.7932ms 1.0754ms 929.8496 Ops/s 952.5318 Ops/s $\color{#d91a1a}-2.38\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1197s 8.4694ms 118.0724 Ops/s 163.4475 Ops/s $\textbf{\color{#d91a1a}-27.76\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.3988ms 12.7570ms 78.3886 Ops/s 66.8518 Ops/s $\textbf{\color{#35bf28}+17.26\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.0042ms 1.2116ms 825.3301 Ops/s 828.4643 Ops/s $\color{#d91a1a}-0.38\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1202s 0.1186s 8.4302 Ops/s 8.4257 Ops/s $\color{#35bf28}+0.05\%$
test_sync 0.1016s 99.3558ms 10.0648 Ops/s 9.5961 Ops/s $\color{#35bf28}+4.88\%$
test_async 0.1871s 94.0749ms 10.6298 Ops/s 12.0861 Ops/s $\textbf{\color{#d91a1a}-12.05\%}$
test_single_pixels 0.1292s 0.1288s 7.7632 Ops/s 7.8055 Ops/s $\color{#d91a1a}-0.54\%$
test_sync_pixels 85.4137ms 83.7947ms 11.9339 Ops/s 12.3404 Ops/s $\color{#d91a1a}-3.29\%$
test_async_pixels 0.1544s 68.4800ms 14.6028 Ops/s 14.7366 Ops/s $\color{#d91a1a}-0.91\%$
test_simple 0.8129s 0.8089s 1.2362 Ops/s 1.2285 Ops/s $\color{#35bf28}+0.63\%$
test_transformed 1.0708s 1.0700s 0.9346 Ops/s 0.9321 Ops/s $\color{#35bf28}+0.27\%$
test_serial 2.5589s 2.5021s 0.3997 Ops/s 0.4019 Ops/s $\color{#d91a1a}-0.55\%$
test_parallel 2.4144s 2.3541s 0.4248 Ops/s 0.4286 Ops/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[True-True-True-True-True] 0.1049ms 33.6787μs 29.6924 KOps/s 29.9474 KOps/s $\color{#d91a1a}-0.85\%$
test_step_mdp_speed[True-True-True-True-False] 0.1653ms 19.9689μs 50.0779 KOps/s 50.3312 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-True-True-False-True] 36.8910μs 19.1658μs 52.1762 KOps/s 50.9812 KOps/s $\color{#35bf28}+2.34\%$
test_step_mdp_speed[True-True-True-False-False] 32.2200μs 11.5178μs 86.8222 KOps/s 86.2527 KOps/s $\color{#35bf28}+0.66\%$
test_step_mdp_speed[True-True-False-True-True] 66.5200μs 35.2627μs 28.3586 KOps/s 28.0294 KOps/s $\color{#35bf28}+1.17\%$
test_step_mdp_speed[True-True-False-True-False] 55.8910μs 21.6233μs 46.2464 KOps/s 46.1837 KOps/s $\color{#35bf28}+0.14\%$
test_step_mdp_speed[True-True-False-False-True] 41.9510μs 21.2327μs 47.0971 KOps/s 46.8928 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[True-True-False-False-False] 37.1100μs 13.5275μs 73.9235 KOps/s 75.2969 KOps/s $\color{#d91a1a}-1.82\%$
test_step_mdp_speed[True-False-True-True-True] 59.5020μs 37.4936μs 26.6712 KOps/s 26.7132 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[True-False-True-True-False] 48.9200μs 23.8564μs 41.9174 KOps/s 41.9319 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[True-False-True-False-True] 48.2910μs 21.0006μs 47.6177 KOps/s 46.8240 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[True-False-True-False-False] 38.0310μs 13.4504μs 74.3471 KOps/s 73.4646 KOps/s $\color{#35bf28}+1.20\%$
test_step_mdp_speed[True-False-False-True-True] 59.3110μs 39.3787μs 25.3944 KOps/s 25.4671 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[True-False-False-True-False] 45.4520μs 25.2812μs 39.5551 KOps/s 39.0348 KOps/s $\color{#35bf28}+1.33\%$
test_step_mdp_speed[True-False-False-False-True] 42.1400μs 22.5375μs 44.3705 KOps/s 43.6890 KOps/s $\color{#35bf28}+1.56\%$
test_step_mdp_speed[True-False-False-False-False] 34.3400μs 15.1856μs 65.8517 KOps/s 65.6865 KOps/s $\color{#35bf28}+0.25\%$
test_step_mdp_speed[False-True-True-True-True] 65.2910μs 37.3052μs 26.8059 KOps/s 26.6916 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[False-True-True-True-False] 44.1000μs 23.6931μs 42.2063 KOps/s 42.3241 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[False-True-True-False-True] 54.1110μs 24.4466μs 40.9056 KOps/s 39.3832 KOps/s $\color{#35bf28}+3.87\%$
test_step_mdp_speed[False-True-True-False-False] 31.1310μs 15.0781μs 66.3214 KOps/s 65.5249 KOps/s $\color{#35bf28}+1.22\%$
test_step_mdp_speed[False-True-False-True-True] 57.8010μs 38.6576μs 25.8681 KOps/s 25.5819 KOps/s $\color{#35bf28}+1.12\%$
test_step_mdp_speed[False-True-False-True-False] 49.1010μs 25.4696μs 39.2625 KOps/s 39.5038 KOps/s $\color{#d91a1a}-0.61\%$
test_step_mdp_speed[False-True-False-False-True] 49.2110μs 26.0853μs 38.3357 KOps/s 37.1760 KOps/s $\color{#35bf28}+3.12\%$
test_step_mdp_speed[False-True-False-False-False] 33.7600μs 16.7810μs 59.5911 KOps/s 58.6042 KOps/s $\color{#35bf28}+1.68\%$
test_step_mdp_speed[False-False-True-True-True] 60.4500μs 40.8694μs 24.4682 KOps/s 24.1532 KOps/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[False-False-True-True-False] 45.8400μs 27.5457μs 36.3033 KOps/s 36.1278 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[False-False-True-False-True] 63.0510μs 26.4775μs 37.7679 KOps/s 37.2912 KOps/s $\color{#35bf28}+1.28\%$
test_step_mdp_speed[False-False-True-False-False] 43.6510μs 16.9005μs 59.1698 KOps/s 58.4945 KOps/s $\color{#35bf28}+1.15\%$
test_step_mdp_speed[False-False-False-True-True] 72.2510μs 43.3057μs 23.0917 KOps/s 22.9227 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-False-False-True-False] 61.2520μs 29.6752μs 33.6982 KOps/s 33.6650 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[False-False-False-False-True] 48.2410μs 27.7345μs 36.0562 KOps/s 35.3139 KOps/s $\color{#35bf28}+2.10\%$
test_step_mdp_speed[False-False-False-False-False] 46.2900μs 18.7918μs 53.2146 KOps/s 53.1203 KOps/s $\color{#35bf28}+0.18\%$
test_values[generalized_advantage_estimate-True-True] 25.3561ms 24.8725ms 40.2051 Ops/s 38.9242 Ops/s $\color{#35bf28}+3.29\%$
test_values[vec_generalized_advantage_estimate-True-True] 90.7562ms 2.7200ms 367.6496 Ops/s 366.7966 Ops/s $\color{#35bf28}+0.23\%$
test_values[td0_return_estimate-False-False] 87.1410μs 66.1002μs 15.1285 KOps/s 14.7668 KOps/s $\color{#35bf28}+2.45\%$
test_values[td1_return_estimate-False-False] 55.9094ms 55.6540ms 17.9682 Ops/s 17.4859 Ops/s $\color{#35bf28}+2.76\%$
test_values[vec_td1_return_estimate-False-False] 1.4091ms 1.0923ms 915.4774 Ops/s 915.8874 Ops/s $\color{#d91a1a}-0.04\%$
test_values[td_lambda_return_estimate-True-False] 88.3148ms 88.0750ms 11.3540 Ops/s 11.1981 Ops/s $\color{#35bf28}+1.39\%$
test_values[vec_td_lambda_return_estimate-True-False] 1.4508ms 1.0911ms 916.5411 Ops/s 921.0795 Ops/s $\color{#d91a1a}-0.49\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.2416ms 24.9916ms 40.0134 Ops/s 39.5182 Ops/s $\color{#35bf28}+1.25\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9612ms 0.7298ms 1.3702 KOps/s 1.3716 KOps/s $\color{#d91a1a}-0.10\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7557ms 0.6765ms 1.4781 KOps/s 1.4761 KOps/s $\color{#35bf28}+0.13\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5694ms 1.4770ms 677.0264 Ops/s 675.9658 Ops/s $\color{#35bf28}+0.16\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.7277ms 0.6914ms 1.4464 KOps/s 1.4433 KOps/s $\color{#35bf28}+0.21\%$
test_dqn_speed 1.6080ms 1.4815ms 674.9762 Ops/s 670.0532 Ops/s $\color{#35bf28}+0.73\%$
test_ddpg_speed 3.2211ms 3.0544ms 327.3939 Ops/s 334.6879 Ops/s $\color{#d91a1a}-2.18\%$
test_sac_speed 9.8250ms 8.8162ms 113.4272 Ops/s 116.7254 Ops/s $\color{#d91a1a}-2.83\%$
test_redq_speed 13.1466ms 10.9368ms 91.4340 Ops/s 93.0308 Ops/s $\color{#d91a1a}-1.72\%$
test_redq_deprec_speed 12.2030ms 11.7613ms 85.0247 Ops/s 84.5703 Ops/s $\color{#35bf28}+0.54\%$
test_td3_speed 8.7327ms 8.6516ms 115.5853 Ops/s 117.5086 Ops/s $\color{#d91a1a}-1.64\%$
test_cql_speed 28.2317ms 27.0206ms 37.0088 Ops/s 38.2846 Ops/s $\color{#d91a1a}-3.33\%$
test_a2c_speed 6.4173ms 5.8307ms 171.5069 Ops/s 174.0522 Ops/s $\color{#d91a1a}-1.46\%$
test_ppo_speed 6.3804ms 6.1688ms 162.1062 Ops/s 164.2742 Ops/s $\color{#d91a1a}-1.32\%$
test_reinforce_speed 5.0886ms 4.7299ms 211.4230 Ops/s 212.3042 Ops/s $\color{#d91a1a}-0.42\%$
test_iql_speed 20.5876ms 19.8612ms 50.3495 Ops/s 49.9144 Ops/s $\color{#35bf28}+0.87\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.0658ms 4.9388ms 202.4772 Ops/s 201.3578 Ops/s $\color{#35bf28}+0.56\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8199ms 0.6019ms 1.6615 KOps/s 1.6568 KOps/s $\color{#35bf28}+0.28\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.5795ms 0.5786ms 1.7283 KOps/s 1.7480 KOps/s $\color{#d91a1a}-1.12\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.2272ms 4.9067ms 203.8012 Ops/s 203.0738 Ops/s $\color{#35bf28}+0.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7034ms 0.5921ms 1.6889 KOps/s 1.6696 KOps/s $\color{#35bf28}+1.16\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.5912ms 0.5744ms 1.7409 KOps/s 1.4554 KOps/s $\textbf{\color{#35bf28}+19.62\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.3382ms 2.1635ms 462.2092 Ops/s 469.3042 Ops/s $\color{#d91a1a}-1.51\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 5.8501ms 2.0645ms 484.3690 Ops/s 485.6286 Ops/s $\color{#d91a1a}-0.26\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.1934ms 5.0553ms 197.8103 Ops/s 196.6807 Ops/s $\color{#35bf28}+0.57\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.5529ms 0.7320ms 1.3661 KOps/s 1.3828 KOps/s $\color{#d91a1a}-1.21\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9316ms 0.7102ms 1.4080 KOps/s 1.4276 KOps/s $\color{#d91a1a}-1.37\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.0145ms 4.9083ms 203.7385 Ops/s 200.8743 Ops/s $\color{#35bf28}+1.43\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.3101ms 0.6064ms 1.6491 KOps/s 1.6575 KOps/s $\color{#d91a1a}-0.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7378ms 0.5813ms 1.7203 KOps/s 1.7439 KOps/s $\color{#d91a1a}-1.36\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.2025ms 4.9201ms 203.2480 Ops/s 202.1427 Ops/s $\color{#35bf28}+0.55\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8457ms 0.5975ms 1.6738 KOps/s 1.6653 KOps/s $\color{#35bf28}+0.51\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.6572ms 0.5803ms 1.7231 KOps/s 1.7191 KOps/s $\color{#35bf28}+0.23\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 5.1482ms 5.0382ms 198.4822 Ops/s 197.8226 Ops/s $\color{#35bf28}+0.33\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.5317ms 0.7337ms 1.3630 KOps/s 1.3723 KOps/s $\color{#d91a1a}-0.68\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8353ms 0.7055ms 1.4174 KOps/s 1.4296 KOps/s $\color{#d91a1a}-0.86\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1149s 9.3525ms 106.9235 Ops/s 132.1828 Ops/s $\textbf{\color{#d91a1a}-19.11\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 24.9212ms 17.0647ms 58.6005 Ops/s 58.6065 Ops/s $\color{#d91a1a}-0.01\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.6121ms 1.5341ms 651.8652 Ops/s 774.7473 Ops/s $\textbf{\color{#d91a1a}-15.86\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1061s 7.1988ms 138.9116 Ops/s 138.9484 Ops/s $\color{#d91a1a}-0.03\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 19.0615ms 16.8216ms 59.4475 Ops/s 51.7443 Ops/s $\textbf{\color{#35bf28}+14.89\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.9455ms 1.5077ms 663.2446 Ops/s 746.2572 Ops/s $\textbf{\color{#d91a1a}-11.12\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1058s 7.3630ms 135.8145 Ops/s 135.3023 Ops/s $\color{#35bf28}+0.38\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 19.8410ms 17.1773ms 58.2164 Ops/s 58.6505 Ops/s $\color{#d91a1a}-0.74\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.5454ms 1.5265ms 655.0907 Ops/s 654.8308 Ops/s $\color{#35bf28}+0.04\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
quality code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not knowing Which key is causing shape mismatch
2 participants
@vmoens @facebook-github-bot